Bug 1940879

Initial licensecheck output:

$ licensecheck -r . |grep -v UNKNOWN
./LICENSE: *No copyright* Apache License 2.0
./rebuild-test-output.sh: Apache License 2.0
./setup.cfg: *No copyright* Apache License
./setup.py: Apache License 2.0
./glean/cmd.py: Apache License 2.0
./glean/install.py: Apache License 2.0
./glean/systemlock.py: Apache License 2.0
./glean/utils.py: Apache License 2.0
./doc/source/conf.py: *No copyright* Apache License 2.0
./glean/_vendor/distro.py: Apache License 2.0
./glean/init/glean.sh: *No copyright* Apache License 2.0
./glean/tests/test_glean.py: Apache License 2.0

The repository is licensed using the Apache License 2.0

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.png is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License (v2.0)",
     "Apache License (v2.0)", "*No copyright* Apache License". 178 files
     have unknown license. Detailed output of licensecheck in /tmp/python-
     glean/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-glean , python3-glean-tests
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     1.18.3.dev7
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-glean-1.18.3-0.20210323120656.4ef7647.el8.noarch.rpm
          python3-glean-tests-1.18.3-0.20210323120656.4ef7647.el8.noarch.rpm
          python-glean-doc-1.18.3-0.20210323120656.4ef7647.el8.noarch.rpm
          python-glean-1.18.3-0.20210323120656.4ef7647.el8.src.rpm
python3-glean.noarch: E: description-line-too-long C Glean is a program intended to configure a system based on configuration provided in a configuration drive.
python3-glean.noarch: E: no-changelogname-tag
python3-glean.noarch: W: no-documentation
python3-glean.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/glean/cmd.py 644 /usr/bin/python 
python3-glean.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/glean/init/glean.openrc 644 /sbin/openrc-run 
python3-glean.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/glean/systemlock.py 644 /usr/bin/python 
python3-glean.noarch: W: no-manual-page-for-binary glean
python3-glean.noarch: W: no-manual-page-for-binary glean-install
python3-glean.noarch: W: no-manual-page-for-binary glean.sh
python3-glean-tests.noarch: E: no-changelogname-tag
python3-glean-tests.noarch: W: no-documentation
python3-glean-tests.noarch: E: zero-length /usr/lib/python3.6/site-packages/glean/tests/fixtures/test/nokey.keys.out
python-glean-doc.noarch: E: no-changelogname-tag
python-glean-doc.noarch: W: file-not-utf8 /usr/share/doc/python-glean-doc/html/objects.inv
python-glean.src: E: description-line-too-long C Glean is a program intended to configure a system based on configuration provided in a configuration drive.
python-glean.src: E: no-changelogname-tag
python-glean.src: W: invalid-url Source0: glean-1.18.3.dev7-0.20210323120656.4ef7647.tar.gz
4 packages and 0 specfiles checked; 10 errors, 7 warnings.




Rpmlint (installed packages)
----------------------------
python3-glean-tests.noarch: E: no-changelogname-tag
python3-glean-tests.noarch: W: invalid-url URL: https://opendev.org/opendev/glean <urlopen error [Errno -2] Name or service not known>
python3-glean-tests.noarch: W: no-documentation
python3-glean-tests.noarch: E: zero-length /usr/lib/python3.6/site-packages/glean/tests/fixtures/test/nokey.keys.out
python-glean-doc.noarch: E: no-changelogname-tag
python-glean-doc.noarch: W: invalid-url URL: https://opendev.org/opendev/glean <urlopen error [Errno -2] Name or service not known>
python-glean-doc.noarch: W: file-not-utf8 /usr/share/doc/python-glean-doc/html/objects.inv
python3-glean.noarch: E: description-line-too-long C Glean is a program intended to configure a system based on configuration provided in a configuration drive.
python3-glean.noarch: E: no-changelogname-tag
python3-glean.noarch: W: invalid-url URL: https://opendev.org/opendev/glean <urlopen error [Errno -2] Name or service not known>
python3-glean.noarch: W: no-documentation
python3-glean.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/glean/cmd.py 644 /usr/bin/python 
python3-glean.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/glean/init/glean.openrc 644 /sbin/openrc-run 
python3-glean.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/glean/systemlock.py 644 /usr/bin/python 
python3-glean.noarch: W: no-manual-page-for-binary glean
python3-glean.noarch: W: no-manual-page-for-binary glean-install
python3-glean.noarch: W: no-manual-page-for-binary glean.sh
3 packages and 0 specfiles checked; 8 errors, 9 warnings.



Requires
--------
python3-glean (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    /usr/bin/python3
    python(abi)

python3-glean-tests (rpmlib, GLIBC filtered):
    python(abi)
    python3-glean
    python3-oslotest
    python3-testrepository
    python3-testscenarios
    python3-testtools

python-glean-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-glean:
    python3-glean
    python3.6dist(glean)
    python3dist(glean)

python3-glean-tests:
    python3-glean-tests

python-glean-doc:
    python-glean-doc

Some issues observed but are exempted or asked with maintainer to fix as follow up.
- Source0, %changelog, %define are handled by package build tool i.e DLRN.
- %description long line will be fixed in follow up
- bundled fonts:- these are in doc supackage which are generated by sphinx-build.


Package is Approved.

python-glean is included in RDO since Wallaby:

tags:
  antelope: null
  bobcat: null
  caracal: null
  caracal-uc: null
  wallaby: null
  xena: null
  yoga: null
  zed: null