Bug 1941827 - mcomix3: fixes from ROSA (1)
Summary: mcomix3: fixes from ROSA (1)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mcomix3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-22 21:16 UTC by Mikhail Novosyolov
Modified: 2021-04-02 00:16 UTC (History)
1 user (show)

Fixed In Version: mcomix3-0-0.12.D20210321gitdfe9520.fc34
Clone Of:
Environment:
Last Closed: 2021-04-02 00:16:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mikhail Novosyolov 2021-03-22 21:16:22 UTC
Hello

I've been packaging mcomix3 for ROSA Linux and used your package as a base. I had to make some importand fixes.

Git is in https://abf.io/import/mcomix3 , it inherits your git.

Important fixes are the following:

1. launcher script was too complex and did not work from some directories, I made it to work everywhere
https://abf.io/import/mcomix3/commit/964bf74d74d6a8fe48211cd8fd8109f98a1fc42f.patch

#!/bin/sh
export PYTHONPATH=@python3_sitelib@/mcomix3/mcomix3
exec @python3_sitelib@/mcomix3/mcomixstarter.py "$*"

in spec:
sed -i -e 's,@python3_sitelib@,%{python3_sitelib},g' ${DSTTOPDIR}/mcomix3starter.sh

2. comicthumb did not work, a launcher is also needed, I reused an existing one

# Wrapper symlink
mkdir %{buildroot}/%{_bindir}
ln -sf ../../${SITETOPDIR}/mcomix3starter.sh %{buildroot}%{_bindir}/mcomix3
cp -v ${DSTTOPDIR}/mcomix3starter.sh ${DSTTOPDIR}/comicthumbstarter.sh
sed -i -e 's,mcomixstarter.py,comicthumb.py,g' ${DSTTOPDIR}/comicthumbstarter.sh
ln -sf ../../${SITETOPDIR}/comicthumbstarter.sh %{buildroot}%{_bindir}/comicthumb

Comment 1 Mamoru TASAKA 2021-03-25 14:51:38 UTC
Let me have a look at this...

By the way, do you have some reproducible way to judge if comicthumb is working as expected or not? Actually at first I didn't package comicthumb because I don't know in detail how to check it, I just mimiced how Arch packages this file.

Comment 2 Mikhail Novosyolov 2021-03-25 14:54:46 UTC
(In reply to Mamoru TASAKA from comment #1)
> By the way, do you have some reproducible way to judge if comicthumb is
> working as expected or not? Actually at first I didn't package comicthumb
> because I don't know in detail how to check it, I just mimiced how Arch
> packages this file.

I did not check if the thumbnailer works or not (I did not investigate how it should work and why it would be needed), I just checked that comicthumb command laucnhes without errors of missing python module.

Comment 3 Mamoru TASAKA 2021-03-25 15:13:30 UTC
Ah, okay, thank you.

Comment 4 Fedora Update System 2021-03-29 00:10:25 UTC
FEDORA-2021-c5e3d2b88f has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-c5e3d2b88f

Comment 5 Fedora Update System 2021-03-29 01:24:07 UTC
FEDORA-2021-c5e3d2b88f has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-c5e3d2b88f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-c5e3d2b88f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-04-02 00:16:47 UTC
FEDORA-2021-c5e3d2b88f has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.