Bug 1941936 - when setting parameters in containerRuntimeConfig, it will show incorrect information on its description
Summary: when setting parameters in containerRuntimeConfig, it will show incorrect inf...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 4.8
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: 4.8.0
Assignee: Harshal Patil
QA Contact: MinLi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-23 08:22 UTC by MinLi
Modified: 2021-07-27 22:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 22:55:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-config-operator pull 2494 0 None open Bug 1941936: drop LogSizeMax and LogSizeMax in ContainrConfig when not used 2021-03-29 11:22:24 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:55:26 UTC

Description MinLi 2021-03-23 08:22:57 UTC
Description of problem:
when setting parameters in containerRuntimeConfig, it will show incorrect information on its description.For example,when set logLevel, it will also show logSizeMax and overlaySize.And when set overlaySize, it will show logSizeMax.

Version-Release number of selected component (if applicable):
4.8.0-0.nightly-2021-03-21-224928

How reproducible:
always

Steps to Reproduce:
1.$ oc label mcp worker custom-loglevel=warn

2.$ oc create -f containerRuntimeConfig_log_level.yaml
yaml file:
apiVersion: machineconfiguration.openshift.io/v1
kind: ContainerRuntimeConfig
metadata:
 name: set-loglevel
spec:
 machineConfigPoolSelector:
   matchLabels:
     custom-loglevel: warn
 containerRuntimeConfig:
   logLevel: warn


3.$ oc get ctrcfg set-loglevel -o yaml
...
spec:
  containerRuntimeConfig:
    logLevel: warn
    logSizeMax: "0"  // the next 2 lines are incorrect
    overlaySize: "0"
  machineConfigPoolSelector:
    matchLabels:
      custom-loglevel: warn
status:
  conditions:
  - lastTransitionTime: "2021-03-22T08:54:55Z"
    message: Success
    status: "True"
    type: Success
  observedGeneration: 2

Actual results:
2.create succeed
3.show incorrect information logSizeMax: "0" and overlaySize: "0", yet when checking node, the two parameters really don't be reset.

sh-4.4# crio config | grep -i log_size_max
log_size_max = -1 


Expected results:
3.it should not show incorrect information logSizeMax: "0" and overlaySize: "0"

Additional info:
Also when set "overlaySize: 10G", it will show logSizeMax: "0"
spec:
  containerRuntimeConfig:
    logSizeMax: "0"
    overlaySize: 10G
  machineConfigPoolSelector:
    matchLabels:
      custom-crio-overlay: overlay-size
status:
  conditions:
  - lastTransitionTime: "2021-03-22T08:29:29Z"
    message: Success
    status: "True"
    type: Success
  observedGeneration: 2

Comment 2 MinLi 2021-04-01 08:20:30 UTC
not fixed on version 4.8.0-0.nightly-2021-03-30-181828

containerRuntimeConfig_overlay.yaml 
---
apiVersion: machineconfiguration.openshift.io/v1
kind: ContainerRuntimeConfig
metadata:
  name: overlay-size
spec:
  containerRuntimeConfig:
    overlaySize: 9G
  machineConfigPoolSelector:
    matchLabels:
      custom-crio-overlay: overlay-size


$ oc create -f containerRuntimeConfig_overlay.yaml
containerruntimeconfig.machineconfiguration.openshift.io/overlay-size created

$ oc get ctrcfg overlay-size -o yaml 
...
spec:
  containerRuntimeConfig:
    logSizeMax: "0" // this line should not appear
    overlaySize: 9G
  machineConfigPoolSelector:
    matchLabels:
      custom-crio-overlay: overlay-size

Comment 3 Harshal Patil 2021-04-05 07:35:34 UTC
I tried with,

$ oc get clusterversion 
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.8.0-0.nightly-2021-04-03-092337   True        False         9m38s   Cluster version is 4.8.0-0.nightly-2021-04-03-092337

and it seem to be working fine,

spec:
  containerRuntimeConfig:
    overlaySize: 9G    // No 'logSizeMax' here. 
  machineConfigPoolSelector:
    matchLabels:
      custom-crio-overlay: overlay-size


Can you please try with the latest nightly?

Comment 4 MinLi 2021-04-07 04:03:03 UTC
fixed on version 4.8.0-0.nightly-2021-04-06-162113

Comment 7 errata-xmlrpc 2021-07-27 22:55:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.