Bug 1943308 - Review Request: centpkg - CentOS utility for working with dist-git
Summary: Review Request: centpkg - CentOS utility for working with dist-git
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-25 18:56 UTC by Carl George 🤠
Modified: 2021-03-26 17:12 UTC (History)
3 users (show)

Fixed In Version: centpkg-0.5.1-2.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-26 17:12:52 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Carl George 🤠 2021-03-25 18:56:16 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/james/centpkg/fedora-rawhide-x86_64/02098715-centpkg/centpkg.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/james/centpkg/fedora-rawhide-x86_64/02098715-centpkg/centpkg-0.5.1-1.fc35.src.rpm

Description:
Provides the centpkg command for working with dist-git.

Fedora Account System Username: carlwgeorge
Comment 1 Neal Gompa 2021-03-25 19:42:51 UTC 
Taking this review.
Comment 2 Neal Gompa 2021-03-25 19:53:20 UTC 
> Source0:        https://git.centos.org/centos/centpkg/archive/%{version}/centpkg-%{version}.tar.gz

You can shorten this to the following:

Source0:        %{url}/archive/%{version}/%{name}-%{version}.tar.gz
Comment 3 Neal Gompa 2021-03-25 19:59:16 UTC 
You are missing manually specified dependencies for EL7:

%if 0%{?el7}
Requires: python-pycurl
Requires: pyOpenSSL
Requires: python2-rpkg
Requires: python-six
%endif
Comment 4 Carl George 🤠 2021-03-25 20:50:58 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/james/centpkg/fedora-rawhide-x86_64/02098826-centpkg/centpkg.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/james/centpkg/fedora-rawhide-x86_64/02098826-centpkg/centpkg-0.5.1-2.fc35.src.rpm
Comment 5 Neal Gompa 2021-03-25 21:57:03 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly marked and license file is installed correctly

PACKAGE APPROVED.
Comment 6 Gwyn Ciesla 2021-03-26 13:16:25 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/centpkg
Comment 7 Carl George 🤠 2021-03-26 17:12:52 UTC 
https://bodhi.fedoraproject.org/updates/FEDORA-2021-5f90ffebf0
Note You need to log in before you can comment on or make changes to this bug.