Bug 1944424
| Summary: | Ddristributor_logo for rhel mapped to fedora icon | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Cora Loftis <coralof> | ||||
| Component: | gnome-control-center | Assignee: | Carlos Garnacho <cgarnach> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Desktop QE <desktop-qa-list> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 8.3 | CC: | bberg, feborges, mcatanza, rstrode, tpopela | ||||
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2021-03-30 14:08:36 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Cora Loftis
2021-03-29 22:01:59 UTC
Michael, can you please take a look? This is not a bug in RHEL. papirus-icon-theme theme is overriding fedora-logo-icon with an upstream Fedora logo instead of a Red Hat fedora logo, see: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/fda19e48a07b1b9a8acb22e2a2947a6a30e146e2 redhat-logos is careful to replace the icon, it's just being overridden by Papirus. So this is not our bug. I also notice the logo is subtly modified from the real Fedora logo. I'm skeptical that Papirus has permission to redistribute modified versions of our logo. Development Management has reviewed and declined this request. You may appeal this decision by reopening this request. To be clear, this icon is going to be broken everywhere, not just in gnome-control-center. RHEL expects fedora-logo-icon to be a Red Hat fedora, not a Fedora project logo. This is a reasonable expectation because it's what we ship. If we *have* granted permission to distribute our logo in icon themes, maybe the implications for downstream usage were not considered. E.g. in Fedora respins, the spin is supposed to replace the icons, and it defaults to a hot dog icon. There's no way for this to work if third-party icon themes distribute their own versions of the icon. (In reply to Cora Loftis from comment #0) > Description of problem: The "gnome-control-center.spec" config file for > gnome-control center maps the 'rhel' distribution identifier to Fedora's > logo (lines 154-155). This in turn makes any icon set other than Adwaita > (specifically tested; papirus-icon-theme) show up with a Fedora logo instead > of Red Hat's. You're looking at the RHEL 9 specfile, not the RHEL 8 specfile. This bug won't occur in RHEL 9 because there we use PNG images rather than icon theme lookup: %if 0%{?fedora} -Ddistributor_logo=%{_datadir}/pixmaps/fedora_logo_med.png \ -Ddark_mode_distributor_logo=%{_datadir}/pixmaps/fedora_whitelogo_med.png \ %endif %if 0%{?rhel} -Ddistributor_logo=%{_datadir}/pixmaps/fedora-logo.png \ -Ddark_mode_distributor_logo=%{_datadir}/pixmaps/system-logo-white.png \ %endif There's no way for Papyrus to break that because fedora-logo.png and system-logo-white.png are not icons. They've removed the symlink to fedora-logo-icon in the theme, and I've updated the icon theme to confirm that the logo is now reverted back to Red Hat's original. Thanks for your help! Well that will fix gnome-control-center, but not other places using fedora-logo-icon. To be clear, fedora-logo-icon may be expected to be a Red Hat fedora or a hot dog. Assuming it should be a Fedora project logo is not correct. It could also be a Rocky Linux logo: https://github.com/rocky-linux/rocky-logos/blob/main/icons/hicolor/256x256/apps/fedora-logo-icon.png or really anything. There's no winning here. I see Papirus has now removed the logos altogether, which was probably a good choice. :) |
