Bug 1945549

The plan here is to remove rhev-apt entirely from virt-v2v once most
customers are using RHV 4.4 (which no longer needs it).

Upstream I've removed RHEV-APT support after discussion with
Michal Skrivanek and Tomas Golembiovsky:

https://github.com/libguestfs/virt-v2v/commit/ef7bffe5699cd2ecd7b76d5d4dcf802861d85e55

Reproduced the bug with virt-v2v-1:1.44.0-1.el9.1.x86_64.

# virt-v2v -i vmx -it ssh ssh://root.75.219/vmfs/volumes/esx6.7-matrix/esx6.7-win2016-x86_64/esx6.7-win2016-x86_64.vmx -o rhv-upload -of raw -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -ip /tmp/v2v_vpx_passwd -op /tmp/rhv_upload_passwd_file  -os nfs_data -b ovirtmgmt 
[   0.5] Opening the source -i vmx ssh://root.75.219/vmfs/volumes/esx6.7-matrix/esx6.7-win2016-x86_64/esx6.7-win2016-x86_64.vmx
[   1.8] Creating an overlay to protect the source from being modified
[   2.0] Opening the overlay
[   7.6] Inspecting the overlay
[  14.4] Checking for sufficient free disk space in the guest
[  14.4] Estimating space required on target for each disk
[  14.4] Converting Windows Server 2016 Standard to run on KVM
virt-v2v: warning: /usr/share/virt-tools/rhev-apt.exe is missing, but the 
output hypervisor is oVirt or RHV.  Installing RHEV-APT in the guest would 
mean the guest is automatically updated with new drivers etc.  You may wish 
to install RHEV-APT manually after conversion.
virt-v2v: warning: there is no QXL driver for this version of Windows (10.0 
x86_64).  virt-v2v looks for this driver in 
/usr/share/virtio-win/virtio-win.iso

The guest will be configured to use a basic VGA display driver.
virt-v2v: This guest has virtio drivers installed.
[  23.2] Mapping filesystem data to avoid copying unused and blank areas
[  23.7] Closing the overlay
[  23.9] Assigning disks to buses
[  23.9] Checking if the guest needs BIOS or UEFI to boot
[  23.9] Initializing the target -o rhv-upload -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -op /tmp/rhv_upload_passwd_file -os nfs_data
[  25.2] Copying disk 1/1 to qemu URI json:{ "file.driver": "nbd", "file.path": "/tmp/v2vnbdkit.Ke9Pbg/nbdkit4.sock", "file.export": "/" } (raw)
.....
#


Verify the bug with build: virt-v2v-1:1.45.2-1.el9.x86_64.

Steps:
1. check rhev-apt has been removed from virt-v2v
# ls /usr/share/virt-tools/
rhsrvany.exe


2. Convert a windows guest from VMware by v2v, there is warning info about rhev-apt during conversion
# virt-v2v -i vmx -it ssh ssh://root.75.219/vmfs/volumes/esx6.7-matrix/esx6.7-win2012-x86_64/esx6.7-win2012-x86_64.vmx -o rhv-upload -of raw -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -ip /tmp/v2v_vpx_passwd -op /tmp/rhv_upload_passwd_file  -os nfs_data -b ovirtmgmt 
[   0.8] Opening the source -i vmx ssh://root.75.219/vmfs/volumes/esx6.7-matrix/esx6.7-win2012-x86_64/esx6.7-win2012-x86_64.vmx
[   2.2] Creating an overlay to protect the source from being modified
[   2.4] Opening the overlay
[   7.2] Inspecting the overlay
[  16.1] Checking for sufficient free disk space in the guest
[  16.1] Converting Windows Server 2012 Standard to run on KVM
virt-v2v: warning: there is no QXL driver for this version of Windows (6.2 
x86_64).  virt-v2v looks for this driver in 
/usr/share/virtio-win/virtio-win.iso

The guest will be configured to use a basic VGA display driver.
virt-v2v: This guest has virtio drivers installed.
[  23.3] Mapping filesystem data to avoid copying unused and blank areas
[  23.7] Closing the overlay
[  24.0] Assigning disks to buses
[  24.0] Checking if the guest needs BIOS or UEFI to boot
[  24.0] Initializing the target -o rhv-upload -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -op /tmp/rhv_upload_passwd_file -os nfs_data
[  25.2] Copying disk 1/1 to qemu URI json:{ "file.driver": "nbd", "file.path": "/tmp/v2vnbdkit.RLtFHt/nbdkit4.sock", "file.export": "/" } (raw)
    (100.00/100%)
[1291.8] Creating output metadata
[1292.6] Finishing off

Result:
  The bug has been fixed, so move the bug from ON_QA to VERIFIED