Spec URL: https://download.copr.fedorainfracloud.org/results/rlescak/pappl-review/fedora-rawhide-x86_64/02112188-pappl/pappl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/rlescak/pappl-review/fedora-rawhide-x86_64/02112188-pappl/pappl-1.0.2-1.fc35.src.rpm Description: PAPPL is a simple C-based framework/library for developing CUPS Printer Applications, which are the recommended replacement for printer drivers. Fedora Account System Username: rlescak Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=64959093 Known problems: Rpmlint on installed packages: pappl.x86_64: W: libdlunused-direct-shlib-dependency /usr/lib64/libpappl.so.1 /lib64/libdl.so.2 pappl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpappl.so.1 /lib64/libz.so.1 Koji building only without testsuite ("make test" commented out in .spec file - trying to identify missing requirements which are probably the cause)
(In reply to Richard Lescak from comment #0) > Known problems: > > Rpmlint on installed packages: > pappl.x86_64: W: libdlunused-direct-shlib-dependency > /usr/lib64/libpappl.so.1 /lib64/libdl.so.2 > pappl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpappl.so.1 > /lib64/libz.so.1 > I think it could be resolved with the -Wl,--as-needed. Probably the Makefile could be patched to build with the LDFLAGS. I didn't check it thoroughly, but it seems LDFLAGS are not used. > Koji building only without testsuite ("make test" commented out in .spec > file - trying to identify missing requirements which are probably the cause) > There should be description why it is disabled. If the testsuite is failing and if it could be fixed, there should be link to upstream bug/PR. Other issues found: - I think it's not ASL 2.0 license, but ASL 2.0 with exceptions, I think it should be consulted with the Fedora Legal and such license should be probably added to the list of allowed licenses - several spurious whitespaces after the line ends - inconsistent two lines space before %changelog, other sections are delimited by just one line space - spurious line space before the EOF - %set_build_flags seems redundant, I think all required flags are set by the %configure macro - 'make install', why not use macro %make_install? - unowned directories: /usr/share/pappl, /usr/include/pappl Note: The static lib seems to be used by the testsuite and it seems its installation cannot be disabled, so its removal in the %install is correct. Maybe upstream bug/PR could be created allowing disablement of the static lib installation.
Updated files and Koji build according to review, known problems also fixed (added DSOFLAGS and patch to fix tests) License is left unchanged (ASL 2.0) -> https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/message/5GMRBQYUF6NLKDEPVFU6TRVGTQ42ACQW/ Spec URL: https://download.copr.fedorainfracloud.org/results/rlescak/pappl-review/fedora-rawhide-x86_64/02130911-pappl/pappl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/rlescak/pappl-review/fedora-rawhide-x86_64/02130911-pappl/pappl-1.0.2-1.fc35.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=65861225
LGTM. The following code: dir %{_datadir}/pappl %{_datadir}/pappl/* could be simplified to: %{_datadir}/pappl But it's just FYI.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/PAPPL
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pappl
Please remove https://src.fedoraproject.org/rpms/PAPPL we already have pappl that works. Thanks for your work.
Package is available in repositories, closing.