1946258 – Review Request: ansible-collections-openstack - Openstack Ansible collections for managing Openstack cloud

Bug 1946258 - Review Request: ansible-collections-openstack - Openstack Ansible collections for managing Openstack cloud

Summary: Review Request: ansible-collections-openstack - Openstack Ansible collections...

Keywords:
Status:	CLOSED RAWHIDE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Parag Nemade
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2021-04-05 15:26 UTC by Sagi Shnaidman
Modified:	2021-05-21 17:16 UTC (History)
CC List:	4 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2021-04-26 13:22:49 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	pnemade: fedora-review+

Attachments	(Terms of Use)

Description Sagi Shnaidman 2021-04-05 15:26:17 UTC

Spec URL: https://raw.githubusercontent.com/sshnaidm/ansible-collections-openstack/rpms/ansible-collections-openstack.spec
SRPM URL: https://github.com/sshnaidm/ansible-collections-openstack/raw/rpms/ansible-collections-openstack-1.3.0-1.fc33.src.rpm
Description: The collection includes the Openstack modules and plugins supported by Openstack community to help the management of Openstack infrastructure.
Fedora Account System Username: sshnaidm

Comment 1 Sagi Shnaidman 2021-04-05 15:30:26 UTC

Link to Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=65233803

Comment 2 Parag AN(पराग) 2021-04-07 11:03:01 UTC

This package took some time to review.
Provide new SRPM and SPEC by updating release tag to 2 and adding changelog entry.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Suggestions/Issues:
1) I think no other package currently owns /usr/share/ansible/collections/ansible_collections/openstack or you have Requires: on package which provides directory /usr/share/ansible/collections/ansible_collections/openstack , hence this package should own this directory. 
Change line in %files section from
%{_datadir}/ansible/collections/ansible_collections/openstack/cloud/
to 
%{_datadir}/ansible/collections/ansible_collections/openstack/

2) I see license for this package should be "GPLv3+ and BSD". Because from the installed files of this package, files under /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/module_utils/ have header which says those files are under BSD license whereas rest files are under GPLv3+ license. When combined license becomes "GPLv3+ and BSD". Add comments as done in this package https://src.fedoraproject.org/rpms/ansible-collection-community-general/blob/rawhide/f/ansible-collection-community-general.spec#_13

# ./plugins/module_utils/ironic.py: *No copyright* BSD 2-clause "Simplified" License
# ./plugins/module_utils/openstack.py: BSD 2-clause "Simplified" License
License:        GPLv3+ and BSD

3) you need to use %global instead %define for if..else..elfi lines
   See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define

4) rpmlint output shows error like
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/auth.py 644 /usr/bin/python

Fix this in %prep section by adding at the end of %prep section
find -type f ! -executable -name '*.py' -print -exec sed -i -e '1{\@^#!.*@d}' '{}' +

5) I think you don't need below lines in %install
export PBR_VERSION=%{version}
export SKIP_PIP_INSTALL=1

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License v3.0 or later", "Apache License 2.0", "*No copyright* BSD
     2-clause "Simplified" License", "BSD 2-clause "Simplified" License",
     "GNU General Public License v3.0 or later". 155 files have unknown
     license. Detailed output of licensecheck in
     /home/test/1946258-ansible-collections-openstack/licensecheck.txt
[!]: Package requires other packages for directories it uses.
     Note: No known owner of
     /usr/share/ansible/collections/ansible_collections/openstack
[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/ansible/collections/ansible_collections/openstack
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_name ansible-
     collections-openstack.cloud, %define upstream_name ansible-
     collections-openstack
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ansible-collections-openstack-1.3.0-1.fc35.noarch.rpm
          ansible-collections-openstack-1.3.0-1.fc35.src.rpm
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/auth.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/baremetal_inspect.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/baremetal_node.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/baremetal_node_action.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/catalog_service.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/coe_cluster.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/coe_cluster_template.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/compute_flavor.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/compute_flavor_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/config.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/dns_zone.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/endpoint.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_idp.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_idp_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_mapping.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_mapping_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/floating_ip.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/group_assignment.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/host_aggregate.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_domain.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_domain_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_group_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_role.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_role_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_user.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_user_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/image.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/image_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keypair.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keypair_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keystone_federation_protocol.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keystone_federation_protocol_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_health_monitor.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_listener.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_member.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_pool.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/loadbalancer.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/network.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/networks_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/object.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_auth.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_client_config.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_coe_cluster.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_coe_cluster_template.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_flavor_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_floating_ip.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_group_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_image.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_image_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_ironic.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_ironic_inspect.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_ironic_node.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keypair.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_domain.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_domain_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_endpoint.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_federation_protocol.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_federation_protocol_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_identity_provider.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_identity_provider_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_mapping.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_mapping_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_role.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_service.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_listener.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_loadbalancer.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_member.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_network.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_networks_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_nova_flavor.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_nova_host_aggregate.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_object.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_pool.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_port.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_port_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_project.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_project_access.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_project_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_quota.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_recordset.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_router.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_routers_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_security_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_security_group_rule.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_action.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_metadata.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_stack.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_subnet.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_subnets_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user_role.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_volume_snapshot.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_zone.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/port.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/port_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/project.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/project_access.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/project_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/quota.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/recordset.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/role_assignment.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/router.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/routers_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group_rule.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group_rule_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_action.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_metadata.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/stack.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/stack_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/subnet.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/subnets_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_backup.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_backup_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_snapshot.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_snapshot_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/scripts/inventory/openstack_inventory.py 644 /usr/bin/env python
2 packages and 0 specfiles checked; 133 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/auth.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/baremetal_inspect.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/baremetal_node.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/baremetal_node_action.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/catalog_service.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/coe_cluster.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/coe_cluster_template.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/compute_flavor.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/compute_flavor_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/config.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/dns_zone.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/endpoint.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_idp.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_idp_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_mapping.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/federation_mapping_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/floating_ip.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/group_assignment.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/host_aggregate.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_domain.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_domain_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_group_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_role.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_role_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_user.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/identity_user_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/image.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/image_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keypair.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keypair_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keystone_federation_protocol.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/keystone_federation_protocol_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_health_monitor.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_listener.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_member.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/lb_pool.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/loadbalancer.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/network.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/networks_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/object.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_auth.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_client_config.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_coe_cluster.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_coe_cluster_template.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_flavor_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_floating_ip.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_group_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_image.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_image_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_ironic.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_ironic_inspect.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_ironic_node.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keypair.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_domain.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_domain_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_endpoint.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_federation_protocol.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_federation_protocol_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_identity_provider.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_identity_provider_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_mapping.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_mapping_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_role.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_keystone_service.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_listener.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_loadbalancer.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_member.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_network.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_networks_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_nova_flavor.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_nova_host_aggregate.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_object.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_pool.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_port.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_port_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_project.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_project_access.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_project_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_quota.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_recordset.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_router.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_routers_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_security_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_security_group_rule.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_action.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_metadata.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_server_volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_stack.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_subnet.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_subnets_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_user_role.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_volume_snapshot.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/os_zone.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/port.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/port_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/project.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/project_access.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/project_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/quota.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/recordset.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/role_assignment.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/router.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/routers_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group_rule.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/security_group_rule_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_action.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_group.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_metadata.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/server_volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/stack.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/stack_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/subnet.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/subnets_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_backup.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_backup_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_snapshot.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/plugins/modules/volume_snapshot_info.py 644 /usr/bin/python 
ansible-collections-openstack.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/openstack/cloud/scripts/inventory/openstack_inventory.py 644 /usr/bin/env python
1 packages and 0 specfiles checked; 133 errors, 0 warnings.



Source checksums
----------------
https://github.com/openstack/ansible-collections-openstack/archive/1.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : 944e6e11ac69538a59df8d0835733b2ae56abb7037c19538b34c05162797fff8
  CHECKSUM(SHA256) upstream package : 944e6e11ac69538a59df8d0835733b2ae56abb7037c19538b34c05162797fff8


Requires
--------
ansible-collections-openstack (rpmlib, GLIBC filtered):
    ansible
    python(abi)
    python3-openstacksdk



Provides
--------
ansible-collections-openstack:
    ansible-collections-openstack
    python3.9dist(ansible-collections-openstack-cloud)
    python3.9dist(ansible-collections-openstack.cloud)
    python3dist(ansible-collections-openstack-cloud)
    python3dist(ansible-collections-openstack.cloud)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1946258 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: PHP, Java, Python, SugarActivity, Ocaml, fonts, Haskell, C/C++, R, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Submit update for further package review again.

Comment 3 Sagi Shnaidman 2021-04-20 19:59:23 UTC

Hi, Parag
the issues were fixed:

Spec URL: https://raw.githubusercontent.com/sshnaidm/ansible-collections-openstack/rpms/ansible-collections-openstack.spec
SRPM URL: https://github.com/sshnaidm/ansible-collections-openstack/raw/rpms/ansible-collections-openstack-1.3.0-2.fc33.src.rpm

Link to a new build in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=66356691

Thanks!

Comment 4 Parag AN(पराग) 2021-04-22 05:12:30 UTC

The updated package missed to add license bifurcation as already suggested. See what review guidelines point says
[!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec.

Otherwise this package looks good now.

APPROVED.

Comment 5 Sagi Shnaidman 2021-04-22 12:27:42 UTC

@Parag, I can fix it later. But what should be license then? I set it for "License:        GPLv3+ and BSD" like you suggested.
Thanks!

Comment 6 Parag AN(पराग) 2021-04-23 03:21:06 UTC

yes license tag is correct. Just as suggested no comment lines before this license line in your spec.
Add like below

# ./plugins/module_utils/ironic.py: *No copyright* BSD 2-clause "Simplified" License
# ./plugins/module_utils/openstack.py: BSD 2-clause "Simplified" License
# all other source files are under GPLv3+ license
License:        GPLv3+ and BSD

Comment 7 Tomas Hrcka 2021-04-26 11:08:56 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collections-openstack

Comment 8 Alan Pevec (Fedora) 2021-05-14 22:52:09 UTC

Should this package be now renamed to ansible-collection-openstack since that seems to be a pattern for all other ansible-collection-* RPMs 

https://src.fedoraproject.org/projects/rpms/ansible-collection*

Comment 9 Sagi Shnaidman 2021-05-21 14:53:47 UTC

I don't think so. We ship this package to one customer at least with support exception, so we don't want them to change package names in their code.

Comment 10 Alan Pevec (Fedora) 2021-05-21 17:16:59 UTC

That's not a problem, package renames include backward-compat https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages

Note You need to log in before you can comment on or make changes to this bug.