Bug 1947685 - Review Request: ocaml-atd - Static Types for Json APIs
Summary: Review Request: ocaml-atd - Static Types for Json APIs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-08 21:48 UTC by Michel Lind
Modified: 2021-05-09 01:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-09 01:15:36 UTC
Type: ---
Embargoed:
loganjerry: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2021-04-08 21:48:34 UTC
Spec URL: https://salimma.fedorapeople.org/specs/ocaml/ocaml-atd.spec
SRPM URL: https://salimma.fedorapeople.org/specs/ocaml/ocaml-atd-2.2.1-1.fc34.src.rpm
Description:
ATD stands for Adaptable Type Definitions. It is a syntax for defining
cross-language data types. It is used as input to generate efficient and
type-safe serializers, deserializers and validators. The current target
languages are OCaml and Java.

The following opam packages are provided by the atd project:

* atdgen: executable that generates OCaml code dealing with json and
  biniou data formats
* atdj: executable that generates Java code dealing with json
* atd: library for parsing atd files used by code generators

Fedora Account System Username: salimma

Comment 1 Jerry James 2021-04-12 22:11:10 UTC
I will take this review.

Comment 2 Jerry James 2021-04-12 22:43:54 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
=======
- Do you know why the atdj and atds META files are both empty?

- The comment on line 51, "No Scala compiler in Fedora", is incorrect.  The
  Scala compiler is available in the scala package.

- Would it be worthwhile to split atdgen-codec-runtime and atdgen-runtime out
  as separate packages, so that consumers don't need to drag everything in to
  run?

- The opam and dune-package files are in the main package.  They are small
  enough that that doesn't overly concern me, but they probably fit better in
  the -devel subpackage.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ocaml:
[x]: This should never happen

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ocaml-atd-2.2.1-1.fc35.x86_64.rpm
          ocaml-atd-devel-2.2.1-1.fc35.x86_64.rpm
          ocaml-atd-debuginfo-2.2.1-1.fc35.x86_64.rpm
          ocaml-atd-debugsource-2.2.1-1.fc35.x86_64.rpm
          ocaml-atd-2.2.1-1.fc35.src.rpm
ocaml-atd.x86_64: W: spelling-error %description -l en_US serializers -> serializes, serialize rs, serialize-rs
ocaml-atd.x86_64: W: spelling-error %description -l en_US deserializers -> serializes, depersonalizes, materializes
ocaml-atd.x86_64: W: spelling-error %description -l en_US validators -> liquidators
ocaml-atd.x86_64: W: spelling-error %description -l en_US json -> son, j son, soon
ocaml-atd.x86_64: W: spelling-error %description -l en_US biniou -> bilious
ocaml-atd.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/atdcat
ocaml-atd.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/atdgen
ocaml-atd.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/atdj
ocaml-atd.x86_64: E: zero-length /usr/lib64/ocaml/atdj/META
ocaml-atd.x86_64: E: zero-length /usr/lib64/ocaml/atds/META
ocaml-atd.x86_64: W: no-manual-page-for-binary atdcat
ocaml-atd.x86_64: W: no-manual-page-for-binary atdgen
ocaml-atd.x86_64: W: no-manual-page-for-binary atdgen-cppo
ocaml-atd.x86_64: W: no-manual-page-for-binary atdj
ocaml-atd.x86_64: W: no-manual-page-for-binary cppo-json
ocaml-atd.src: W: spelling-error %description -l en_US serializers -> serializes, serialize rs, serialize-rs
ocaml-atd.src: W: spelling-error %description -l en_US deserializers -> serializes, depersonalizes, materializes
ocaml-atd.src: W: spelling-error %description -l en_US validators -> liquidators
ocaml-atd.src: W: spelling-error %description -l en_US opam -> spam, opal, Spam
ocaml-atd.src: W: spelling-error %description -l en_US atdgen -> attend
ocaml-atd.src: W: spelling-error %description -l en_US json -> son, j son, soon
ocaml-atd.src: W: spelling-error %description -l en_US biniou -> bilious
ocaml-atd.src: W: spelling-error %description -l en_US atdj -> adj
5 packages and 0 specfiles checked; 5 errors, 18 warnings.




Rpmlint (debuginfo)
-------------------
Checking: ocaml-atd-debuginfo-2.2.1-1.fc35.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
ocaml-atd.x86_64: W: spelling-error %description -l en_US serializers -> serializes, serialize rs, serialize-rs
ocaml-atd.x86_64: W: spelling-error %description -l en_US deserializers -> serializes, depersonalizes, materializes
ocaml-atd.x86_64: W: spelling-error %description -l en_US validators -> liquidators
ocaml-atd.x86_64: W: spelling-error %description -l en_US json -> son, j son, soon
ocaml-atd.x86_64: W: spelling-error %description -l en_US biniou -> bilious
ocaml-atd.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/atdcat
ocaml-atd.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/atdgen
ocaml-atd.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/atdj
ocaml-atd.x86_64: E: zero-length /usr/lib64/ocaml/atdj/META
ocaml-atd.x86_64: E: zero-length /usr/lib64/ocaml/atds/META
ocaml-atd.x86_64: W: no-manual-page-for-binary atdcat
ocaml-atd.x86_64: W: no-manual-page-for-binary atdgen
ocaml-atd.x86_64: W: no-manual-page-for-binary atdgen-cppo
ocaml-atd.x86_64: W: no-manual-page-for-binary atdj
ocaml-atd.x86_64: W: no-manual-page-for-binary cppo-json
4 packages and 0 specfiles checked; 5 errors, 10 warnings.



Source checksums
----------------
https://github.com/ahrefs/atd/archive/2.2.1/atd-2.2.1.tar.gz :
  CHECKSUM(SHA256) this package     : 071d3fb51d81445b147856a776f97e5e2b9e5b9e8d75260b8987feb5078e1bf4
  CHECKSUM(SHA256) upstream package : 071d3fb51d81445b147856a776f97e5e2b9e5b9e8d75260b8987feb5078e1bf4


Requires
--------
ocaml-atd (rpmlib, GLIBC filtered):
    /usr/bin/sh
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libm.so.6()(64bit)
    ocaml(Atd)
    ocaml(Atd__Annot)
    ocaml(Atd__Ast)
    ocaml(Atd__Check)
    ocaml(Atd__Doc_lexer)
    ocaml(Atd__Doc_types)
    ocaml(Atd__Expand)
    ocaml(Atd__Import)
    ocaml(Atd__Inherit)
    ocaml(Atd__Lexer)
    ocaml(Atd__Parser)
    ocaml(Atd__Predef)
    ocaml(Atd__Print)
    ocaml(Atd__Sort)
    ocaml(Atdgen__)
    ocaml(Atdgen_codec_runtime)
    ocaml(Atdgen_codec_runtime__Json)
    ocaml(Atdgen_runtime)
    ocaml(Bi_inbuf)
    ocaml(Bi_io)
    ocaml(Bi_outbuf)
    ocaml(Bi_share)
    ocaml(Bi_vint)
    ocaml(CamlinternalFormatBasics)
    ocaml(Easy_format)
    ocaml(Stdlib)
    ocaml(Stdlib__array)
    ocaml(Stdlib__buffer)
    ocaml(Stdlib__char)
    ocaml(Stdlib__either)
    ocaml(Stdlib__format)
    ocaml(Stdlib__hashtbl)
    ocaml(Stdlib__int32)
    ocaml(Stdlib__int64)
    ocaml(Stdlib__lexing)
    ocaml(Stdlib__list)
    ocaml(Stdlib__map)
    ocaml(Stdlib__obj)
    ocaml(Stdlib__printexc)
    ocaml(Stdlib__printf)
    ocaml(Stdlib__seq)
    ocaml(Stdlib__set)
    ocaml(Stdlib__stream)
    ocaml(Stdlib__string)
    ocaml(Stdlib__stringLabels)
    ocaml(Stdlib__sys)
    ocaml(Stdlib__uchar)
    ocaml(Yojson)
    ocamlx(Stdlib)
    ocamlx(Stdlib__array)
    ocamlx(Stdlib__buffer)
    ocamlx(Stdlib__char)
    ocamlx(Stdlib__hashtbl)
    ocamlx(Stdlib__int32)
    ocamlx(Stdlib__int64)
    ocamlx(Stdlib__lexing)
    ocamlx(Stdlib__list)
    ocamlx(Stdlib__map)
    ocamlx(Stdlib__obj)
    ocamlx(Stdlib__printexc)
    ocamlx(Stdlib__printf)
    ocamlx(Stdlib__set)
    ocamlx(Stdlib__stream)
    ocamlx(Stdlib__string)
    ocamlx(Stdlib__stringLabels)
    ocamlx(Stdlib__sys)
    rtld(GNU_HASH)

ocaml-atd-devel (rpmlib, GLIBC filtered):
    ocaml(Atd)
    ocaml(Atd__Annot)
    ocaml(Atd__Ast)
    ocaml(Atd__Check)
    ocaml(Atd__Doc_lexer)
    ocaml(Atd__Doc_types)
    ocaml(Atd__Expand)
    ocaml(Atd__Import)
    ocaml(Atd__Inherit)
    ocaml(Atd__Lexer)
    ocaml(Atd__Parser)
    ocaml(Atd__Predef)
    ocaml(Atd__Print)
    ocaml(Atd__Sort)
    ocaml(Atdgen__)
    ocaml(Atdgen_codec_runtime)
    ocaml(Atdgen_codec_runtime__Json)
    ocaml(Atdgen_runtime)
    ocaml(Bi_inbuf)
    ocaml(Bi_io)
    ocaml(Bi_outbuf)
    ocaml(Bi_share)
    ocaml(Bi_vint)
    ocaml(CamlinternalFormatBasics)
    ocaml(Easy_format)
    ocaml(Stdlib)
    ocaml(Stdlib__array)
    ocaml(Stdlib__buffer)
    ocaml(Stdlib__char)
    ocaml(Stdlib__either)
    ocaml(Stdlib__format)
    ocaml(Stdlib__hashtbl)
    ocaml(Stdlib__int32)
    ocaml(Stdlib__int64)
    ocaml(Stdlib__lexing)
    ocaml(Stdlib__list)
    ocaml(Stdlib__map)
    ocaml(Stdlib__obj)
    ocaml(Stdlib__printexc)
    ocaml(Stdlib__printf)
    ocaml(Stdlib__seq)
    ocaml(Stdlib__set)
    ocaml(Stdlib__stream)
    ocaml(Stdlib__string)
    ocaml(Stdlib__stringLabels)
    ocaml(Stdlib__sys)
    ocaml(Stdlib__uchar)
    ocaml(Yojson)
    ocaml-atd(x86-64)
    ocamlx(Stdlib)
    ocamlx(Stdlib__array)
    ocamlx(Stdlib__buffer)
    ocamlx(Stdlib__char)
    ocamlx(Stdlib__hashtbl)
    ocamlx(Stdlib__int32)
    ocamlx(Stdlib__int64)
    ocamlx(Stdlib__lexing)
    ocamlx(Stdlib__list)
    ocamlx(Stdlib__map)
    ocamlx(Stdlib__obj)
    ocamlx(Stdlib__printexc)
    ocamlx(Stdlib__printf)
    ocamlx(Stdlib__set)
    ocamlx(Stdlib__stream)
    ocamlx(Stdlib__string)
    ocamlx(Stdlib__stringLabels)
    ocamlx(Stdlib__sys)

ocaml-atd-debuginfo (rpmlib, GLIBC filtered):

ocaml-atd-debugsource (rpmlib, GLIBC filtered):



Provides
--------
ocaml-atd:
    ocaml(Atd)
    ocaml(Atd__Annot)
    ocaml(Atd__Ast)
    ocaml(Atd__Check)
    ocaml(Atd__Doc)
    ocaml(Atd__Doc_lexer)
    ocaml(Atd__Doc_types)
    ocaml(Atd__Expand)
    ocaml(Atd__Import)
    ocaml(Atd__Inherit)
    ocaml(Atd__Lexer)
    ocaml(Atd__Parser)
    ocaml(Atd__Predef)
    ocaml(Atd__Print)
    ocaml(Atd__Reflect)
    ocaml(Atd__Sort)
    ocaml(Atd__Util)
    ocaml(Atd__Version)
    ocaml(Atdgen)
    ocaml(Atdgen__)
    ocaml(Atdgen__Version)
    ocaml(Atdgen_codec_runtime)
    ocaml(Atdgen_codec_runtime__Decode)
    ocaml(Atdgen_codec_runtime__Encode)
    ocaml(Atdgen_codec_runtime__Json)
    ocaml(Atdgen_codec_runtime__Json_adapter)
    ocaml(Atdgen_runtime)
    ocaml(Atdgen_runtime__Json_adapter)
    ocaml(Atdgen_runtime__Ob_run)
    ocaml(Atdgen_runtime__Oj_run)
    ocaml(Atdgen_runtime__Ov_run)
    ocaml(Atdgen_runtime__Util)
    ocaml(Atdgen_runtime__Version)
    ocaml-atd
    ocaml-atd(x86-64)
    ocamlx(Atd)
    ocamlx(Atd__Annot)
    ocamlx(Atd__Ast)
    ocamlx(Atd__Check)
    ocamlx(Atd__Doc)
    ocamlx(Atd__Doc_lexer)
    ocamlx(Atd__Doc_types)
    ocamlx(Atd__Expand)
    ocamlx(Atd__Import)
    ocamlx(Atd__Inherit)
    ocamlx(Atd__Lexer)
    ocamlx(Atd__Parser)
    ocamlx(Atd__Predef)
    ocamlx(Atd__Print)
    ocamlx(Atd__Reflect)
    ocamlx(Atd__Sort)
    ocamlx(Atd__Util)
    ocamlx(Atd__Version)
    ocamlx(Atdgen)
    ocamlx(Atdgen__)
    ocamlx(Atdgen__Version)
    ocamlx(Atdgen_codec_runtime)
    ocamlx(Atdgen_codec_runtime__Decode)
    ocamlx(Atdgen_codec_runtime__Encode)
    ocamlx(Atdgen_codec_runtime__Json)
    ocamlx(Atdgen_codec_runtime__Json_adapter)
    ocamlx(Atdgen_runtime)
    ocamlx(Atdgen_runtime__Json_adapter)
    ocamlx(Atdgen_runtime__Ob_run)
    ocamlx(Atdgen_runtime__Oj_run)
    ocamlx(Atdgen_runtime__Ov_run)
    ocamlx(Atdgen_runtime__Util)
    ocamlx(Atdgen_runtime__Version)

ocaml-atd-devel:
    ocaml(Atd)
    ocaml(Atd__Annot)
    ocaml(Atd__Ast)
    ocaml(Atd__Check)
    ocaml(Atd__Doc)
    ocaml(Atd__Doc_lexer)
    ocaml(Atd__Doc_types)
    ocaml(Atd__Expand)
    ocaml(Atd__Import)
    ocaml(Atd__Inherit)
    ocaml(Atd__Lexer)
    ocaml(Atd__Parser)
    ocaml(Atd__Predef)
    ocaml(Atd__Print)
    ocaml(Atd__Reflect)
    ocaml(Atd__Sort)
    ocaml(Atd__Util)
    ocaml(Atd__Version)
    ocaml(Atdgen)
    ocaml(Atdgen__)
    ocaml(Atdgen__Version)
    ocaml(Atdgen_codec_runtime)
    ocaml(Atdgen_codec_runtime__Decode)
    ocaml(Atdgen_codec_runtime__Encode)
    ocaml(Atdgen_codec_runtime__Json)
    ocaml(Atdgen_codec_runtime__Json_adapter)
    ocaml(Atdgen_runtime)
    ocaml(Atdgen_runtime__Json_adapter)
    ocaml(Atdgen_runtime__Ob_run)
    ocaml(Atdgen_runtime__Oj_run)
    ocaml(Atdgen_runtime__Ov_run)
    ocaml(Atdgen_runtime__Util)
    ocaml(Atdgen_runtime__Version)
    ocaml-atd-devel
    ocaml-atd-devel(x86-64)
    ocamlx(Atd)
    ocamlx(Atd__Annot)
    ocamlx(Atd__Ast)
    ocamlx(Atd__Check)
    ocamlx(Atd__Doc)
    ocamlx(Atd__Doc_lexer)
    ocamlx(Atd__Doc_types)
    ocamlx(Atd__Expand)
    ocamlx(Atd__Import)
    ocamlx(Atd__Inherit)
    ocamlx(Atd__Lexer)
    ocamlx(Atd__Parser)
    ocamlx(Atd__Predef)
    ocamlx(Atd__Print)
    ocamlx(Atd__Reflect)
    ocamlx(Atd__Sort)
    ocamlx(Atd__Util)
    ocamlx(Atd__Version)
    ocamlx(Atdgen)
    ocamlx(Atdgen__)
    ocamlx(Atdgen__Version)
    ocamlx(Atdgen_codec_runtime)
    ocamlx(Atdgen_codec_runtime__Decode)
    ocamlx(Atdgen_codec_runtime__Encode)
    ocamlx(Atdgen_codec_runtime__Json)
    ocamlx(Atdgen_codec_runtime__Json_adapter)
    ocamlx(Atdgen_runtime)
    ocamlx(Atdgen_runtime__Json_adapter)
    ocamlx(Atdgen_runtime__Ob_run)
    ocamlx(Atdgen_runtime__Oj_run)
    ocamlx(Atdgen_runtime__Ov_run)
    ocamlx(Atdgen_runtime__Util)
    ocamlx(Atdgen_runtime__Version)

ocaml-atd-debuginfo:
    debuginfo(build-id)
    ocaml-atd-debuginfo
    ocaml-atd-debuginfo(x86-64)

ocaml-atd-debugsource:
    ocaml-atd-debugsource
    ocaml-atd-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1947685 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Ocaml, Generic
Disabled plugins: Perl, Python, fonts, Haskell, SugarActivity, R, PHP, Java, Ruby
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 3 Michel Lind 2021-04-21 02:47:52 UTC
(In reply to Jerry James from comment #2)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> Issues:
> =======
> - Do you know why the atdj and atds META files are both empty?
> 
no idea; should I just remove them?

> - The comment on line 51, "No Scala compiler in Fedora", is incorrect.  The
>   Scala compiler is available in the scala package.
ah, somehow when I tried to find scalac I couldn't. you're right, let me reenable that

> 
> - Would it be worthwhile to split atdgen-codec-runtime and atdgen-runtime out
>   as separate packages, so that consumers don't need to drag everything in to
>   run?
sure. they're available as separate opam modules so that makes sense

> 
> - The opam and dune-package files are in the main package.  They are small
>   enough that that doesn't overly concern me, but they probably fit better in
>   the -devel subpackage.
> 
good point. Will update, thanks

Comment 4 Jerry James 2021-04-23 14:47:24 UTC
(In reply to Michel Alexandre Salim from comment #3)
> (In reply to Jerry James from comment #2)
> > - Do you know why the atdj and atds META files are both empty?
> > 
> no idea; should I just remove them?

I would think those files should have content in them.  I'm worried that something is wrong, and the empty files is a symptom of that.  I'll poke at it today and see if I can figure out what's going on there.

Comment 5 Jerry James 2021-04-23 15:54:12 UTC
This is the story: https://github.com/ocaml/dune/issues/2353

So it's a dune bug and will hopefully be fixed at some point.  I'd say you don't need to do anything.

Comment 6 Michel Lind 2021-04-24 00:26:48 UTC
(In reply to Jerry James from comment #5)
> This is the story: https://github.com/ocaml/dune/issues/2353
> 
> So it's a dune bug and will hopefully be fixed at some point.  I'd say you
> don't need to do anything.

per a comment in the issue, "We should indeed generate no META and no dune-package file" so I can just exclude the files, right? Given that the issue is over a year old I'd rather not just assume the files will be gone eventually :). I'll reference the issue when excluding the files, thanks

Comment 7 Michel Lind 2021-04-24 01:35:00 UTC
Spec URL: https://salimma.fedorapeople.org/specs/ocaml/ocaml-atd.spec
SRPM URL: https://salimma.fedorapeople.org/specs/ocaml/ocaml-atd-2.2.1-2.fc34.src.rpm

I ended up creating one (or two if -devel is needed) subpackage per OPAM module. The scala tests are failing so I'm disabling it for now but hiding it behind %bcond_with so we can revisit later.

Comment 8 Jerry James 2021-04-24 02:01:40 UTC
(In reply to Michel Alexandre Salim from comment #6)
> per a comment in the issue, "We should indeed generate no META and no
> dune-package file" so I can just exclude the files, right? Given that the
> issue is over a year old I'd rather not just assume the files will be gone
> eventually :). I'll reference the issue when excluding the files, thanks

Sure, that seems fine.

(In reply to Michel Alexandre Salim from comment #7)
> I ended up creating one (or two if -devel is needed) subpackage per OPAM
> module. The scala tests are failing so I'm disabling it for now but hiding
> it behind %bcond_with so we can revisit later.

Ah, the problem is that there is no atds/test/argonaut_2.13-6.2.2.jar.  The tests only work with scala 2.11 or 2.12, and we have 2.13 in F34 and Rawhide.  If upstream will make a scala 2.13 version of that jar, the scala tests should work again.

Anyway, this all looks great.  This package is APPROVED.

Comment 9 Michel Lind 2021-04-26 01:32:18 UTC
Thanks!

https://pagure.io/releng/fedora-scm-requests/issue/33695

Comment 10 Jens Petersen 2021-04-26 06:36:25 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-atd

Comment 11 Fedora Update System 2021-04-30 20:37:11 UTC
FEDORA-2021-0b547d721b has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0b547d721b

Comment 12 Fedora Update System 2021-04-30 20:37:12 UTC
FEDORA-2021-bddba53e4e has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bddba53e4e

Comment 13 Fedora Update System 2021-05-01 02:05:43 UTC
FEDORA-2021-0b547d721b has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0b547d721b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0b547d721b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-05-01 02:10:47 UTC
FEDORA-2021-bddba53e4e has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-bddba53e4e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bddba53e4e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2021-05-09 01:15:36 UTC
FEDORA-2021-bddba53e4e has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2021-05-09 01:34:37 UTC
FEDORA-2021-0b547d721b has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.