Bug 1947944 - Document vdsm-hooks not installed by default anymore on the hosts [NEEDINFO]
Summary: Document vdsm-hooks not installed by default anymore on the hosts
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: Documentation
Version: 4.4.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.7
: ---
Assignee: Steve Goodman
QA Contact: Pavol Brilla
URL:
Whiteboard:
Depends On: 1947450
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-09 14:54 UTC by Sandro Bonazzola
Modified: 2021-08-08 13:20 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Removed functionality
Doc Text:
Previously, VDSM hooks were installed by default, as a dependency, when installing a RHEL host or a RHV-H host. Starting with Red Hat Virtualization 4.4.7, VDSM hooks are not installed by default. You can manually install VDSM hooks as needed. Additional resources: * Bug 1947450 "ovirt-host shouldn't have hard dependency on vdsm hooks" * "Installing a VDSM hook" in the RHV Administration Guide
Clone Of:
Environment:
Last Closed: 2021-07-22 12:49:23 UTC
oVirt Team: Integration
Target Upstream Version:
Embargoed:
yiwwang: needinfo?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1947450 1 medium CLOSED ovirt-host shouldn't have hard dependency on vdsm hooks 2021-11-04 19:28:55 UTC

Description Sandro Bonazzola 2021-04-09 14:54:09 UTC
In 4.4.7 we are removing vdsm-hooks from ovirt-host package dependencies (bug #1947450).
This means that while deploying a new RHEL based host the hooks are not going to be installed automatically anymore.
This also means that the hooks are not included in RHV-H image anymore and will be made available as optional installable packages in RHV-H channel.

Comment 3 Audrey Spaulding 2021-05-07 12:47:32 UTC
I looked at who has done the revisions to 69327, and it has been Vivien Wang and Martin Tessun. Sandro sent an email earlier today about this issue, and Vivien indicated that she will track it. So I don't think that we will be updating 69327 unless we are specifically asked to do so. Thanks.

Comment 4 Sandro Bonazzola 2021-06-17 07:30:49 UTC
To clarify:
on RHEL-H the hooks are provided in the same channel providing vdsm so no additional channel needed.
on RHV-H the hooks are provided in the RHV-H channel, so no additional channel needed.
Upstream wise ovirt-release has been updated so no change required to yum repo for getting the hooks.

In order to install the needed hook you just need to use dnf install with the hook you need.

Comment 7 Steve Goodman 2021-06-17 08:56:59 UTC
Michal,

Where do we have a list of hooks available to install? Now that we're telling users how to install each hook separately, we need to tell them where to see all the available hooks. The Admin Guide does not list a catalogue of available hooks, nor does it provide a pointer to any place that does provide such a list.

If I understand correctly, a list of installed hooks used to be installed at /usr/libexec/vdsm/hooks/.

But now that won't be the case, so we need to tell our users where to find that info, otherwise they won't be able to install any hooks.

For oVirt, I found an old page about hooks [1], and using that page together with comment 5, I was able to find three locations on ovirt.org with a bunch of vdsm hooks for noarch [2], x86_64 [3] and ppcle [4]:

Should I provide references to [2] [3] and [4] in the RHV documentation?

----

[1] https://www.ovirt.org/develop/developer-guide/vdsm/hooks.html
[2] noarch: https://resources.ovirt.org/pub/ovirt-4.4/rpm/el8/noarch/
[3] x86_64: https://resources.ovirt.org/pub/ovirt-4.4/rpm/el8/x86_64/
[4] ppc64le: https://resources.ovirt.org/pub/ovirt-4.4/rpm/el8/ppc64le/

Comment 8 Michal Skrivanek 2021-06-17 10:08:21 UTC
(In reply to Steve Goodman from comment #7)
> Michal,
> 
> Where do we have a list of hooks available to install? 

Ultimately they are in CDN...we release them always with vdsm build. I do not think we have to enumerate them in docs, whenever such hook is part of a feature it gets explicit reference in the relevant place

> Now that we're
> telling users how to install each hook separately, we need to tell them
> where to see all the available hooks. The Admin Guide does not list a
> catalogue of available hooks, nor does it provide a pointer to any place
> that does provide such a list.
>
> If I understand correctly, a list of installed hooks used to be installed at
> /usr/libexec/vdsm/hooks/.

well, it doesn't matter there the content goes, from user perspective it's all about additional "yum install vdsm-hook-xyz" and then some specific configuration usually in webadmin (e.g. https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/administration_guide/index#How_to_Set_Up_RHVM_to_Use_FCoE)
Appendix A in admin guide is going into a greater details because that's meant for custom hook writing.
 
> But now that won't be the case, so we need to tell our users where to find
> that info, otherwise they won't be able to install any hooks.
> 
> For oVirt, I found an old page about hooks [1], and using that page together
> with comment 5, I was able to find three locations on ovirt.org with a bunch
> of vdsm hooks for noarch [2], x86_64 [3] and ppcle [4]:
> 
> Should I provide references to [2] [3] and [4] in the RHV documentation?

rather not, they are all the hooks that exist for oVirt, many do not really work anymore or lack documentation

> 
> ----
> 
> [1] https://www.ovirt.org/develop/developer-guide/vdsm/hooks.html
> [2] noarch: https://resources.ovirt.org/pub/ovirt-4.4/rpm/el8/noarch/
> [3] x86_64: https://resources.ovirt.org/pub/ovirt-4.4/rpm/el8/x86_64/
> [4] ppc64le: https://resources.ovirt.org/pub/ovirt-4.4/rpm/el8/ppc64le/

Comment 10 Vivien Wang 2021-06-17 11:42:31 UTC
I'll have to confirm these change requests with our SMEs as well.

(In reply to Steve Goodman from comment #9)
> We need to add this info in the Install Guides (e.g. at the end of [1] and
> [1.5]), the Upgrade Guide [2] and Appendix A.2 (VDSM Hooks) in the Admin
> Guide [3]
> 
> [1]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/installing_red_hat_virtualization_as_a_self-
> hosted_engine_using_the_command_line/
> index#Enabling_the_RHVH_repository_SHE_cli_deploy
> [1.5]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/installing_red_hat_virtualization_as_a_self-
> hosted_engine_using_the_command_line/
> index#Enabling_the_Red_Hat_Enterprise_Linux_Host_Repositories_SHE_cli_deploy
> [2]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/upgrade_guide/index#Upgrading_hosts_to_4-4_4-3_SHE
> [3]
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/
> html-single/administration_guide/index#VDSM_hooks

Comment 13 Steve Goodman 2021-07-16 05:18:40 UTC
From Sandro in gchat:

LGTM

Moving to ON_QA.

Comment 15 Vivien Wang 2021-07-16 08:04:51 UTC
CC: @koconnor

Comment 17 Pavol Brilla 2021-07-19 13:40:15 UTC
Documentation of vdsm-hooks is fine, intallations of hook and there deps was tested by tps testing

Comment 18 Steve Goodman 2021-07-19 13:56:46 UTC
Merged.

Comment 19 Vivien Wang 2021-07-19 23:32:38 UTC
https://access.redhat.com/solutions/69327 has been updated by the SAP Alliance Team to reflect the removal of default vdsm-hooks installation in RHV 4.4.7.


Note You need to log in before you can comment on or make changes to this bug.