Bug 1948522 - pytest's own tests fail with Python 3.10
Summary: pytest's own tests fail with Python 3.10
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: pytest
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2021-04-12 11:04 UTC by Tomáš Hrnčiar
Modified: 2021-06-08 09:29 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-08 09:29:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github pytest-dev pytest issues 8546 0 None open Test failures with Python 3.10.0a7 2021-04-12 19:32:56 UTC

Description Tomáš Hrnčiar 2021-04-12 11:04:33 UTC
pytest fails to build with Python 3.10.0a7.

=================================== FAILURES ===================================
_____________________________ test_run_result_repr _____________________________

    def test_run_result_repr() -> None:
        outlines = ["some", "normal", "output"]
        errlines = ["some", "nasty", "errors", "happened"]
    
        # known exit code
        r = pytester.RunResult(1, outlines, errlines, duration=0.5)
>       assert (
            repr(r) == "<RunResult ret=ExitCode.TESTS_FAILED len(stdout.lines)=3"
            " len(stderr.lines)=4 duration=0.50s>"
        )
E       AssertionError: assert '<RunResult r...ration=0.50s>' == '<RunResult r...ration=0.50s>'
E         - <RunResult ret=ExitCode.TESTS_FAILED len(stdout.lines)=3 len(stderr.lines)=4 duration=0.50s>
E         ?                ---------
E         + <RunResult ret=TESTS_FAILED len(stdout.lines)=3 len(stderr.lines)=4 duration=0.50s>

testing/test_pytester.py:744: AssertionError
________________________ TestMetafunc.test_idmaker_enum ________________________

self = <metafunc.TestMetafunc object at 0x7f7f78c9be50>

    def test_idmaker_enum(self) -> None:
        enum = pytest.importorskip("enum")
        e = enum.Enum("Foo", "one, two")
        result = idmaker(("a", "b"), [pytest.param(e.one, e.two)])
>       assert result == ["Foo.one-Foo.two"]
E       AssertionError: assert ['one-two'] == ['Foo.one-Foo.two']
E         At index 0 diff: 'one-two' != 'Foo.one-Foo.two'
E         Use -v to get the full diff

testing/python/metafunc.py:451: AssertionError
=========================== short test summary info ============================
SKIPPED [1] testing/test_capture.py:1433: only on windows
SKIPPED [1] testing/test_pathlib.py:420: Windows only
SKIPPED [1] testing/test_tmpdir.py:238: win only
SKIPPED [1] testing/test_config.py:1790: does not work with xdist currently
SKIPPED [1] testing/test_conftest.py:291: only relevant for case insensitive file systems
SKIPPED [1] testing/test_unittest.py:1235: could not import 'asynctest': No module named 'asynctest'
SKIPPED [3] testing/test_warnings.py:514: This test should be enabled again before pytest 7.0 is released
SKIPPED [1] testing/test_faulthandler.py:52: sometimes crashes on CI (#7022)
====== 2 failed, 3031 passed, 10 skipped, 10 xfailed in 202.60s (0:03:22) ======

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02129345-pytest/

For all our attempts to build pytest with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/pytest/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2021-04-12 16:53:26 UTC
Looks like a repr of an exception changed.

Comment 2 Miro Hrončok 2021-04-12 19:32:56 UTC
Reported at https://github.com/pytest-dev/pytest/issues/8546

See also "Assertion rewriting fails under Python 3.10-alpha07" https://github.com/pytest-dev/pytest/issues/8539

Comment 3 Miro Hrončok 2021-04-14 10:08:22 UTC
A potential fix in https://github.com/pytest-dev/pytest/pull/8555

Comment 4 Miro Hrončok 2021-05-11 17:29:20 UTC
The current failures with b1 are different. Will examine them more closely later this week.

Comment 5 Miro Hrončok 2021-05-12 11:06:13 UTC
There are 4 failures

TestMetafunc.test_idmaker_enum and test_run_result_repr is fixed in https://github.com/pytest-dev/pytest/commit/710446420c0bb98f0761724ec865a894820bb610

test_errors_in_xfail_skip_expressions is fixed in https://github.com/pytest-dev/pytest/commit/382599287f4cab914bd7502887072e7f325cdb09

TestTrialUnittest.test_trial_error is not fixed, reported in https://github.com/pytest-dev/pytest/issues/8663

Comment 6 Miro Hrončok 2021-05-12 11:32:50 UTC
(In reply to Miro Hrončok from comment #5)
> TestTrialUnittest.test_trial_error is not fixed, reported in
> https://github.com/pytest-dev/pytest/issues/8663

https://github.com/pytest-dev/pytest/pull/8664

Comment 8 Miro Hrončok 2021-06-04 20:13:35 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 9 Miro Hrončok 2021-06-07 22:58:21 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.


Note You need to log in before you can comment on or make changes to this bug.