Bug 1948661 - Review Request: perl-YAML-PP-LibYAML - Faster parsing for YAML::PP
Summary: Review Request: perl-YAML-PP-LibYAML - Faster parsing for YAML::PP
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Josef Spacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1948651
Blocks: 1947805
TreeView+ depends on / blocked
 
Reported: 2021-04-12 17:40 UTC by Jitka Plesnikova
Modified: 2021-05-12 12:06 UTC (History)
2 users (show)

Fixed In Version: perl-YAML-PP-LibYAML-0.005-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-12 12:06:25 UTC
Type: ---
Embargoed:
mspacek: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2021-04-12 17:40:07 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-YAML-PP-LibYAML/perl-YAML-PP-LibYAML.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-YAML-PP-LibYAML/perl-YAML-PP-LibYAML-0.005-1.fc35.src.rpm
Description:
YAML::PP::LibYAML is a subclass of YAML::PP. Instead of using
YAML::PP::Parser as a the backend parser, it uses YAML::PP::LibYAML::Parser
which calls YAML::LibYAML::API, an XS wrapper around the C libyaml.

Fedora Account System Username: jplesnik

Comment 1 Michal Josef Spacek 2021-05-11 07:45:40 UTC
Issues:
- "YAML::LibYAML::API" => "0.011" in Makefile.PL vs perl(YAML::LibYAML::API::XS) >= 0.012 in spec file

[X] read spec file and check
[X] Build in mock
[X] rpmlint check
[X] fedora-review build and check
[X] look to final rpm dependencies 

I am approving this package.

Comment 2 Michal Josef Spacek 2021-05-11 08:03:30 UTC
Better review :-)

Issues:
- "YAML::LibYAML::API" => "0.011" in Makefile.PL vs perl(YAML::LibYAML::API::XS) >= 0.012 in spec file

[X] source file
[X] summary
[X] description
[X] license
[X] URL
[X] Source0
[X] tests passed
[X] BuildRequires

> rpm -qp --requires perl-YAML-PP-LibYAML-0.005-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 perl(YAML::LibYAML::API::XS) >= 0.011
      1 perl(YAML::PP::Emitter)
      1 perl(YAML::PP::LibYAML::Emitter)
      1 perl(YAML::PP::LibYAML::Parser)
      1 perl(YAML::PP::Parser)
      1 perl(YAML::PP::Reader)
      1 perl(YAML::PP::Writer)
      1 perl(YAML::PP) >= 0.025

> rpm -qp --provides perl-YAML-PP-LibYAML-0.005-1.fc35.noarch.rpm | sort | uniq -c
      1 perl(YAML::PP::LibYAML::Emitter) = 0.005
      1 perl(YAML::PP::LibYAML::Parser) = 0.005
      1 perl(YAML::PP::LibYAML) = 0.005
      1 perl-YAML-PP-LibYAML = 0.005-1.fc35

> rpmlint perl-YAML-PP-LibYAML-0.005-1.fc35.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

The package is in line with Fedora and Perl packaging guide lines.

Comment 3 Jitka Plesnikova 2021-05-11 08:07:53 UTC
https://pagure.io/releng/fedora-scm-requests/issue/33905

Comment 4 Jens Petersen 2021-05-11 09:28:43 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-YAML-PP-LibYAML

Comment 5 Jitka Plesnikova 2021-05-12 12:06:25 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.