Bug 1948787 - secret.StringData shouldn't be used for reads
Summary: secret.StringData shouldn't be used for reads
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Bare Metal Hardware Provisioning
Version: 4.8
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
: 4.8.0
Assignee: Angus Salkeld
QA Contact: Amit Ugol
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-12 22:21 UTC by Stephen Benjamin
Modified: 2021-07-27 23:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: a write only field was used to determine if data was present. Consequence: This lead to continuous (unnecessary) secret updates. Fix: secret.Data was used instead. Result: no unnecessary secret updates.
Clone Of:
Environment:
Last Closed: 2021-07-27 22:59:54 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-baremetal-operator pull 125 0 None open Bug 1948787: secret.StringData is a WriteOnly convience field, stop using it to read 2021-04-12 22:23:27 UTC
Github openshift cluster-baremetal-operator pull 127 0 None open Bug 1948787: follow up : Use applySecret() 2021-04-13 01:26:09 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:00:11 UTC

Description Stephen Benjamin 2021-04-12 22:21:33 UTC 
CBO is making a high number of requests on a full e2e run, upwards of 100K -- mostly gets requests. This appears to be due to using secret.StringData for reads.
Comment 4 errata-xmlrpc 2021-07-27 22:59:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438
Note You need to log in before you can comment on or make changes to this bug.