Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/02077198-seatd/seatd.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/02077198-seatd/seatd-0.5.0-0.1.fc35.src.rpm Description: A minimal seat management daemon, and a universal seat management library. Seat management takes care of mediating access to shared devices (graphics, input), without requiring the applications needing access to be root. Fedora Account System Username: alebastr Review notes: Dependency for future releases of wlroots and weston: https://github.com/swaywm/wlroots/pull/2786 https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/589 seatd server is disabled by default after discussing with upstream as it doesn't really play well with systemd-logind. I'm not planning to use, test or support this setup in Fedora. builtin backend is not enabled as (again) we're going to rely on systemd-logind instead of granting SUID to each and every wlroots-based compositor.
Taking this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 44 files have unknown license. Detailed output of licensecheck in /home/ngompa/1949358-seatd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libseat-0.5.0-0.1.fc35.x86_64.rpm libseat-devel-0.5.0-0.1.fc35.x86_64.rpm seatd-debugsource-0.5.0-0.1.fc35.x86_64.rpm seatd-0.5.0-0.1.fc35.src.rpm libseat.x86_64: W: spelling-error %description -l en_US seatd -> seats, seat, seated libseat.x86_64: W: spelling-error %description -l en_US logind -> login, log ind, log-ind libseat-devel.x86_64: W: no-documentation seatd.src: W: spelling-error %description -l en_US deamon -> daemon, demon, deacon 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- libseat.x86_64: W: spelling-error %description -l en_US seatd -> seats, seat, seated libseat.x86_64: W: spelling-error %description -l en_US logind -> login, log ind, log-ind libseat-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://git.sr.ht/~kennylevinsen/seatd/archive/0.5.0.tar.gz#/seatd-0.5.0.tar.gz : CHECKSUM(SHA256) this package : 274b56324fc81ca6002bc1cdd387668dee34a6e1063e5f3896805c3770948988 CHECKSUM(SHA256) upstream package : 274b56324fc81ca6002bc1cdd387668dee34a6e1063e5f3896805c3770948988 Requires -------- libseat (rpmlib, GLIBC filtered): libc.so.6()(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libsystemd.so.0(LIBSYSTEMD_213)(64bit) libsystemd.so.0(LIBSYSTEMD_221)(64bit) libsystemd.so.0(LIBSYSTEMD_237)(64bit) rtld(GNU_HASH) libseat-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libseat(x86-64) libseat.so.1()(64bit) pkgconfig(libsystemd) seatd-debugsource (rpmlib, GLIBC filtered): Provides -------- libseat: libseat libseat(x86-64) libseat.so.1()(64bit) libseat-devel: libseat-devel libseat-devel(x86-64) pkgconfig(libseat) seatd-debugsource: seatd-debugsource seatd-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1949358 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, PHP, Perl, Haskell, Ocaml, R, SugarActivity, Python, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
This package looks good to me. PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/seatd
Thanks for the review, Neal!