Bug 1949882 - service-idler build error
Summary: service-idler build error
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.8
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.8.0
Assignee: Ben Bennett
QA Contact: zhaozhanqi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-15 10:11 UTC by Yuxiang Zhu
Modified: 2023-09-15 01:05 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 23:00:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift service-idler pull 13 0 None open Bug 1949882: Fix build error with Go 1.16 2021-04-15 10:14:04 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:01:12 UTC

Description Yuxiang Zhu 2021-04-15 10:11:16 UTC
Description of problem:
A build error occurs when we build service-idler for OCP 4.8, which uses a Go 1.16 compiler.

$ go build -o service-idler github.com/openshift/service-idler/cmd/service-idler
no required module provides package github.com/openshift/service-idler/cmd/service-idler: working directory is not part of a module
According to https://blog.golang.org/go116-module-changes,
Go 1.16 builds packages in module-aware mode by default, even when no go.mod is present.
This results in a build error in Go 1.16.

Fix is in https://github.com/openshift/service-idler/pull/13:

This PR temporarily sets GO111MODULE=auto to continue to build this package in GOPATH mode.

Note Go team plans to drop support for GOPATH mode in Go 1.17. Please migrate to Go Modules before that happens.

Version-Release number of selected component (if applicable):
4.8.0-nightly

I didn't see a bz component for service-idler, so created this bug for the Release component. Needs to get someone review ASAP to unblock the build.

Comment 3 Maciej Szulik 2021-04-26 10:33:16 UTC
I'm sending this over to Ben Bennet who claimed will look into it.

Comment 6 zhaozhanqi 2021-05-14 08:14:44 UTC
Move this to verified

Comment 9 errata-xmlrpc 2021-07-27 23:00:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438

Comment 10 Red Hat Bugzilla 2023-09-15 01:05:11 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days


Note You need to log in before you can comment on or make changes to this bug.