Bug 1949935 - Fix incorrect access review check on start pipeline kebab action
Summary: Fix incorrect access review check on start pipeline kebab action
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.7
Hardware: All
OS: All
high
high
Target Milestone: ---
: 4.8.0
Assignee: Karthik Jeeyar
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 1950214
TreeView+ depends on / blocked
 
Reported: 2021-04-15 12:31 UTC by Karthik Jeeyar
Modified: 2021-07-27 23:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 23:00:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
The incorrect access review check on start pipeline kebab action is fixed-1 (31.07 KB, image/png)
2021-04-16 09:16 UTC, spathak@redhat.com
no flags Details
The incorrect access review check on start pipeline kebab action is fixed-2 (43.81 KB, image/png)
2021-04-16 09:17 UTC, spathak@redhat.com
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8670 0 None open Bug 1949935: Fix start pipeline action access review 2021-04-15 12:32:59 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:01:12 UTC

Description Karthik Jeeyar 2021-04-15 12:31:25 UTC
Description of problem:

Start pipeline kebab action is disabled even if the developer user has create permissions on PipelineRun resource. Access review check should be on pipelineRun instead of pipeline resource.

Customer wants to prevents non-technical users from modifying or creating pipelines but still allow then to start the existing pipelines. They have created a role that gives "view" access to "Pipeline" resources and "create" access to "PipelineRun" and "TaskRuns". 


Version-Release number of selected component (if applicable):
4.6

How reproducible:
Always

Steps to Reproduce:
1.Create a role with "view" access on "Pipeline" and "create" access on "PipelineRun" and "TaskRun"
2. Login as a user that has the above role
3. Go to a namespace with an exist pipeline and click on the Pipelines in the nav
4. Click on the kebab menu of the existing pipeline

Actual results:
"Start" is disabled while "Start Last Run" is enabled. The rest of actions are disabled.



Expected results:

"Start" and "Start Last Run" are enabled while the rest of actions are disabled.



Additional info:

Comment 2 spathak@redhat.com 2021-04-16 09:16:29 UTC
Created attachment 1772386 [details]
The incorrect access review check on start pipeline kebab action is fixed-1

Comment 3 spathak@redhat.com 2021-04-16 09:17:12 UTC
Created attachment 1772387 [details]
The incorrect access review check on start pipeline kebab action is fixed-2

Comment 4 spathak@redhat.com 2021-04-16 09:17:50 UTC
Verified on build version: 4.8.0-0.nightly-2021-04-16-032542
Browser version: Chrome 89

Comment 7 errata-xmlrpc 2021-07-27 23:00:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.