Bug 1950133 - MCO creates empty conditions on the kubeletconfig object
Summary: MCO creates empty conditions on the kubeletconfig object
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 4.7
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.8.0
Assignee: Qi Wang
QA Contact: MinLi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-15 20:12 UTC by Qi Wang
Modified: 2021-07-27 23:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: The outdated satus does not get removed Consequence: Same empty status appeared many times. Fix: Add clenup function to Keep a limit number of satus to make the status clean. Result: MCO keeps at most 3 different kubeletConfig status.
Clone Of:
Environment:
Last Closed: 2021-07-27 23:01:26 UTC
Target Upstream Version:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-config-operator pull 2535 0 None open Bug 1950133: Add cleanupStatus to keep 3 kubelet config conditions 2021-04-17 17:59:35 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:01:42 UTC

Description Qi Wang 2021-04-15 20:12:16 UTC 
Description of problem:

apiVersion: v1

items:

- apiVersion: machineconfiguration.openshift.io/v1

  kind: KubeletConfig

  metadata:

    annotations:

      kubectl.kubernetes.io/last-applied-configuration: |

        {"apiVersion":"machineconfiguration.openshift.io/v1","kind":"KubeletConfig","metadata":{"annotations":{"reason":"Workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1857446"},"name":"custom-config"},"spec":{"kubeletConfig":{"systemReserved":{"cpu":"1000m","memory":"3Gi"}},"machineConfigPoolSelector":{"matchLabels":{"pools.operator.machineconfiguration.openshift.io/worker":""}}}}

      reason: Workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1857446

    creationTimestamp: "2020-03-09T15:37:32Z"

    finalizers:

    - 99-worker-generated-kubelet

    generation: 4

    name: custom-config

    resourceVersion: "578706026"

    selfLink: /apis/machineconfiguration.openshift.io/v1/kubeletconfigs/custom-config

    uid: d6936cc2-e63d-48fc-a10e-099335287313

  spec:

    kubeletConfig:

      systemReserved:

        cpu: 1000m

        memory: 3Gi

    machineConfigPoolSelector:

      matchLabels:

        pools.operator.machineconfiguration.openshift.io/worker: ""

  status:

    conditions:

    - lastTransitionTime: "2020-03-09T15:37:32Z"

      message: 'Error: could not find any MachineConfigPool set for KubeletConfig'

      status: "False"

      type: Failure

    - lastTransitionTime: "2020-03-09T16:06:34Z"

      message: 'Error: could not find any MachineConfigPool set for KubeletConfig'

      status: "False"

      type: Failure

    - lastTransitionTime: "2020-03-09T17:40:28Z"

      message: Success

      status: "True"

      type: Success

    - lastTransitionTime: "2020-03-24T12:53:34Z"

      message: Success

      status: "True"

      type: Success

    - lastTransitionTime: 

Version-Release number of selected component (if applicable): OSD 4.7.4 production cluster


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:

MCO keeps at most 3 different kubeletConfig status. If the new status comes only with a new timestamp, update only the timestamp as well.

Additional info:
Comment 2 MinLi 2021-04-28 10:20:00 UTC 
verified on version: 4.8.0-0.nightly-2021-04-26-151924

Status:
  Conditions:
    Last Transition Time:  2021-04-28T09:54:47Z
    Message:               Error: could not find any MachineConfigPool set for KubeletConfig
    Status:                False
    Type:                  Failure
    Last Transition Time:  2021-04-28T10:10:03Z
    Message:               Success
    Status:                True
    Type:                  Success
Events:                    <none>
Comment 5 errata-xmlrpc 2021-07-27 23:01:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438
Note You need to log in before you can comment on or make changes to this bug.