Red Hat Bugzilla – Bug 195015
Review Request: xpa
Last modified: 2008-07-16 20:08:36 EDT
Spec URL: http://t-rex.fis.ucm.es/~spr/xpa.spec
SRPM URL: http://t-rex.fis.ucm.es/~spr/xpa-2.1.6-2.fc5.src.rpm
The XPA messaging system provides seamless communication between many kinds
of Unix programs, including X programs and Tcl/Tk programs.
It also provides an easy way for users to communicate with these
XPA-enabled programs by executing XPA client commands in the shell or by
utilizing such commands in scripts. Because XPA works both at the programming
level and the shell level, it is a powerful tool for unifying any
analysis environment: users and programmers have great flexibility
in choosing the best level or levels at which to access XPA services,
and client access can be extended or modified easily at any time.
*** Bug 195016 has been marked as a duplicate of this bug. ***
* RPM name is OK
* Source xpa-2.1.6.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of xpa-devel looks OK
* rpmlint of xpa looks OK
* File list of xpa-devel looks OK
* File list of xpa looks OK
I would recommend you just add some white space between the %package devel and
%description devel. Same again for %install and %clean, just improves the flow
and readability of your spec file.
If you make those changes, I see no reason why I can't approve this package.
I have made the changes you recommend:
Thank you. You can consider this APPROVED.
Please close this bug report with NEXTRELEASE once imported into CVS.
Package Change Request
Package Name: foobar
New Branches: EL-5
I take it you meant the Package Name to be xpa here?