Bug 1950159 - Downstream ovn-kubernetes repo should have no linter errors
Summary: Downstream ovn-kubernetes repo should have no linter errors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.8.0
Assignee: Aniket Bhat
QA Contact: Ross Brattain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-15 22:34 UTC by Aniket Bhat
Modified: 2021-07-27 23:01 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 23:01:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift ovn-kubernetes pull 495 0 None open Bug 1950159: Fix linter errors in OCP Hacks 2021-04-15 22:37:40 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:01:42 UTC

Description Aniket Bhat 2021-04-15 22:34:30 UTC
Description of problem:
openshift/ovn-kubernetes has linting errors

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Run make lint

Actual results:
linter errors out:

_prefixer: 103ns"
level=info msg="[runner] linters took 16.066594374s with stages: goanalysis_metalinter: 13.525030121s, unused: 2.540457156s"
pkg/node/OCP_HACKS.go:38:13: Error return value of `delIptRules` is not checked (errcheck)
        delIptRules(delRules)
                   ^
level=info msg="File cache stats: 1 entries of total size 2.2KiB"
level=info msg="Memory: 330 samples, avg is 577.8MB, max is 1629.5MB"
level=info msg="Execution took 33.69544197s"
make: *** [Makefile:67: lint] Error 1


Expected results:
No linting errors are observed.

Additional info:

Comment 2 Ross Brattain 2021-04-16 14:18:01 UTC
Verified on 7eb118e5ddc1fa459df822c4ce52c6458ce69614

level=info msg="[config_reader] Config search paths: [./ /app / /root]"
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[lintersdb] Active 11 linters: [deadcode errcheck gofmt gosimple govet ineffassign staticcheck structcheck typecheck unused varcheck]"
level=info msg="[loader] Go packages loading at mode 575 (name|compiled_files|deps|files|imports|types_sizes|exports_file) took 12.610692492s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 47.472574ms"
level=info msg="[linters context/goanalysis] analyzers took 1m58.672785748s with top 10 stages: buildir: 1m33.100255403s, printf: 2.597264629s, ctrlflow: 2.461987576s, fact_deprecated: 2.367919321s, inspect: 1.961078811s, gofmt: 1.446739059s, fact_purity: 1.310209323s, ineffassign: 449.503987ms, varcheck: 412.223274ms, S1030: 411.188972ms"
level=info msg="[linters context/goanalysis] analyzers took 7.174088596s with top 10 stages: buildir: 6.481950959s, U1000: 692.137637ms"
level=info msg="[runner] Issues before processing: 380, after processing: 0"
level=info msg="[runner] Processors filtering stat (out/in): exclude-rules: 0/12, cgo: 380/380, filename_unadjuster: 380/380, autogenerated_exclude: 12/20, identifier_marker: 12/12, skip_dirs: 20/20, exclude: 12/12, path_prettifier: 380/380, skip_files: 20/380"
level=info msg="[runner] processing took 1.942471ms with stages: path_prettifier: 667.959µs, skip_files: 499.198µs, identifier_marker: 309.478µs, autogenerated_exclude: 216.131µs, skip_dirs: 89.42µs, cgo: 62.799µs, exclude-rules: 61.407µs, filename_unadjuster: 29.837µs, nolint: 1.793µs, max_same_issues: 843ns, uniq_by_line: 571ns, source_code: 571ns, max_from_linter: 461ns, diff: 371ns, exclude: 320ns, severity-rules: 320ns, max_per_file_from_linter: 280ns, path_shortener: 271ns, sort_results: 250ns, path_prefixer: 191ns"
level=info msg="[runner] linters took 11.035546907s with stages: goanalysis_metalinter: 9.108091168s, unused: 1.925364976s"
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 238 samples, avg is 1002.9MB, max is 3046.9MB"
level=info msg="Execution took 23.747679738s"
lint OK!

Comment 5 errata-xmlrpc 2021-07-27 23:01:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.