Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1950539

Summary: no-op-firewall-nova-driver validator fails to read nova.conf in some cases
Product: Red Hat OpenStack Reporter: Chris Fields <cfields>
Component: openstack-tripleo-validationsAssignee: RHOS Maint <rhos-maint>
Status: CLOSED DUPLICATE QA Contact: nlevinki <nlevinki>
Severity: medium Docs Contact:
Priority: medium    
Version: 16.1 (Train)CC: dvd, gchamoul, jjoyce, jschluet, slinaber, tvignaud
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-27 12:01:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chris Fields 2021-04-16 20:05:39 UTC
Description of problem:
 
openstack tripleo validator run --validation  no-op-firewall-nova-driver

openstack tripleo validator show run  3b4bf1e5-3c4d-4b5a-b519-523d32112aea 

{
            "task": {
                "hosts": {
                    "overcloud-computeovshwoffload-0": {
                        "_ansible_no_log": false,
                        "action": "validations_read_ini",
                        "changed": false,
                        "failed": true,
                        "invocation": {
                            "module_args": {
                                "default": "nova.virt.firewall.NoopFirewallDriver",
                                "ignore_missing_file": null,
                                "key": "firewall_driver",
                                "path": "/var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf",
                                "section": "DEFAULT"
                            }
                        },
                        "msg": "The file '/var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf' is not in a valid INI format."
                    }
                },
                "name": "Read the `firewall_driver` value",
                "status": "FAILED"
            }
        },


Version-Release number of selected component (if applicable):
16.1.4

How reproducible:
This validator fails with this error on 2 out of 4 compute nodes.  The other two pass.

Comment 1 Chris Fields 2021-04-16 20:13:43 UTC
This appears to be an old validation. The nodes that pass have this:

 "msg": "There is no key 'firewall_driver' under section 'DEFAULT' in file /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf. Using default value 'nova.virt.firewall.NoopFirewallDriver'",

Default values are now commented out in nova.conf.  All of the compute nodes in this example have:

#firewall_driver=nova.virt.firewall.NoopFirewallDriver