Bug 1950934 - Unnecessary rollouts can happen due to unsorted endpoints
Summary: Unnecessary rollouts can happen due to unsorted endpoints
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Etcd
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.8.0
Assignee: Lili Cosic
QA Contact: ge liu
URL:
Whiteboard:
Depends On:
Blocks: 1951447
TreeView+ depends on / blocked
 
Reported: 2021-04-19 08:42 UTC by Lili Cosic
Modified: 2021-07-27 23:01 UTC (History)
0 users

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 23:01:42 UTC
Target Upstream Version:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-etcd-operator pull 567 0 None open Bug 1950934: pkg/etcdenvvar/etcd_env.go: Sort endpoints to prevent rollout 2021-04-19 08:44:10 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:01:58 UTC

Description Lili Cosic 2021-04-19 08:42:46 UTC 
Description of problem:

Because we do not sort the etcd gRPC endpoints every time we get the endpoints we can do multiple not-needed rollouts as the endpoints could being the same they are just returned in a different order. 

See comment https://bugzilla.redhat.com/show_bug.cgi?id=1948533#c16 for a demo of how this looks like in practice.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
https://bugzilla.redhat.com/show_bug.cgi?id=1948533#c16

Actual results:


Expected results:

If no endpoints change, no rollout should be triggered.


Additional info:
Comment 2 ge liu 2021-06-11 09:49:39 UTC 
Verified with 4.8.0-0.nightly-2021-06-09-023740, there is not so many etcd rollouts msg in log.
Comment 5 errata-xmlrpc 2021-07-27 23:01:42 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438
Note You need to log in before you can comment on or make changes to this bug.