Bug 1952321 - There is failed cloning message when cloning VM with shareable direct lun attached
Summary: There is failed cloning message when cloning VM with shareable direct lun att...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: 4.4.6.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.5.0
: 4.5.0
Assignee: Shmuel Melamud
QA Contact: Qin Yuan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-22 04:02 UTC by Qin Yuan
Modified: 2022-04-20 06:33 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-4.5.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-20 06:33:59 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.5?


Attachments (Terms of Use)
Screenshot of failed cloning message (96.19 KB, image/png)
2021-04-22 04:02 UTC, Qin Yuan
no flags Details
engine.log (324.47 KB, text/plain)
2021-04-22 04:04 UTC, Qin Yuan
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 117212 0 master MERGED core: Do not attach shareable LUN disks after cloning 2021-11-04 11:35:07 UTC

Description Qin Yuan 2021-04-22 04:02:43 UTC
Created attachment 1774278 [details]
Screenshot of failed cloning message

Description of problem:
When cloning VM with shareable direct lun attached, a failed cloning message pops up during cloning, though the cloning process is still in progress. Cloning succeeds at last, but there is no finished cloning message which should pop up when cloning is completed.


Version-Release number of selected component (if applicable):
ovirt-engine-4.4.6.5-447.gd80dda7.9.el8ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. Create a VM(used latest-rhel-guest-image-8.3-infra template)
2. Create a direct lun disk, Storage Type iSCSI, shareable checked.
3. Attach the shareable direct lun to the VM, interface VirtIO-SCSI, Activate Disk checked.
4. Clone the VM, monitor popping up messages.

Actual results:
1. A failed cloning message pops up during cloning though cloning process is still in process. The message is like "Failed Creating VM clone_vm_with_shareable_lun as a clone of VM vm_with_shareable_lun".
2. Cloning VM succeeds at last, but there is no finished cloning message which should be like "Finished Creating VM clone_vm_with_shareable_lun as a clone of VM vm_with_shareable_lun".

Expected results:
1. There shouldn't have failed cloning message when cloning is still working and succeeds at last.
2. There should have finished cloning message when cloning is completed.

Additional info:

Comment 1 Qin Yuan 2021-04-22 04:04:14 UTC
Created attachment 1774279 [details]
engine.log

Comment 2 Shmuel Melamud 2021-04-25 14:31:02 UTC
What should be a correct behaviour in this case? Currently, in the UI all LUN disks are filtered out, but CloneVmCommand allows shareable ones (while not handling them correctly). Theoretically, it is possible to support shareable LUN disks in cloning (for example, attaching them to the clone), but supporting LUN disks in the clone VM dialog in the UI will require a significant effort.

Comment 3 Arik 2021-04-25 15:02:45 UTC
how do we handle this when creating a template out of a VM with a shareable LUN? I'd expect clone VM to behave similarly

Comment 4 Arik 2021-04-26 11:26:13 UTC
Discussed offline - those sharable LUNs are filtered-out when creating a template from vm, we can do the same for clone-VM

Comment 5 Arik 2021-04-26 11:26:55 UTC
maybe it's better to assign the sharable LUN for the cloned VM but it will require massive changes

Comment 6 Qin Yuan 2022-04-18 13:57:55 UTC
Verified with:
ovirt-engine-4.5.0.2-0.7.el8ev.noarch

Steps:
The same steps as in the bug description.

Results:
1. The shareable direct lun disk isn't attached to the cloned VM.
2. There is finished cloning message when cloning completes.

Comment 7 Sandro Bonazzola 2022-04-20 06:33:59 UTC
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.