Bug 1952403 - Review Request: php-bjeavons-zxcvbn-php - Realistic password strength estimation PHP library
Summary: Review Request: php-bjeavons-zxcvbn-php - Realistic password strength estimat...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1958202
TreeView+ depends on / blocked
Reported: 2021-04-22 08:42 UTC by Remi Collet
Modified: 2021-05-20 01:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-05-20 01:10:42 UTC
Type: ---
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Remi Collet 2021-04-22 08:42:18 UTC
Spec URL: https://git.remirepo.net/cgit/rpms/php/bjeavons/php-bjeavons-zxcvbn-php.git/plain/php-bjeavons-zxcvbn-php.spec?id=0b87d8f09f10562c57b0cdcccf91ffc6df63cecd
SRPM URL: https://rpms.remirepo.net/SRPMS/php-bjeavons-zxcvbn-php-1.2.0-1.remi.src.rpm
Zxcvbn-PHP is a password strength estimator using pattern matching and minimum
entropy calculation. Zxcvbn-PHP is based on the the Javascript zxcvbn project
from Dropbox and @lowe. "zxcvbn" is bad password, just like "qwerty" and

Autoloader: /usr/share/php/ZxcvbnPhp/autoload.php

Fedora Account System Username: remi


This is a fork (dropin replacement) of php-mkopinsky-zxcvbn-php (reviewed as bug #1684437)

This can be safely used instead of php-mkopinsky-zxcvbn-php to fix PHP 8 compatibility, and will be required by upcoming roundcubemail 1.5

Comment 1 Robert-André Mauchin 🐧 2021-05-08 10:20:28 UTC
 - Thd first ch

Comment 2 Robert-André Mauchin 🐧 2021-05-08 10:23:24 UTC
 - The first changelog entry looks like it came from another package:

* Fri Mar  1 2019 Remi Collet <remi> - 4.4.2-1
- initial package, version 4.4.2

Package approuved.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 51 files have unknown
     license. Detailed output of licensecheck in
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php/ZxcvbnPhp(php-
     mkopinsky-zxcvbn-php), /usr/share/php/ZxcvbnPhp/Matchers(php-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: php-bjeavons-zxcvbn-php-1.2.0-1.fc35.noarch.rpm
php-bjeavons-zxcvbn-php.noarch: W: spelling-error %description -l en_US lowe -> Lowe, low, owe
php-bjeavons-zxcvbn-php.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
php-bjeavons-zxcvbn-php.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
php-bjeavons-zxcvbn-php.noarch: W: invalid-url URL: https://github.com/bjeavons/zxcvbn-php <urlopen error timed out>
php-bjeavons-zxcvbn-php.src: W: spelling-error %description -l en_US lowe -> Lowe, low, owe
php-bjeavons-zxcvbn-php.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader
php-bjeavons-zxcvbn-php.src: W: spelling-error %description -l en_US usr -> use, us, user
php-bjeavons-zxcvbn-php.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology
php-bjeavons-zxcvbn-php.src: W: strange-permission makesrc.sh 755
php-bjeavons-zxcvbn-php.src: W: invalid-url Source0: php-bjeavons-zxcvbn-php-1.2.0-13b505d.tgz
2 packages and 0 specfiles checked; 0 errors, 10 warnings.

Comment 4 Gwyn Ciesla 2021-05-10 16:06:02 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-bjeavons-zxcvbn-php

Comment 5 Fedora Update System 2021-05-11 05:50:21 UTC
FEDORA-2021-4aca9c19b5 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4aca9c19b5

Comment 6 Fedora Update System 2021-05-12 07:04:46 UTC
FEDORA-2021-4aca9c19b5 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-4aca9c19b5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4aca9c19b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-05-20 01:10:42 UTC
FEDORA-2021-4aca9c19b5 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.