Bug 1952594 - pinentry-qt appears minimized in Wayland sessions
Summary: pinentry-qt appears minimized in Wayland sessions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pinentry
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jakub Jelen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-22 16:00 UTC by Bernie Innocenti
Modified: 2021-09-29 01:07 UTC (History)
8 users (show)

Fixed In Version: pinentry-1.2.0-1.fc35 pinentry-1.2.0-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-29 00:16:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Bernie Innocenti 2021-04-22 16:00:24 UTC
Upstream bug: https://dev.gnupg.org/T5377

All gpg password prompts appear minimized in Plasma Wayland sessions.
Works fine in X11, and also in GNOME (but only because Qt defaults to the XCB backend on GNOME).

Steps to reproduce:

1. Log into Plasma Wayland session
2. Type: echo GETPIN | pinentry-qt

diff --git a/qt/pinentrydialog.cpp b/qt/pinentrydialog.cpp
index 1b2be36..bf9d5a9 100644
--- a/qt/pinentrydialog.cpp
+++ b/qt/pinentrydialog.cpp
@@ -232,7 +232,6 @@ PinEntryDialog::PinEntryDialog(QWidget *parent, const char *name,
        result in an animation when the pinentry is shown and
        not just popping it up.
     */
-    setWindowState(Qt::WindowMinimized);
     QTimer::singleShot(0, this, [this] () {
         raiseWindow (this);
     });

Comment 1 marcdeop 2021-08-23 13:47:36 UTC
In the last comment in the linked upstream bug, you can find the commit that fixes the problem: https://dev.gnupg.org/rP9dd46926f8d50cca059bbf5ea7aa003b9199a05f

@Boris Ranto: it would be nice if you could backport this.

Comment 2 Bernie Innocenti 2021-08-23 16:07:14 UTC
Thank you for digging up the upstream patch.

Would it be possible to apply the patch to the current Fedora package instead of waiting for the next pinentry release?

Comment 3 Jakub Jelen 2021-08-23 21:19:47 UTC
Thanks for reminder. I tried to backport this particular change, but the QT codebase changed a lot since the last release (mostly related to QT) so it would require a lot of work to make it working correctly or backport even more changes. I can have a better look tomorrow, but I would rather wait for the next upstream release, assuming it would be in sight.

Comment 4 Jakub Jelen 2021-08-26 07:03:12 UTC
The new release is here (see bug #1997584) so I will be updating rawhide and Fedora 35 to it just now. Let me know if you need this also in some older release.

Comment 5 marcdeop 2021-08-26 07:21:12 UTC
I will try to build it myself for F34 and if it solves the Wayland session problem I might ask you to upgrade it for F34 as well.

I will let you know in the next days

Comment 6 marcdeop 2021-09-13 08:53:26 UTC
(In reply to Jakub Jelen from comment #4)
> The new release is here (see bug #1997584) so I will be updating rawhide and
> Fedora 35 to it just now. Let me know if you need this also in some older
> release.

I built the new release for F34 locally and tried it out: it works!

I am using this settings in gpg-agent.conf:
pinentry-timeout 0
allow-preset-passphrase
default-cache-ttl 10800
default-cache-ttl-ssh 10800
pinentry-program /usr/bin/pinentry

@jjelen : would you be so kind to update this in F34 and F35 as well please?

Comment 7 Fedora Update System 2021-09-13 13:54:55 UTC
FEDORA-2021-300888e0c7 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-300888e0c7

Comment 8 Jakub Jelen 2021-09-13 13:57:50 UTC
Thank you for checking. The Fedora 35 build was already there, but not the update so I fixed that. Now, I am building the Fedora 34 package. You will get a links in this bugs later from the update.

Comment 9 Fedora Update System 2021-09-13 16:15:42 UTC
FEDORA-2021-300888e0c7 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-300888e0c7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-300888e0c7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-09-13 16:18:08 UTC
FEDORA-2021-a6296b55b2 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a6296b55b2

Comment 11 Fedora Update System 2021-09-14 15:02:03 UTC
FEDORA-2021-a6296b55b2 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-a6296b55b2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a6296b55b2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-09-29 00:16:34 UTC
FEDORA-2021-300888e0c7 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-09-29 01:07:14 UTC
FEDORA-2021-a6296b55b2 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.