Spec URL: https://qulogic.fedorapeople.org/reviews/R-jquerylib/R-jquerylib.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/R-jquerylib/R-jquerylib-0.1.3-1.fc33.src.rpm Description: Obtain any major version of jQuery (<https://code.jquery.com/>) and use it in any webpage generated by htmltools (e.g. shiny, htmlwidgets, and rmarkdown). Most R users don't need to use this package directly, but other R packages (e.g. shiny, rmarkdown, etc.) depend on this package to avoid bundling redundant copies of jQuery. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=66701094
- Bump to 0.1.4 Downloading: https://cran.r-project.org/src/contrib/jquerylib_0.1.3.tar.gz Download failed: 404 Client Error: Not Found for url: https://cran.r-project.org/src/contrib/jquerylib_0.1.3.tar.gz - 0.0 B Elapsed Time: 0:00:00 It seems the CRAN doesn't keep old versions, that's weird.
0.1.4 changes: %global jquery1_version 1.12.4 Provides: bundled(js-jquery1) = %{jquery1_version} %global jquery2_version 2.2.4 Provides: bundled(js-jquery2) = %{jquery2_version} %global jquery3_version 3.6.0 Provides: bundled(js-jquery3) = %{jquery3_version} JS files were moved to their own subdirectory: %{rlibdir}/%{packname}/lib/%{jquery1_version}/ %{rlibdir}/%{packname}/lib/%{jquery2_version}/ %{rlibdir}/%{packname}/lib/%{jquery3_version}/ Package approved assuming you make the aformentioned changes. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 19 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/R-jquerylib/review-R- jquerylib/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 0.1.4, packaged version is 0.1.4 ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: R-jquerylib-0.1.4-1.fc34.noarch.rpm R-jquerylib-0.1.4-1.fc34.src.rpm R-jquerylib.noarch: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry R-jquerylib.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry R-jquerylib.noarch: W: spelling-error %description -l en_US https -> HTTP R-jquerylib.noarch: W: spelling-error %description -l en_US jquery -> query, j query, equerry R-jquerylib.noarch: W: spelling-error %description -l en_US webpage -> web page, web-page, pageboy R-jquerylib.noarch: W: spelling-error %description -l en_US htmltools -> toadstools R-jquerylib.noarch: W: spelling-error %description -l en_US htmlwidgets -> fussbudgets R-jquerylib.noarch: W: spelling-error %description -l en_US rmarkdown -> markdown, r markdown, downmarket R-jquerylib.src: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry R-jquerylib.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry R-jquerylib.src: W: spelling-error %description -l en_US https -> HTTP R-jquerylib.src: W: spelling-error %description -l en_US jquery -> query, j query, equerry R-jquerylib.src: W: spelling-error %description -l en_US webpage -> web page, web-page, pageboy R-jquerylib.src: W: spelling-error %description -l en_US htmltools -> toadstools R-jquerylib.src: W: spelling-error %description -l en_US htmlwidgets -> fussbudgets R-jquerylib.src: W: spelling-error %description -l en_US rmarkdown -> markdown, r markdown, downmarket 2 packages and 0 specfiles checked; 0 errors, 16 warnings.
Thank you for the review, Robert-André https://pagure.io/releng/fedora-scm-requests/issue/33834
(In reply to Robert-André Mauchin 🐧 from comment #1) > It seems the CRAN doesn't keep old versions, that's weird. Yea, I need to update the guidelines/generator to use a more stable URL.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-jquerylib
FEDORA-2021-6b782356d5 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6b782356d5
FEDORA-2021-6b782356d5 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-6b782356d5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6b782356d5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-6b782356d5 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.