Problem Description:

Adding a hostgroup based search filter for "view_hosts" permission inside a custom role breaks the Subnets and Domains page of Satellite 6 UI. Please check the reproducer steps to understand more.



Release Version of applicable components where this behavior was noticed:

Satellite 6.7, 6.8, 6.9



How Reproducible:

100%




Steps to Reproduce:


0. Ensure we have a subnet\domain\hostgroup present and one host associated with that hostgroup. For me, the hostgroup name is "capsule/RHEL8" which has a parent-child relationship but we can use a normal hostgroup as well.

1. From Administer --> Roles, Clone the "Viewer" role by the name "Custom Viewer"

2. Edit the "Custom Viewer" role, edit the view_hosts permission to add a search filter based on hostgroup_title i.e. hostgroup_title = capsule/RHEL8

	--> Optionally created a similar filter for "view_hostgroups" permission i.e. title = capsule/RHEL8  [ But this does not cause any harm and we can exclude it as well ]

3. Create a user and have the "Custom Viewer" role associated with the user.

4. Now login back to the UI with that User and visit the following pages.
	--> Hosts --> All Hosts
		  --> Content Hosts

	--> Infrastructure --> Subnets
			   --> Domains


5. Login back as admin and remove the search filter for view_hosts in the "Custom Viewer" role.

6. Now repeat the testing at Step 4 and everything will work fine.




Actual Results:


For the subnets page, the error will be,
~~
2021-04-27T09:02:29 [D|app|e9bcea08] Backtrace for 'Action failed' error (ActionView::Template::Error): PG::AmbiguousColumn: ERROR:  column reference "subnet_id" is ambiguous
LINE 1: SELECT COUNT(DISTINCT "hosts"."id") AS count_id, subnet_id A...
                                                         ^
: SELECT COUNT(DISTINCT "hosts"."id") AS count_id, subnet_id AS subnet_id FROM "hosts" INNER JOIN "nics" ON "nics"."host_id" = "hosts"."id" AND "nics"."primary" = $1 LEFT OUTER JOIN "hostgroups" ON "hostgroups"."id" = "hosts"."hostgroup_id" AND (hostgroups.id IN (1,2,3,4,5,6,7,8,9,10)) WHERE "hosts"."type" IN ('Host::Managed') AND "hosts"."organization_id" = $2 AND "hosts"."location_id" = $3 AND ((("hostgroups"."title" = 'capsule/RHEL8') AND ("hosts"."organization_id" = '1') AND ("hosts"."location_id" = '2'))) GROUP BY subnet_id
~~

For the domains page, the error will be,
~~
2021-04-27T09:03:19 [D|app|2f414de7] Backtrace for 'Action failed' error (ActionView::Template::Error): PG::AmbiguousColumn: ERROR:  column reference "domain_id" is ambiguous
LINE 1: SELECT COUNT(DISTINCT "hosts"."id") AS count_id, domain_id A...
                                                         ^
: SELECT COUNT(DISTINCT "hosts"."id") AS count_id, domain_id AS domain_id FROM "hosts" INNER JOIN "nics" ON "nics"."host_id" = "hosts"."id" AND "nics"."primary" = $1 LEFT OUTER JOIN "hostgroups" ON "hostgroups"."id" = "hosts"."hostgroup_id" AND (hostgroups.id IN (1,2,3,4,5,6,7,8,9,10)) WHERE "hosts"."type" IN ('Host::Managed') AND "hosts"."organization_id" = $2 AND "hosts"."location_id" = $3 AND ((("hostgroups"."title" = 'capsule/RHEL8') AND ("hosts"."organization_id" = '1') AND ("hosts"."location_id" = '2'))) GROUP BY domain_id

~~



Expected Results:

No errors are displayed and the user should be able to view the subnets and domains listed.



Additional Notes:
NA