[ Resubmitting review request due to Bugzilla's earlier troubles. ] Spec URL: http://www.thecodergeek.com/downloads/fedora/obconf.spec SRPM URL: http://www.thecodergeek.com/downloads/fedora/obconf-1.6-1.src.rpm Description: ObConf is a graphical configuration editor for the Openbox window manager.
Review for this package:- MUST Items: - MUST: rpmlint shows no error - MUST: The package is named according to the Package Naming Guidelines. - MUST: The spec file name matching the base package obconf, in the format obconf.spec - MUST: This package meets the Packaging Guidelines. - MUST: The package is licensed with an open-source compatible license GPL. - MUST: The License field in the package obconf.spec file matches the actual license in COPYING file in tarball. - MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. - MUST: The package successfully compiled and build into binary rpms on i386. - MUST: This package owns all directories that it creates. - MUST: This package did not contain any duplicate files in the %files listing. - MUST: This package have a %clean section, which contains rm -rf %{buildroot}. - MUST: This package used macros. - MUST: Document files are included. - MUST: This Package did not contained any .la libtool archives - MUST: This Package include a obconf.desktop file, and that file is installed with desktop-file-install in the %install section with following warning obconf.desktop: key "Categories" string list not semicolon-terminated, fixing - MUST: No duplicate files in installation
Adding bug dependency on Openbox's review request, as this uses its -devel subpackage as a build requirement.
Above is Not an official review as I'm not yet sponsored
Review: + rpmlint shows no error. + package meets the naming guidelines. + spec-file is properly named. + package meets the packaging guidelines. + package license is open-source compatible (GPL). + license field matches the actual license. + license file included in %doc. + spec file is written in english. + spec file is legible. + source files match upstream: aaf62498b11d52dfce7a0b6060867a19 obconf-1.6.tar.gz + package successfully compiled, built and tested on i386 (rawhide). + all build dependencies are listed in BuildRequires. + package doesn't need to use %find_lang (no locales present). + package doesn't contain shared libraries. + package isn't relocatable. + package owns all directories that it creates. + no duplicate files in %files. + file permissions are properly set. + package has a %clean section. + package uses macros consistently. + package contains code, not content. + no -doc subpackage needed. + %docs don't affect application runtime. + package doesn't contain headers, static libraries or pkgconfig files (no devel package). ? GUI application; desktop file is installed with a small warning (as pointed out by Parag AN): I don't think this issue is worth patching the file (specially since it is automatically fixed) but I do think a bug should be filed upstream. + package doesn't own directories owned by other packages.
Peter: Don't forget to report a bug upstream for the .desktop semicolon issue. APPROVED.
Built for Devel. Once it's been branched to FC-4 and FC-5, I'll build for those and close this as NEXTRELEASE. Jorge: I have contacted the author about it. Thanks for your review. :)
Built successfully for FC-4 and FC-5 branches too. Thanks for your time.
Please do not remove the FE-ACCEPT blocker. Thanks.
Package Change Request ====================== Package Name: obconf Updated Fedora Owners: extras-orphan I'm orphaning openbox, obconf, and obmenu as I no longer use them and feel that my time is better spent dedicated to my other packages. Thanks.
Orphaned.
Package Change Request ====================== Package Name: obconf Updated Fedora Owners: mlichvar
Package Change Request ====================== Package Name: obconf New Branches: el6 Owners: mlichvar splinux
Git done (by process-git-requests).
obconf-2.0.3-9.20100212gitb04658.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/obconf-2.0.3-9.20100212gitb04658.el6
obconf-2.0.3-9.20100212gitb04658.el6 has been pushed to the Fedora EPEL 6 stable repository.