Bug 1954409 - Since and Up to inputs for "Host - Applied Errata" report template are not working
Summary: Since and Up to inputs for "Host - Applied Errata" report template are not wo...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Reporting
Version: 6.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Lukáš Hellebrandt
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-28 06:39 UTC by Hao Chang Yu
Modified: 2021-05-10 11:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-10 11:57:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Hao Chang Yu 2021-04-28 06:39:36 UTC
Description of problem:
"Since" and "Up to" inputs are not working. It is a Web UI issue. It seems like the date picker input fields have missing name so the values are not passed to the form. I think it is related to the react mount.

As you can see the selected date are missing and not submitted

# Form Data
authenticity_token: <token>
report_template_report[generate_at]: 2021-04-23 14:56:00
report_template_report[send_mail]: 0
report_template_report[mail_to]: root.com
report_template_report[format]: csv
report_template_report[input_values][5][value]: warning
report_template_report[input_values][3][value]: all
report_template_report[input_values][4][value]: yes
commit: Submit


Steps to Reproduce:
1. Web UI -> Monitor -> Report Template.
2. Click generate "Host - Applied Errata"
3. Select date range for Since and "Up to" then click submit

Actual results:
Data outside of the date range is reported

Expected results:
Report should only include data within the specified date range.


Additional info:
Tested on Satellite 6.9, the date inputs are passed properly. It seems that it has been fixed by the following commit.

commit c890814017481c06c9293bc09685846f7e2634f6
Author: Ondřej Ezr <oezr>
Date:   Thu Oct 8 16:01:26 2020 +0200

    Fixes #30934 - improve template invocation_form inputs
    
    Using `react_form_input` helper, that was introduced in 810504a13c
    for rendering template invocation react inputs.
    
    Hides all the input type implementations into a one helper method
    to hide the implementation differences between React and Rails implemented inputs.

Comment 1 Brad Buckingham 2021-05-10 11:57:55 UTC
As mentioned in the description, the behavior observed should be resolved in Satellite 6.9; therefore, closing the bugzilla for now.  If there are concerns, please feel free to re-open.  Thanks!


Note You need to log in before you can comment on or make changes to this bug.