Hide Forgot
+++ This bug was initially created as a clone of Bug #1906144 +++ Now that in-kernel headers have been enabled (CONFIG_IKHEADERS=m), we don't need the kernel-devel package to be installed. At this point, I haven't decided whether to remove the dependency entirely, or replace it by a weak one (Suggest: or Recommends:). The support of ikheaders should be already in current version of bcc and bpftrace.
We should keep a weak dependency on kernel-devel, since it doesn't need the expensive unpacking of kheaders step. Also, some bpftrace tools doesn't work when kernel-devel is absent, although they should. https://github.com/iovisor/bpftrace/issues/1820 It's clearly a bpftrace bug that should be fixed, but in the mean time, "Recommends: kernel-devel" should mitigate the issue.
(In reply to Jerome Marchand from comment #1) > We should keep a weak dependency on kernel-devel, since it doesn't need the > expensive unpacking of kheaders step. sorry I missed this comment and submitted the change and have koji build without kernel-devel dependency: https://koji.fedoraproject.org/koji/buildinfo?buildID=1742774 I'll check how weak dependency work and make the change or comment in here > > Also, some bpftrace tools doesn't work when kernel-devel is absent, although > they should. > https://github.com/iovisor/bpftrace/issues/1820 > It's clearly a bpftrace bug that should be fixed, but in the mean time, > "Recommends: kernel-devel" should mitigate the issue.
hum, so looks weak dependency won't install only if there would be an error, so kernel-devel will still keep installing for bcc if it's weak dependency unless you specifically say not to: dnf --setopt=install_weak_deps=False I'm not sure that this was the original idea for striping kernel-devel dependency, Stanislav?
Looks like there's the weaker variant 'Hints', aka 'Suggests:' in the spec file: https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/ Would that work?
(In reply to Stanislav Kozina from comment #4) > Looks like there's the weaker variant 'Hints', aka 'Suggests:' in the spec > file: > https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/ > Would that work? The reason I went with Recommends: is that it doesn't breaks bpftrace tools in the default install, yet allows to install bcc without kernel-devel.
Nice, so we should be good (there's a way to do what is needed). Thank you Jerome!
ok, will add Recommends: to bcc as well then, thanks
(In reply to Jiri Olsa from comment #8) > ok, will add Recommends: to bcc as well then, thanks in bcc build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1744136
FEDORA-2021-3875b6e442 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3875b6e442
FEDORA-2021-3875b6e442 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-3875b6e442` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3875b6e442 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-1ea2bfd57e has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-1ea2bfd57e
FEDORA-2021-1ea2bfd57e has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-1ea2bfd57e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1ea2bfd57e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-1ea2bfd57e has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.