Bug 1955571 - Verify if we still need to omit ifcfg and clevis dracut modules for properly working bridged network
Summary: Verify if we still need to omit ifcfg and clevis dracut modules for properly ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: vdsm
Version: 4.4.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.4.6-1
: 4.4.6
Assignee: Ales Musil
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On: 1627820
Blocks: 1959945
TreeView+ depends on / blocked
 
Reported: 2021-04-30 12:13 UTC by Marian Jankular
Modified: 2021-11-04 19:28 UTC (History)
9 users (show)

Fixed In Version: vdsm-4.40.60.7
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-03 10:25:43 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2021:2240 0 None None None 2021-06-03 10:25:57 UTC
oVirt gerrit 114764 0 master MERGED net: Remove dracut conf file 2021-05-14 08:02:56 UTC
oVirt gerrit 114811 0 ovirt-4.4.6 MERGED net: Remove dracut conf file 2021-05-17 11:48:14 UTC

Description Marian Jankular 2021-04-30 12:13:57 UTC
Description of problem:
dracut module 'clevis' will not be installed, because it's in the list to be omitted!

Version-Release number of selected component (if applicable):
redhat-virtualization-host-image-update-placeholder-4.4.5-4.el8ev.noarch
redhat-virtualization-host-image-update-4.4.5-20210330.0.el8_3.noarch


How reproducible:
everytime

Steps to Reproduce:
1.install 4.4.3 host or even older
2. upgrade to 4.4.5
3.

Actual results:
dracut module 'clevis' will not be installed, because it's in the list to be omitted!

Expected results:
clevis module wil be included

Additional info:
it looks like the issue is caused by whitespaces in /usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf

clevis is included in in initramfs with below:
omit_dracutmodules+="ifcfg clevis"

clevis is not included in in initramfs with below:
omit_dracutmodules+=" ifcfg clevis "

Comment 1 Martin Perina 2021-05-03 06:59:01 UTC
As mentioned in BZ1760262 we need to omit clevis module. But if in your setup you require clevis module, overwrite dracut configuration using /etc/dracut.conf.d directory as mentioned https://bugzilla.redhat.com/show_bug.cgi?id=1943383#c8

Comment 3 Marian Jankular 2021-05-03 11:28:38 UTC
Hello Martin, Ales

if "/usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf" does contain "omit_dracutmodules+=" ifcfg clevis "" clevis is not included in in initramfs even there is config file in /etc/dracut.conf.d/clevis.conf

if "/usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf" does contain "omit_dracutmodules+="ifcfg clevis"" clevis is included in in initramfs with same config file in /etc/dracut.conf.d/clevis.conf

Marian

Comment 4 Ales Musil 2021-05-03 11:33:14 UTC
(In reply to Marian Jankular from comment #3)
> Hello Martin, Ales
> 
> if "/usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf" does contain
> "omit_dracutmodules+=" ifcfg clevis "" clevis is not included in in
> initramfs even there is config file in /etc/dracut.conf.d/clevis.conf
> 
> if "/usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf" does contain
> "omit_dracutmodules+="ifcfg clevis"" clevis is included in in initramfs with
> same config file in /etc/dracut.conf.d/clevis.conf
> 
> Marian

The file needs to be named the same so it would be "/etc/dracut.conf.d/99-vdsm_protect_ifcfg.conf"
containing: 

1) If you want to enable only clevis (not sure if this is allowed in order to get clevis working):
omit_dracutmodules+=" clevis "

2) Enable both ifcfg and clevis: 
#Empty or some comment

Comment 5 Ales Musil 2021-05-03 11:33:53 UTC
(In reply to Ales Musil from comment #4)
> (In reply to Marian Jankular from comment #3)
> > Hello Martin, Ales
> > 
> > if "/usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf" does contain
> > "omit_dracutmodules+=" ifcfg clevis "" clevis is not included in in
> > initramfs even there is config file in /etc/dracut.conf.d/clevis.conf
> > 
> > if "/usr/lib/dracut/dracut.conf.d/99-vdsm_protect_ifcfg.conf" does contain
> > "omit_dracutmodules+="ifcfg clevis"" clevis is included in in initramfs with
> > same config file in /etc/dracut.conf.d/clevis.conf
> > 
> > Marian
> 
> The file needs to be named the same so it would be
> "/etc/dracut.conf.d/99-vdsm_protect_ifcfg.conf"
> containing: 
> 
> 1) If you want to enable only clevis (not sure if this is allowed in order
> to get clevis working):
> omit_dracutmodules+=" clevis "

Ops the other way around, my bad. 

omit_dracutmodules+=" ifcfg "


> 
> 2) Enable both ifcfg and clevis: 
> #Empty or some comment

Comment 6 Klaas Demter 2021-05-03 11:51:44 UTC
Hi,
ifcfg was explicitly disabled in https://gerrit.ovirt.org/c/vdsm/+/104420 // https://bugzilla.redhat.com/show_bug.cgi?id=1760262 so I am not sure the fix is just enabling it again :)

https://gerrit.ovirt.org/c/vdsm/+/104420
says "Enabling clevis on an ovirt host requires special handling" but I did not find how to actually enable it in any docs.

Maybe Milan Zamazal could explain what his commit means?

Comment 7 Martin Perina 2021-05-06 06:34:12 UTC
Marian, the description of the bug is somewhat confusing, what's the real issue?

I.  Clevis module is not enabled by default, because it caused issues described in BZ1760262.
    Do you want to enable it, becuase you are not affected by BZ1760262? If so, then you need
    to create /etc/dracut.conf.d/99-vdsm_protect_ifcfg.conf with below content

       omit_dracutmodules+=" ifcfg "

II. Clevis module should not be enabled by default, but you can see it enabled in your setup? If so, could you please share all customizations that you did on your hypervisor?

Comment 8 Klaas Demter 2021-05-06 07:07:17 UTC
(In reply to Martin Perina from comment #7)
> Marian, the description of the bug is somewhat confusing, what's the real
> issue?
> 
> I.  Clevis module is not enabled by default, because it caused issues
> described in BZ1760262.
>     Do you want to enable it, becuase you are not affected by BZ1760262? If
> so, then you need
>     to create /etc/dracut.conf.d/99-vdsm_protect_ifcfg.conf with below
> content
> 
>        omit_dracutmodules+=" ifcfg "
> 
> II. Clevis module should not be enabled by default, but you can see it
> enabled in your setup? If so, could you please share all customizations that
> you did on your hypervisor?

Hi,
the issue is file on my behalf. I am a RHV customer and I would like to know how to enable clevis on rhvh.
I am not sure if I am affected by BZ176026 .
The question at the base of this topic  is: "how do I enable clevis in a supported manner for rhvh".

Greetings
Klaas

Comment 9 Klaas Demter 2021-05-06 08:25:18 UTC
I looked at my installation, I would say everyone uses bridges except for the ones that use ovs which is in technology preview :)

Comment 10 Martin Perina 2021-05-07 11:37:42 UTC
In theory NetworkManager bug, which caused our issues with ifcfg and clevis modules (BZ1760262), was fixed by BZ1627820. We will try to remove omitting the module and check within our automation if there are no additional issues with bridged networking during 4.4.7 cycle.

Comment 15 Klaas Demter 2021-05-17 12:29:26 UTC
What is the suggested way of enabling network during boot? clevis no longer automatically enables dhcp based networking during boot.
Is the recommended way having a dhcp enabled setup and using rd.neednet=1 via kernel cmdline host settings in manager?
Or would you recommend to set a static configuration that matches the bridged setup that is being setup by host installation?

Comment 16 Ales Musil 2021-05-17 12:50:22 UTC
(In reply to Klaas Demter from comment #15)
> What is the suggested way of enabling network during boot? clevis no longer
> automatically enables dhcp based networking during boot.
> Is the recommended way having a dhcp enabled setup and using rd.neednet=1
> via kernel cmdline host settings in manager?
> Or would you recommend to set a static configuration that matches the
> bridged setup that is being setup by host installation?

Since RHEL 8.3 NetworkManager is enabled by default in dracut.  So you can use it,
please see https://www.redhat.com/sysadmin/network-confi-initrd for more details.

Comment 19 Michael Burman 2021-05-23 09:12:45 UTC
Verified on - vdsm-4.40.60.7-1.el8ev.x86_64 with

rhvm-4.4.6.8-0.1.el8ev.noarch
nmstate-1.0.2-6.el8_4.noarch
NetworkManager-1.30.0-7.el8.x86_64

No regression found with this fix.

Comment 20 Klaas Demter 2021-05-23 17:23:42 UTC
I tested it on ovirt-node 4.4.6.3

for the docs:

You'll need a config like this to get dracut to boot with dhcp:

# cat /etc/dracut.conf.d/clevis.conf 
kernel_cmdline="rd.neednet=1"


If you have additional encrypted volumes (localstorage for example) you will also need to enable clevis-luks-askpass.path like this:
# systemctl enable clevis-luks-askpass.path


Greetings
Klaas

Comment 30 errata-xmlrpc 2021-06-03 10:25:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Async RHV RHEL Host (ovirt-host) [ovirt-4.4.6]), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2240


Note You need to log in before you can comment on or make changes to this bug.