RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1955813 - bad client message causes closed connection and released leases
Summary: bad client message causes closed connection and released leases
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: sanlock
Version: ---
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: beta
: ---
Assignee: David Teigland
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 1965481
TreeView+ depends on / blocked
 
Reported: 2021-04-30 20:45 UTC by David Teigland
Modified: 2023-09-02 06:35 UTC (History)
8 users (show)

Fixed In Version: sanlock-3.8.4-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1965481 (view as bug list)
Environment:
Last Closed: 2021-11-09 19:44:19 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2021:4422 0 None None None 2021-11-09 19:44:26 UTC

Description David Teigland 2021-04-30 20:45:44 UTC 
Description of problem:

If the sanlock daemon receives a bad message from a client, it will respond by closing the client connection and releasing any resource leases that are held by the client.  The client may continue running, using the leases, unaware of the problem.  The sanlock daemon should just ignore bad messages and leave the client connection and leases in place.

One indication of this problem that would appear in /var/log/sanlock.log is:

"ci 2 recv 32 magic 0 vs 4282010"  (message contains wrong magic number)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 David Teigland 2021-05-04 20:01:59 UTC 
fix
https://pagure.io/sanlock/c/bb70c220b51720a46a1bdc6b824936fc7269d5d8?branch=master
Comment 2 Nir Soffer 2021-05-19 19:58:36 UTC 
Avihai, can you add QE ack for this bug?

This bug affects RHV (bug 1952345), but it is practically impossible
to reproduce with current vdsm, so no special testing is needed.

What we need is to test sanlock build in RHV automated test to make sure
there are no regressions.


Corey from cluster-qe can help with the errata process, regression testing,
etc, but we need to make sure this sanlock version does not break RHV before 
it is released.
Comment 3 Avihai 2021-05-20 08:54:15 UTC 
(In reply to Nir Soffer from comment #2)
> Avihai, can you add QE ack for this bug?
> 
> This bug affects RHV (bug 1952345), but it is practically impossible
> to reproduce with current vdsm, so no special testing is needed.
> 
> What we need is to test sanlock build in RHV automated test to make sure
> there are no regressions.
> 
> 
> Corey from cluster-qe can help with the errata process, regression testing,
> etc, but we need to make sure this sanlock version does not break RHV before 
> it is released.

I can not QE ACK for RHEL QE in a RHEL bug as I'm RHV QE.

I have no objection to adding this new fixed RHEL/sanlock in RHV side once get an official RHEL build in RHV downstream and test it in RHV regressions but can not ACK for RHEL QE.

Let's stick to the official process, RHEL QE should do QE ACKs for RHEL bugs, not RHV QE.
Comment 12 Corey Marthaler 2021-06-07 17:24:27 UTC 
Marking this verified in the latest rpms based on our regression testing. I believe RHV QA provided their testing findings in bug 1961748.

sanlock-3.8.4-1.el8    BUILT: Tue Jun  1 16:16:52 CDT 2021
sanlock-lib-3.8.4-1.el8    BUILT: Tue Jun  1 16:16:52 CDT 2021
Comment 15 errata-xmlrpc 2021-11-09 19:44:19 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sanlock bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4422
Note You need to log in before you can comment on or make changes to this bug.