Bug 1955974 - [Assisted-4.7] [UI] When host has insufficient resources, status is Pending input instead of Insufficient
Summary: [Assisted-4.7] [UI] When host has insufficient resources, status is Pending i...
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: assisted-installer
Version: 4.7
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: ---
Assignee: Jonathan Kilzi
QA Contact: Udi Kalifon
URL:
Whiteboard: AI-Team-Projects
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-01 20:55 UTC by Lital Alon
Modified: 2021-08-09 18:27 UTC (History)
8 users (show)

Fixed In Version: OCP-Metal-UI-v1.5.25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-28 13:40:12 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
example (133.45 KB, image/png)
2021-05-01 20:55 UTC, Lital Alon
no flags Details
example cont (153.41 KB, image/png)
2021-05-01 20:55 UTC, Lital Alon
no flags Details
reproduce example (152.34 KB, image/png)
2021-05-12 11:01 UTC, Lital Alon
no flags Details

Description Lital Alon 2021-05-01 20:55:04 UTC
Created attachment 1778289 [details]
example

Created attachment 1778289 [details]
example

Created attachment 1778289 [details]
example

Description of problem:
I booted node with insufficient resources for OCS and OCP.
The issue is that host status is Pending input instead of Insufficient.

See attached example.
note that issue resolved when clicking back and then next

Version-Release number of selected component (if applicable):
Staging 1.5.17


Steps to Reproduce:
1. boot node with insufficient resources
2. select Master role

Actual results:
host is Pending input

Expected results:
host is Insufficient

Comment 1 Lital Alon 2021-05-01 20:55:28 UTC
Created attachment 1778290 [details]
example cont

Comment 2 Jiri Tomasek 2021-05-05 08:18:58 UTC
The host status is retrieved from the backend, moving to the assisted-service.

Comment 3 Michael Filanov 2021-05-05 08:22:08 UTC
jdzon it is going to be fixed with https://github.com/openshift/assisted-service/pull/1555 right?

Comment 4 Michael Filanov 2021-05-05 08:22:43 UTC
@jdzon it is going to be fixed with https://github.com/openshift/assisted-service/pull/1555 right?

Comment 5 Jakub Dzon 2021-05-05 11:01:34 UTC
It is hard to tell; it doesn't look like it would fix it; https://github.com/openshift/assisted-service/pull/1555 will just introduce additional condition for Known->Insufficient host state transition.

Comment 6 Piotr Kliczewski 2021-05-05 13:59:47 UTC
Is this issue related to BZ #1954069 or is it something different?

Comment 7 Jakub Dzon 2021-05-07 15:05:17 UTC
I was able to reproduce the problem at staging and integration and I didn't see it at my environment built from the latest assisted-service. 
It's possible that it has been fixed by some change not deployed to the environments yet.

@Lital: Could you, please, check if you are able to reproduce the problem at http://10.46.41.58:6008?

Comment 8 Lital Alon 2021-05-12 08:55:50 UTC
Sure, trying

Comment 9 Lital Alon 2021-05-12 11:01:12 UTC
Yes, it reproduces (http://10.46.41.58:6008/clusters/d2baaa40-d2ee-400d-90ca-7b5bd586e397). See attached example
Steps: I have booted 3 masters, 2 workers, once they are Ready (Host Discovery stage), i marked OCS check-box. 
I guess this Pending-input is due to missing cidr set up?

Comment 10 Lital Alon 2021-05-12 11:01:47 UTC
Created attachment 1782362 [details]
reproduce example

Comment 11 Jakub Dzon 2021-05-12 14:52:52 UTC
I was able to reproduce the problem on my cluster by creating it manually. Earlier, when the cluster was configured by assisted-test-infra it didn't show similar behavior.

@Lital - the Pending Input status is caused, like you suggested, by missing machine CIDR configuration:
cluster.validation_info:

{

  "network": [
    ...
    {
      "id": "machine-cidr-defined",
      "status": "failure",
      "message": "The Machine Network CIDR is undefined; setting the Machine Network CIDR initiates the VIPs DHCP lease allocation."
    },
    ...
  ]
}

Can you, please, confirm that host in this case should be in the Insufficient state?

Comment 12 Lital Alon 2021-05-12 17:31:55 UTC
Right, when manually running it, then your unable to change network settings, because we are having insufficient hosts. When using test-infra, we update network settings using api.
So on Host Discovery page, if host is insufficient then i expect host status to be Insufficient

Comment 13 Jiri Tomasek 2021-05-31 12:48:08 UTC
The bug is caused by the UI logic [1] which identifies host status based on validations. We need to expand this to align with backend host status calculation logic.
Moving to assisted-ui.

[1] https://github.com/openshift-assisted/assisted-ui-lib/blob/d1f7733c3cc2323836eaae5a82ff0edf3a4e7747/src/components/clusterWizard/wizardTransition.ts#L223

Comment 14 Jonathan Kilzi 2021-06-28 13:40:12 UTC
This bug doesn't reproduce anymore, nor locally neither in staging.
Following the discussion with Lital, we agreed to close this bug.


Note You need to log in before you can comment on or make changes to this bug.