Bug 1956610 - manage-helm-repos manifest lacks cluster profile annotations
Summary: manage-helm-repos manifest lacks cluster profile annotations
Keywords:
Status: VERIFIED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.8.0
Assignee: Jakub Hadvig
QA Contact: Siva Reddy
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-04 04:25 UTC by W. Trevor King
Modified: 2021-05-12 00:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)
the helm repos with annotations (98.69 KB, image/png)
2021-05-12 00:41 UTC, Siva Reddy
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console-operator pull 539 0 None open Bug 1956610: Add missing cluster profile annotations to manage-helm-repos quickstart manifest 2021-05-04 07:05:27 UTC

Description W. Trevor King 2021-05-04 04:25:29 UTC
The manage-help-repos manifest [1] lacks cluster profile annotations [2]. 
 Checking fc.2:

$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.8.0-fc.2-x86_64
$ for X in manifests/*.yaml; do ENTRIES="$(yaml2json < "${X}" | jq -r '.[].metadata | select((.annotations // {}) | keys | tostring | contains("include.release.openshift.io/") | not) | .namespace + " " + .name + " " + (.annotations | tostring)')"; if test -n "${ENTRIES}"; then echo "${X}"; echo "${ENTRIES}"; fi done
...
manifests/0000_50_console-operator_manage-helm-repos.yaml
 manage-helm-repos null
...

Without profile annotations, the manifest will not be pushed into clusters, and any functionality which depends on it will be broken.  You probably want to add at least one cluster-profile annotation or drop the manifest altogether.

[1]: https://github.com/openshift/console-operator/blob/3284b03c5ad93acce12871a74395aceaa7d05abb/quickstarts/manage-helm-repos.yaml#L4
[2]: https://github.com/openshift/enhancements/blob/0e2f2474ee858350c4dec0033439036426a5663d/enhancements/update/cluster-profiles.md

Comment 2 Siva Reddy 2021-05-12 00:41:58 UTC
Created attachment 1782202 [details]
the helm repos with annotations


version:
 4.8.0-0.nightly-2021-05-11-082318

steps to verify:
 $ oc adm release extract --to manifests registry.ci.openshift.org/ocp/release:4.8.0-0.nightly-2021-05-11-082318

now the manifests/0000_50_console-operator_manage-helm-repos.yaml contains the annotations
metadata:
  name: manage-helm-repos
  annotations:
    include.release.openshift.io/ibm-cloud-managed: 'true'
    include.release.openshift.io/self-managed-high-availability: 'true'
    include.release.openshift.io/single-node-developer: 'true'

attached screen shot


Note You need to log in before you can comment on or make changes to this bug.