Bug 1956657 - [Assisted-4.7] [Staging][OCS] replace MiB unit with GiB when host ocs-requirements-satisfied fails
Summary: [Assisted-4.7] [Staging][OCS] replace MiB unit with GiB when host ocs-require...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: assisted-installer
Version: 4.7
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Rewant
QA Contact: Lital Alon
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-04 07:51 UTC by Lital Alon
Modified: 2021-06-08 09:48 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-08 09:48:16 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
example (174.14 KB, image/png)
2021-05-04 07:51 UTC, Lital Alon 		no flags Details
View All

Description Lital Alon 2021-05-04 07:51:50 UTC 
Created attachment 1779241 [details]
example

Description of problem:
When host is missing RAM, and host validation ocs-requirements-satisfied fails - message contain MiB unit instead of GiB

See attached example

Version-Release number of selected component (if applicable):
OCP-Metal-V1.0.19.3


Steps to Reproduce:
1. Boot nodes with low RAM resources, and wait for host validation failure: ocs-requirements-satisfied

Actual results:
message contain MiB

Expected results:
message should contain GiB
Comment 1 Rewant 2021-05-04 09:56:14 UTC 
Waiting for https://github.com/openshift/assisted-service/pull/1601 to be merged
Comment 2 Rewant 2021-05-10 11:06:30 UTC 
Fix PR: https://github.com/openshift/assisted-service/pull/1667
Comment 3 Lital Alon 2021-06-01 09:33:05 UTC 
Its now show Gib units as expected. 
However, although it wasn't originally asked in the bug, its better to display decimal number than int
Comment 4 Rewant 2021-06-08 09:48:16 UTC 
ValidateHost no longer Validates RAM/CPU requirements it is being handled by the GetHostRequirements
Note You need to log in before you can comment on or make changes to this bug.