Bug 1957240 - Adding ISO domain deprecation message is misleading
Summary: Adding ISO domain deprecation message is misleading
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.4.6.6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.4.7
: 4.4.7.1
Assignee: Bella Khizgiyaev
QA Contact: sshmulev
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-05 12:49 UTC by sshmulev
Modified: 2021-07-06 07:28 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.4.7.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-06 07:28:29 UTC
oVirt Team: Storage
Embargoed:
sbonazzo: ovirt-4.4?
pm-rhel: planning_ack?
pm-rhel: devel_ack+
pm-rhel: testing_ack+


Attachments (Terms of Use)
screenshot (86.79 KB, image/png)
2021-05-05 12:49 UTC, sshmulev
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 114887 0 master MERGED webadmin: modify deprecated ISO domain message 2021-05-25 10:36:50 UTC

Description sshmulev 2021-05-05 12:49:14 UTC
Created attachment 1779799 [details]
screenshot

A message pops when the ISO domain is being created:"Please note that ISO domain is no longer supported, consider using data domain instead"
After the message is displayed, when choosing "ok"- the ISO domain is created and then added to the domains table and turns active.
The message is misleading because it is expected that after choosing "ok" the ISO domain will not be created.

Version 4.4.6.6-0.10.el8ev

Steps:
1. from the domain window -> new domain -> content type ISO
2. after pressing OK a confirmation window should pop up with the info message.
3. should work for all supported storage types under ISO.


Actual results:
"Please note that ISO domain is no longer supported, consider using data domain instead"
The ISO domain is added to the storage domains and turning active.

Expected results:
Need to change the message content to be more accurate to what happens actually (since The domain supposed to be added to SDs).

Comment 1 Eyal Shenitzky 2021-05-05 12:58:23 UTC
Honestly, I think that the message is fine.

This is a confirmation window, it alarms the user that ISO domain is deprecated.
If the user ignores that message, he presses 'OK' and the domain created.

Can you please explain what is misleading here?

Comment 2 sshmulev 2021-05-06 08:01:26 UTC
The message is misleading because it is expected that after choosing "ok" according to the message, the ISO domain should not be created - but in actual it is created.
It sounds from the message that it won't work but it does.
Maybe need to add something like "Are you sure you want to continue?" (Since The depreciation is not done yet)

Comment 3 Sandro Bonazzola 2021-05-31 09:27:53 UTC
All referenced patches are merged, can you please check this bug status?

Comment 4 sshmulev 2021-06-06 07:37:34 UTC
Verified.

Versions:
ovirt-engine-4.4.7.1-468.ge80656f.3.el8ev.noarch
vdsm-4.40.70.1-1.el8ev.x86_64

Steps:
1. from the domain window -> new domain -> content type ISO
2. After pressing OK, a confirmation window should pop up with the info message.
3. Should work for all supported storage types under ISO.
4. Try first to cancel and see that nothing happens.
5. Try to press ok and make sure the storage domain becomes active and attached to DC.

Al steps passed.

Comment 5 Sandro Bonazzola 2021-07-06 07:28:29 UTC
This bugzilla is included in oVirt 4.4.7 release, published on July 6th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.