Spec URL: https://download.copr.fedorainfracloud.org/results/sgallagh/lorax-templates-rhel/fedora-rawhide-x86_64/02168758-lorax-templates-rhel/lorax-templates-rhel.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sgallagh/lorax-templates-rhel/fedora-rawhide-x86_64/02168758-lorax-templates-rhel/lorax-templates-rhel-9.0-14.fc35.src.rpm Fedora Account System Username: sgallagh Description: RHEL-specific Lorax templates for creating the boot.iso and live isos are placed in %{templatedir}
Review template: https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhel/fedora-rawhide-x86_64/02168758-lorax-templates-rhel/fedora-review/review.txt
Taking this review.
So there are a couple of issues: > URL: https://github.com/weldr/lorax > [..] > Source0: lorax-templates-rhel-9.0-14.tar.gz The URL doesn't point to the actual project, and the Source0 does not point to a proper upstream SourceURL. We generally want to avoid packages in Fedora like this, since the upstream relationship is nonexistent. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > rm -rf $RPM_BUILD_ROOT This can be removed, as RPM does this automatically.
(In reply to Neal Gompa from comment #3) > So there are a couple of issues: > > > URL: https://github.com/weldr/lorax > > [..] > > Source0: lorax-templates-rhel-9.0-14.tar.gz > > The URL doesn't point to the actual project, and the Source0 does not point > to a proper upstream SourceURL. > This package provides only data files to support the lorax project. The URL is correct. This dist-git repository will be its own upstream. The tarball is generated by a Makefile included with the sources. I have added a comment to this effect into the specfile to avoid confusion in the future. > > rm -rf $RPM_BUILD_ROOT > > This can be removed, as RPM does this automatically. Done. I also updated the version to 10.0 since ELN is currently tracking towards that release. Spec URL: https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhel/fedora-eln-x86_64/02175846-lorax-templates-rhel/lorax-templates-rhel.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhel/fedora-eln-x86_64/02175846-lorax-templates-rhel/lorax-templates-rhel-10.0-1.el110.src.rpm
I strongly suggest that you make it so that the tarball isn't needed in the future. But for now, it looks good to me. PACKAGE APPROVED.
(In reply to Neal Gompa from comment #5) > I strongly suggest that you make it so that the tarball isn't needed in the > future. But for now, it looks good to me. > > PACKAGE APPROVED. We discussed this on IRC. The tarball is actually generated from files in the dist-git repository. It's done with a tarball for simplicity, since having 90 files listed in Sources would be unwieldy.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lorax-templates-rhel
Package is available in repositories, closing.