Bug 1958673 - Umlaute are not shown in okular notes
Summary: Umlaute are not shown in okular notes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: poppler
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Marek Kašík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1954140 (view as bug list)
Depends On:
Blocks: 1954140
TreeView+ depends on / blocked
 
Reported: 2021-05-09 17:36 UTC by oli
Modified: 2021-06-09 07:27 UTC (History)
15 users (show)

Fixed In Version: poppler-21.01.0-7.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-05 01:04:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
File shows what was annotated and what is actually rendered. (57.41 KB, application/pdf)
2021-05-22 22:25 UTC, Morvan
no flags Details
Example of accentuation (Portuguese at al) (59.48 KB, image/jpeg)
2021-06-05 01:44 UTC, Morvan
no flags Details
No accent on uppercase letter on first line (66.43 KB, image/jpeg)
2021-06-05 07:30 UTC, Éric Brunet
no flags Details
First line does not render correctly accentuated letters, when UpperCase one and it is their first line (54.79 KB, image/jpeg)
2021-06-05 12:51 UTC, Morvan
no flags Details

Description oli 2021-05-09 17:36:34 UTC
Description of problem:
I have a .pdf from my university and i create some notes for myself.
Unfortunately, when i use ä or ö those are not shown in the PDF.

Version-Release number of selected component (if applicable):
okular-libs-20.12.2-2.fc34.x86_64
okular-part-20.12.2-2.fc34.x86_64
okular-20.12.2-2.fc34.x86_64


How reproducible:
always

Steps to Reproduce:
1. open any pdf in okular
2. select "text comment" 
3. create a textfield anywhere in the pdf
4. write some umlaute like ä

Actual results:
the umlaute are shown inside the yellow editor but not in the pdf

Expected results:
that umlaute are shown in the pdf text note

Additional info:

Comment 1 Morvan 2021-05-22 22:05:57 UTC
Same problem, for me. Just not Okular, but Poppler related and seems a regression.
I work with Okular everyday and, such as autor, Oli, I need make specific annotations (say I need remember to a retired its login, email, even his [smart]phone, etc. I get a pattern PDF and put some notes in it). Expected; text rendered with all diacriticals. Actual: just plain ASCII is displayed.
I made a graphical example.

Comment 2 Morvan 2021-05-22 22:25:32 UTC
Created attachment 1785931 [details]
File shows what was annotated and what is actually rendered.

PDF contains example of the bug

Comment 3 Morvan 2021-05-22 22:30:10 UTC
(In reply to Morvan from comment #1)
At Fedora 34:
poppler-21.01.0-6.fc34.x86_64
okular-20.12.2-2.fc34.x86_64

Comment 5 Marek Kašík 2021-06-01 12:48:57 UTC
This works for me with upstream poppler. I'm going to find the commit which fixes this.

Comment 6 Marek Kašík 2021-06-01 13:51:28 UTC
This is a regression which has been fixed in current upstream poppler. Fortunately, this one is fixable in stable branch. I'm going to push it where necessary.

See https://gitlab.freedesktop.org/poppler/poppler/-/issues/1070 for additional details.

Comment 7 Fedora Update System 2021-06-01 15:18:44 UTC
FEDORA-2021-e583ac67fd has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e583ac67fd

Comment 8 Fedora Update System 2021-06-02 01:41:14 UTC
FEDORA-2021-e583ac67fd has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e583ac67fd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e583ac67fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Morvan 2021-06-02 02:02:02 UTC
(In reply to Fedora Update System from comment #8)
> FEDORA-2021-e583ac67fd has been pushed to the Fedora 34 testing repository.
> Soon you'll be able to install the update with the following command:
> `sudo dnf upgrade --enablerepo=updates-testing
> --advisory=FEDORA-2021-e583ac67fd`
> You can provide feedback for this update here:
> https://bodhi.fedoraproject.org/updates/FEDORA-2021-e583ac67fd
> 
> See also https://fedoraproject.org/wiki/QA:Updates_Testing for more
> information on how to test updates.

I made Marek Kašík proposed update (just poppler, --nodeps to rpm) and it works like a charm. Thanks for all for fast response.

Comment 10 Than Ngo 2021-06-04 10:07:33 UTC
*** Bug 1954140 has been marked as a duplicate of this bug. ***

Comment 11 Éric Brunet 2021-06-04 12:35:56 UTC
Thanks for the update!

This update fixes the problem for me, at least mostly. In okular's annotations:
lowercase accents (àéêë...) work
uppercase accents (ÀÉÊË...) work, except on the first displayed line of the annotation.

It might be a different issue, and I don't know whether it is a regression or not. It might be a problem of a miscomputed bounding box, with the accents being left out and clipped.

Should I open a different bug? Against poppler, or okular?

Comment 12 Fedora Update System 2021-06-05 01:04:52 UTC
FEDORA-2021-e583ac67fd has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Morvan 2021-06-05 01:40:36 UTC
(In reply to Éric Brunet from comment #11)
...
> This update fixes the problem for me, at least mostly. In okular's
> annotations:
> lowercase accents (àéêë...) work
> uppercase accents (ÀÉÊË...) work, except on the first displayed line of the
> annotation.
... 
> Should I open a different bug? Against poppler, or okular?

For me, it is ok,Éric. See example (JPG), please.

Comment 14 Morvan 2021-06-05 01:44:19 UTC
Created attachment 1789034 [details]
Example of accentuation (Portuguese at al)

Example of accentuation for Portuguese and or any Latin encode.

Comment 15 Éric Brunet 2021-06-05 07:30:25 UTC
Created attachment 1789052 [details]
No accent on uppercase letter on first line

Thanks for the screenshot. I have an issue with accented ***uppercase*** letters on the first line, and the only accented letter in the first line of your example is lowercase.

I am attaching a snapshot of what okular gives me.

Comment 16 Morvan 2021-06-05 12:51:37 UTC
Created attachment 1789069 [details]
First line does not render correctly accentuated letters, when UpperCase one and it is their first line

As pointed by Éric, when over first line, diacritical marks can not be correctly rendered.

Comment 17 Morvan 2021-06-05 12:56:30 UTC
... 
> Thanks for the screenshot. I have an issue with accented ***uppercase***
> letters on the first line, and the only accented letter in the first line of
> your example is lowercase.
...
You are right. I tested it and really when occurs to be first line and uppercase,it is not correctly rendered. I really do not know if it is an antique matter or introduced after corrections. I let with maintainers task to decide over a new bug or not.

Comment 18 Marek Kašík 2021-06-08 16:17:40 UTC
Hi, the issue you are describing is a different one. It is an issue in poppler when drawing upper case glyphs which have diacritical mark (those which come from an external font). The position of the first line is too low. This is probably caused by the way the annotation font is handled here. It uses font size as height of the glyphs so it probably does not count with the diacritical mark.

I am looking for the piece of code where I could influence this but it is possible that this would need a fundamental change in how fonts are treated (the not embedded ones).

I had a quick look at upstream issues and have not found a similar one.

Comment 19 Marek Kašík 2021-06-08 16:18:59 UTC
... The position of the first line is too high. ...

Comment 20 Éric Brunet 2021-06-09 07:27:17 UTC
Hi!

Thanks for the comment. I have opened a new issue, bug 1969736, to keep track of this.


Note You need to log in before you can comment on or make changes to this bug.