Bug 1959007 - python-libcst fails to build with Python 3.10: AST changes make tests fail [built without tests]
Summary: python-libcst fails to build with Python 3.10: AST changes make tests fail [b...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-libcst
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10 1969002
TreeView+ depends on / blocked
 
Reported: 2021-05-10 14:50 UTC by Miro Hrončok
Modified: 2021-11-15 05:45 UTC (History)
3 users (show)

Fixed In Version: python-libcst-0.3.21-1.fc34 python-libcst-0.3.21-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-15 05:21:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2021-05-10 14:50:47 UTC
python-libcst fails to build with Python 3.10.0b1.

FAILED libcst/_nodes/tests/test_cst_node.py::CSTNodeTest::test_repr - Asserti...
FAILED libcst/tests/test_tool.py::PrettyPrintNodesTest::test_full_tree - Asse...
FAILED libcst/tests/test_tool.py::PrettyPrintNodesTest::test_hidden_syntax - ...
FAILED libcst/tests/test_tool.py::PrettyPrintNodesTest::test_hidden_whitespace
FAILED libcst/tests/test_tool.py::PrettyPrintNodesTest::test_hidden_whitespace_and_syntax

The failures seem like differences in AST.

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02174996-python-libcst/

For all our attempts to build python-libcst with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-libcst/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2021-06-04 20:12:54 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 2 Miro Hrončok 2021-06-07 22:57:52 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 3 Davide Cavalca 2021-06-08 21:24:03 UTC
Put up https://src.fedoraproject.org/rpms/python-libcst/pull-request/2 to see if the new version works any better

Comment 4 Ben Cotton 2021-08-10 13:01:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 5 Fedora Update System 2021-11-07 05:07:32 UTC
FEDORA-2021-e905bc99eb has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e905bc99eb

Comment 6 Fedora Update System 2021-11-07 05:14:28 UTC
FEDORA-2021-8114e33f99 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8114e33f99

Comment 7 Fedora Update System 2021-11-08 01:51:55 UTC
FEDORA-2021-e905bc99eb has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e905bc99eb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e905bc99eb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-11-08 01:52:11 UTC
FEDORA-2021-8114e33f99 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8114e33f99`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8114e33f99

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-11-15 05:21:36 UTC
FEDORA-2021-8114e33f99 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2021-11-15 05:45:56 UTC
FEDORA-2021-e905bc99eb has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.