Bug 1959055

We correctly run:

  cryptsetup -d /tmp/cryptabc37c.key open /dev/sda2 cryptsda2 --type bitlk

which fails with:

  BITLK devices with type 'encrypt-on-write' cannot be activated. (0)

This seems to be a problem with support for this guest by cryptsetup.
I think when you created the guest or set up BitLocker in the guest,
you may have selected the "Encrypt on Write" option.  (There is another
option to encrypt the whole disk).  Apparently cryptsetup or the kernel
does not support Encrypt on Write.  This may not be something that we
are able to solve.

https://gitlab.com/cryptsetup/cryptsetup/-/blob/c40be6cc7a830f95cbea336693bbcabd101df135/lib/bitlk/bitlk.c#L1209

The error is different now. 

# rpm -q virt-v2v libguestfs kernel
virt-v2v-1.45.2-1.el9.x86_64
libguestfs-1.45.6-9.el9.x86_64
kernel-5.13.0-1.el9.x86_64

#
[   0.0] Opening the source -i libvirt -ic vpx://root.x.x/data/x.x.x.x/?no_verify=1 esx7.0-win2019-ntfs-3g-bitblocker
[   3.7] Creating an overlay to protect the source from being modified
[   5.8] Opening the overlay
Enter key or passphrase ("/dev/sda2"): 
[  61.1] Inspecting the overlay
[ 439.4] Checking for sufficient free disk space in the guest
[ 439.4] Converting Windows Server 2019 Standard to run on KVM
virt-v2v: warning: there is no QXL driver for this version of Windows (10.0 
x86_64).  virt-v2v looks for this driver in 
/usr/share/virtio-win/virtio-win.iso

The guest will be configured to use a basic VGA display driver.
virt-v2v: error: libguestfs error: blockdev_getsize64: 
blockdev_getsize64_stub: /dev/mapper/cryptsda: No such file or directory

If reporting bugs, run virt-v2v with debugging enabled and include the 
complete output:

  virt-v2v -v -x [...]

(In reply to Xiaodai Wang from comment #3)
> The error is different now. 
> 
But are you using encrypt on write as indicated by comment #1?

If this is another bug, we should open a different bz

>

I think yes, because the guest is same.

(In reply to Xiaodai Wang from comment #6)
> I think yes, because the guest is same.

I'm closing this one as we can't support encrypt on write right now. If you have issues with converting a windows guest that was configured with whole-disk encryption, please open a different BZ.

 -Klaus

Comment 3 is a different bug - some problem with inspection.  Can you
open a new bug about that with the log from comment 4.

As for this bug, encrypt-on-write is not supported by cryptsetup and/or
the kernel.  The bug is valid but we cannot fix it, so adjusting the
status.

(In reply to Richard W.M. Jones from comment #9)
> Comment 3 is a different bug - some problem with inspection.  Can you
> open a new bug about that with the log from comment 4.
> 
> As for this bug, encrypt-on-write is not supported by cryptsetup and/or
> the kernel.  The bug is valid but we cannot fix it, so adjusting the
> status.

The guest used in comment1 and comment3 is same one, the error info is changed with the upgrade of virt-v2v/libguestfs version , I think we can change the bug description and component if you want to fix the error of comment3， thanks

I looked at both logs now and what's strange here is that
in the second log (comment 4) the cryptsetup command is
successful.  If it's really the same guest that would indicate
that encrypt-on-write has become supported in the kernel.
However I also checked the kernel and cryptsetup code and
nothing obviously has changed that could make this supported.

Anyway despite that, comment 3 / comment 4 does indicate a
completely different bug, so it needs a new bug number.

If we try to reuse the same bug for a different issue then
we end up losing all the original information about
encrypt-on-write.