Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1959445

Summary:	E2E tests leave local PVs behind
Product:	OpenShift Container Platform	Reporter:	Jan Safranek <jsafrane>
Component:	Storage	Assignee:	Tomas Smetana <tsmetana>
Storage sub component:	Storage	QA Contact:	Rohit Patil <ropatil>
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs, piqin, ropatil
Version:	4.8
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1969426 2002660 (view as bug list)		Environment:
Last Closed:	2021-09-09 12:57:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1952931, 1969426, 2002660, 2002665

Description Jan Safranek 2021-05-11 14:16:21 UTC

Description of problem:

After CSI migration tests finish, there are some leftover PVs in the cluster.

See https://testgrid.k8s.io/redhat-openshift-ocp-release-4.8-broken#periodic-ci-openshift-release-master-nightly-4.8-e2e-aws-csi-migration

From https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.8-e2e-aws-csi-migration/1391694972192821248:

+persistentvolume/local-pv9zb5m
+persistentvolume/local-pvpt5mt
persistentvolume/pvc-e3b4f183-4c75-4d9c-9385-18b088abcd1b
persistentvolume/pvc-f15067db-d6d5-4c94-9079-d28bc37ed925
+persistentvolume/pvc-f9c9f7d0-51b8-402a-80f8-4bbc1982a6d0
ERROR: Timed out waiting for PVs to get deleted.
ERROR: It seems that some test left some PVs behind.
ERROR: Check the diff between expected and existing PVs above.

So we have three PVs left behind and not deleted. Two of them are local, the third one looks like mock:

name: pvc-f9c9f7d0-51b8-402a-80f8-4bbc1982a6d0
...
csi:
driver: csi-mock-e2e-csi-mock-volumes-7168
...
phase: Released

(from https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.8-e2e-aws-csi-migration/1391694972192821248/artifacts/e2e-aws-csi-migration/storage-pv-check/artifacts/pvs-29.yaml)

How reproducible:
Always

Steps to Reproduce:
Run openshift conformance/parallel tests against OCP on AWS.

CSI migration is enabled in the linked CI jobs, IMO it should not affect local or mock volumes, but one never knows. We do not check for leftover PVs in other e2e jobs, so we don't know if there are some on GCE or without migration.

Actual results:
At least two local PVs left behind (this is 100% reproducible)

Sometimes, a CSI mock PV left behind (started appearing in https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.8-e2e-aws-csi-migration/1391332579759624192 ???)

Expected results:
No PVs left behind

Comment 1 Tomas Smetana 2021-05-13 13:14:47 UTC

Just a minor update on this: both the local volumes have "persistentVolumeReclaimPolicy: Retain". The mock volume is being used by a snapshot test. Logs from the snapshot controller:

createSnapshotContent: Creating content for snapshot e2e-csi-mock-volumes-7168/snapshot-j2zf8 through the plugin ...
Added protection finalizer to persistent volume claim e2e-csi-mock-volumes-7168/snapshot-test-pvc
Keeping PVC e2e-csi-mock-volumes-7168/snapshot-test-pvc, it is used by snapshot e2e-csi-mock-volumes-7168/snapshot-j2zf8
...
checkandRemovePVCFinalizer[snapshot-j2zf8]: Remove Finalizer for PVC snapshot-test-pvc as it is not used by snapshots in creation
...
cannot get claim from snapshot [snapshot-9jkcn]: [failed to retrieve PVC snapshot-test-pvc from the lister: "persistentvolumeclaim \"snapshot-test-pvc\" not found"] Claim may be deleted already

I don't know yet how is the snapshot creation and PV protection interacting with the CSI migration.

Comment 2 Tomas Smetana 2021-05-25 13:49:19 UTC

The local volumes come from these two tests: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/persistent_volumes-local.go#L375-L381. They look to create two local volumes in the ginkgo.BeforeEach that get cleaned up in ginkgo.AfterEach, but then the test funciton itself (https://github.com/kubernetes/kubernetes/blob/7229ea343dd649f9a6c20fa1fd6b13e602f3f082/test/e2e/storage/persistent_volumes-local.go#L719) creates also a volume and that one seems to be never removed.

Comment 3 Tomas Smetana 2021-05-25 14:49:06 UTC

Local volumes leak upstream fix:
https://github.com/kubernetes/kubernetes/pull/102292

Comment 4 Fabio Bertinatto 2021-06-02 07:10:02 UTC

*** Bug 1948474 has been marked as a duplicate of this bug. ***

Comment 5 Tomas Smetana 2021-09-09 12:57:11 UTC

This got merged to 4.9 with rebase to 1.22.