Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1959649

Summary: network role: Support ethtool -G|--set-ring options
Product: Red Hat Enterprise Linux 8 Reporter: Wen Liang <wenliang>
Component: rhel-system-rolesAssignee: Rich Megginson <rmeggins>
Status: CLOSED ERRATA QA Contact: Zhiqian Guan <zhguan>
Severity: unspecified Docs Contact: Laura Onduskova <londusko>
Priority: unspecified    
Version: 8.5CC: djez, elpereir, nhosoi, spetrosi, till, vferschm, zhguan
Target Milestone: betaKeywords: Triaged
Target Release: 8.5Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: role:network
Fixed In Version: rhel-system-roles-1.2.0-1.el8 Doc Type: Enhancement
Doc Text:
.`ethtool` now supports reducing the packet loss rate and latency Tx or Rx buffers are memory spaces allocated by a network adapter to handle traffic bursts. Properly managing the size of these buffers is critical to reduce the packet loss rate and achieve acceptable network latency. The `ethtool` utility now reduces the packet loss rate or latency by configuring the `ring` option of the specified network device. The list of supported `ring` parameters is: * `rx` - Changes the number of ring entries for the Rx ring. * `rx-jumbo` - Changes the number of ring entries for the Rx Jumbo ring. * `rx-mini` - Changes the number of ring entries for the Rx Mini ring. * `tx` - Changes the number of ring entries for the Tx ring.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 17:45:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1957876    
Bug Blocks:    
Attachments:
Description Flags
full-log-of-test none

Description Wen Liang 2021-05-12 02:36:48 UTC 
Description of problem:
I can specify `ethtool -G|--set-ring` options for profiles.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Wen Liang 2021-05-13 22:19:37 UTC 
The automated test playbooks are:

tests/tests_ethtool_ring_nm.yml 
tests/tests_ethtool_ring_initscripts.yml
Comment 3 Rich Megginson 2021-05-17 23:11:54 UTC 
@wenliang would you please fill in the Doc Text field?
Comment 4 Wen Liang 2021-05-18 17:23:22 UTC 
(In reply to Rich Megginson from comment #3)
> @wenliang would you please fill in the Doc Text field?

Rich, I do not have the permission to fill it, I discussed with @elpereir about the proper `Doc Text` for this new feature, she will fill it when she had time.
Comment 5 Rich Megginson 2021-05-18 17:26:08 UTC 
(In reply to Wen Liang from comment #4)
> (In reply to Rich Megginson from comment #3)
> > @wenliang would you please fill in the Doc Text field?
> 
> Rich, I do not have the permission to fill it, I discussed with
> @elpereir about the proper `Doc Text` for this new feature, she
> will fill it when she had time.

Can you just add it as a comment then, and I or someone else will fill in the Doc Text field?  I would like to track it in the bz.
Comment 6 Wen Liang 2021-05-18 20:26:54 UTC 
Feature:
Support configuring ethtool `ring` options and setting the `rx`/`tx` `ring` parameters of the specified network device. The list of supported `ring` parameters is:
 
    - `rx` - Changes the number of ring entries for the Rx ring.
    - `rx-jumbo` - Changes the number of ring entries for the Rx Jumbo ring.
    - `rx-mini` - Changes the number of ring entries for the Rx Mini ring.
    - `tx` - Changes the number of ring entries for the Tx ring.
 
 
Reason:
Tx/Rx buffers are memory spaces allocated by a network adapter to handle traffic bursts. Buffering takes place when the traffic exceeds physical capacity of network adapter.
Properly managing the size of these buffers is critical to reduce the packet loss rate and achieve good network latency.
 
 
 
Result:
Reduce the packet loss rate or latency through tuning `ring` parameters.
Comment 8 Zhiqian Guan 2021-05-26 11:10:55 UTC 
:: [ 06:59:16 ] :: [   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2 against RHEL_8_3_0_GA (Expected 0, got 0)
:: [ 07:03:23 ] :: [   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2 against RHEL_8_3_0_GA (Expected 0, got 0)

[root@netqe2 Upstream-testsuite]# rpm -q rhel-system-roles
rhel-system-roles-1.2.0-1.el8.noarch
[root@netqe2 Upstream-testsuite]# uname -r
4.18.0-308.el8.x86_64
[root@netqe2 Upstream-testsuite]#
Comment 9 Zhiqian Guan 2021-05-26 11:11:37 UTC 
Pre verified with the test playbook running on 8.3 against ansible2.9
Comment 14 Zhiqian Guan 2021-06-10 10:06:16 UTC 
Created attachment 1789791 [details]
full-log-of-test

this is a full log of test
Comment 15 Zhiqian Guan 2021-06-10 10:09:39 UTC 
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.8 against RHEL_6_10_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.8 against RHEL_6_10_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.9 against RHEL_6_10_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.9 against RHEL_6_10_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.8 against RHEL_7_9_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.8 against RHEL_7_9_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.9 against RHEL_7_9_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.9 against RHEL_7_9_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.8 against RHEL_8_3_0_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.8 against RHEL_8_3_0_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.9 against RHEL_8_3_0_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.9 against RHEL_8_3_0_GA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.8 against RHEL_8_4_0_BETA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.8 against RHEL_8_4_0_BETA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.9 against RHEL_8_4_0_BETA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.9 against RHEL_8_4_0_BETA (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.8 against RHEL_8_5_0_TESTING (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.8 against RHEL_8_5_0_TESTING (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_nm.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_nm.yml) with ANSIBLE-2.9 against RHEL_8_5_0_TESTING (Expected 0, got 0)
[   PASS   ] :: Test network/tests_ethtool_ring_initscripts.yml (roles/rhel-system-roles.network/tests/tests_ethtool_ring_initscripts.yml) with ANSIBLE-2.9 against RHEL_8_5_0_TESTING (Expected 0, got 0)

[root@netqe3 Upstream-testsuite]# uname -r
4.18.0-310.el8.x86_64
[root@netqe3 Upstream-testsuite]#
[root@netqe3 Upstream-testsuite]# rpm -q rhel-system-roles
rhel-system-roles-1.2.0-1.el8.noarch
[root@netqe3 Upstream-testsuite]#

Full log has beed uploaded to the attachments
Comment 16 Zhiqian Guan 2021-06-10 10:11:11 UTC 
Based on the Comment15, set this to VERIFIED.
Comment 19 errata-xmlrpc 2021-11-09 17:45:29 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4159