Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1959731

Summary:	Restarted cold migration plan shows already migrated VMs with "Transfer disks" status
Product:	Migration Toolkit for Virtualization	Reporter:	David Vaanunu <dvaanunu>
Component:	General	Assignee:	Fabien Dupont <fdupont>
Status:	CLOSED ERRATA	QA Contact:	Nandini Chandra <nachandr>
Severity:	high	Docs Contact:	Avital Pinnick <apinnick>
Priority:	high
Version:	2.0.0	CC:	apinnick, fdupont, istein, nachandr, pvauter, slucidi
Target Milestone:	---
Target Release:	2.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-10 17:12:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Vaanunu 2021-05-12 08:46:52 UTC

Description of problem:

While restarting a cold plan with a few VMs were already completed to migrate, the plan runs and migrated the left VMs. When finished to migrate the new VMs, the VMs which migrated during the first cycle are with a status of"Transfer disks"

Version-Release number of selected component (if applicable):
MTV_2.0.0-12
CNV_2.6.2-25


How reproducible:


Steps to Reproduce:
1. Create  a cold migration plan with 10-20 VMs
2. Run the plan, after a few VMs completed to migrate - Cancel the plan (from UI)
3. Verify all importer & v2v pods are deleted 
4. Restart the plan


Actual results:

Migrated VMs from the first cycle have status "Transfer disks" and the plan is still running 


Expected results:
Not migrated VMs which already completed successfully

Additional info:

root@f01-h14-000-r640:~/GIT/mtv-autodeploy$ oc get plan -nopenshift-mtv
NAME                READY   EXECUTING   SUCCEEDED   FAILED   AGE
15vm-after-reboot   True                                     21h
20vm-after-reboot   True    True                             21h
20vms-50gb                              True                 24h
bugverify1956467                        True                 23h
root@f01-h14-000-r640:~/GIT/mtv-autodeploy$ oc get migration -nopenshift-mtv
NAME                              READY   RUNNING   SUCCEEDED   FAILED   AGE
15vm-after-reboot-1620730438004   True                                   21h
15vm-after-reboot-1620731263799   True                                   21h
20vm-after-reboot-1620731877676   True              True                 21h
20vm-after-reboot-1620738680835   True    True                           19h
20vms-50gb-1620719313611          True              True                 24h
bugverify1956467-1620725702170    True              True                 23h


Link to screenshots:

https://drive.google.com/drive/folders/1HdPnkZCsHYKxZdbn3jG9ez_WWaHtMcFK?usp=sharing

Comment 2 Sam Lucidi 2021-05-13 13:20:58 UTC

https://github.com/konveyor/forklift-controller/pull/263

Comment 3 Fabien Dupont 2021-05-17 08:01:21 UTC

The fix is in build 2.0.0-15 / iib:75270

Comment 5 Nandini Chandra 2021-05-18 13:01:07 UTC

Sam had commented in bug 1953145 that this fix should take care of both failed and canceled VMs.  With this fix, the issue with canceled VMs is fixed, but not with *failed* VMs .

Sam said that he is investigating the issue with failed VMs.

Comment 6 Nandini Chandra 2021-05-18 17:12:26 UTC

In today's scrum call, it was agreed that I'd test today's build, 2.0.0-16 and update this BZ with the results.

I'm still seeing the issue with failed VMs on 2.0.0-16 .

Comment 7 Fabien Dupont 2021-05-19 05:04:07 UTC

The fix is in build 2.0.0-18 / iib:76039

Comment 8 Nandini Chandra 2021-05-19 16:50:51 UTC

Verified on 2.0.0-18

Comment 10 Nandini Chandra 2021-06-02 20:37:03 UTC

*** Bug 1953145 has been marked as a duplicate of this bug. ***

Comment 12 errata-xmlrpc 2021-06-10 17:12:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381