Bug 1959987 (crest) - Review Request: crest - Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package
Summary: Review Request: crest - Conformer-Rotamer Ensemble Sampling Tool based on the...
Keywords:
Status: CLOSED ERRATA
Alias: crest
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-12 18:45 UTC by Susi Lehtola
Modified: 2021-05-26 12:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-05-26 00:59:09 UTC
Type: ---
Embargoed:
code: fedora-review+


Attachments (Terms of Use)

Description Susi Lehtola 2021-05-12 18:45:20 UTC
Spec URL: https://jussilehtola.fedorapeople.org/crest.spec
SRPM URL: https://jussilehtola.fedorapeople.org/crest-2.11-1.fc34.src.rpm
Fedora Account System Username: jussilehtola

Description:
CREST is an utility/driver program for the xtb program. Originally it
was designed as conformer sampling program, hence the abbreviation
Conformer-Rotamer Ensemble Sampling Tool, but now offers also some
utility functions for calculations with the GFNn-xTB
methods. Generally the program functions as an IO based OMP scheduler
(i.e., calculations are performed by the xtb program) and tool for the
creation and analysation of structure ensembles.

The key procedure implemented in CREST is a conformational search
workflow abbreviated as iMTD-GC. The iMTD-GC workflow generates
conformer/rotamer ensembles (CREs) by extensive metadynamic sampling
(MTD) based on, with an additional genetic z-matrix crossing (GC) step
at the end. Other standalone functionalities that are included in
CREST are parallel optimization and screening functions for GFNn–xTB,
the function to sort (e.g. for NMR equivalencies) externally created
ensembles, and some automated procedures for the protonation,
deprotonation and tautomerization of structures.

The main publication for the CREST program can be found at
Phys. Chem. Chem. Phys., 2020, 22, 7169-7192.

Comment 1 Ben Beasley 2021-05-15 15:18:36 UTC
This a very high-quality submission. Thanks!

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======

- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

  You have correctly BR’d gcc-gfortran, which implies gcc, so fedora-review may
  be a bit overzealous here. Still, a direct BR on plain gcc wouldn’t hurt
  since you do have some C sources. It’s a minor quibble at most.

- From rpmlint:

    crest.x86_64: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package

  Looking at the description, which suggests the above summary is out of date
  anyway, why not use something like this?

    Summary:        Utility/driver program for xtb

- It looks like you should have something like:

    # The entire source is GPLv3+ except:
    #
    # GPLv2+:
    #   - src/symmetry_i.c
    # LGPLv2+:
    #   - src/ls_rmsd.f90
    #   - src/spline.f90
    #
    # Certain build-system files are LGPLv3+, but they do not contribute to the
    # license of the built RPMs.
    License:        GPLv3+ and GPLv2+ and LGPLv2+

  Please see
  https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios
  for the relevant guidelines.

- The following file has an obsolete Free Software Foundation postal address
  in its license statement. Please bring this to the attention of the
  upstream developers so they can fix it in a future release.

    - src/symmetry_i.c

- Please change:

    %define soname 6

  to:

    %global soname 6

  See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define.


===== Notes (not Issues!) =====

- Correctly justified ExcludeArch: s390x. Please file a bugzilla blocking
  F-ExcludeArch-s390x after the package is imported
  (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures),
  and add a link above the ExcludeArch in the spec file at that time.

- My compliments on getting the flexiblas part correct, and on getting the
  necessary patch included upstream.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* GNU Lesser General Public License v3.0 or
     later", "Unknown or generated", "GNU Lesser General Public License
     v3.0 or later", "GNU Lesser General Public License v2.1 or later",
     "*No copyright* GNU Lesser General Public License", "GNU General
     Public License v2.0 or later [obsolete FSF postal address (Mass
     Ave)]". 33 files have unknown license. Detailed output of licensecheck
     in /home/reviewer/1959987-crest/licensecheck.txt

     See the Issues section, above.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.

     Correctly justified ExcludeArch: s390x. Please file a bugzilla blocking
     F-ExcludeArch-s390x after the package is imported
     (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures).

[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines

     (except as noted)

[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.

     (based on tests passing)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.

     Correctly justified ExcludeArch.

[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define soname 6
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: crest-2.11-1.fc35.x86_64.rpm
          crest-debuginfo-2.11-1.fc35.x86_64.rpm
          crest-debugsource-2.11-1.fc35.x86_64.rpm
          crest-2.11-1.fc35.src.rpm
crest.x86_64: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package
crest.x86_64: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization
crest.x86_64: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation
crest.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
crest.x86_64: W: spelling-error %description -l en_US iMTD -> timid
crest.x86_64: W: spelling-error %description -l en_US rotamer -> roamer, tamer
crest.x86_64: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic
crest.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
crest.x86_64: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation
crest.x86_64: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation
crest.x86_64: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization
crest.x86_64: W: no-manual-page-for-binary crest
crest.src: W: spelling-error Summary(en_US) xtb -> TB
crest.src: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package
crest.src: W: spelling-error %description -l en_US xtb -> TB
crest.src: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization
crest.src: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation
crest.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
crest.src: W: spelling-error %description -l en_US iMTD -> timid
crest.src: W: spelling-error %description -l en_US rotamer -> roamer, tamer
crest.src: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic
crest.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
crest.src: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation
crest.src: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation
crest.src: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization
4 packages and 0 specfiles checked; 2 errors, 23 warnings.




Rpmlint (debuginfo)
-------------------
Checking: crest-debuginfo-2.11-1.fc35.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
crest.x86_64: E: summary-too-long C Conformer-Rotamer Ensemble Sampling Tool based on the xtb Semiempirical Extended Tight-Binding Program Package
crest.x86_64: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization
crest.x86_64: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation
crest.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
crest.x86_64: W: spelling-error %description -l en_US iMTD -> timid
crest.x86_64: W: spelling-error %description -l en_US rotamer -> roamer, tamer
crest.x86_64: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic
crest.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
crest.x86_64: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation
crest.x86_64: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation
crest.x86_64: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization
crest.x86_64: W: no-manual-page-for-binary crest
3 packages and 0 specfiles checked; 1 errors, 11 warnings.



Source checksums
----------------
https://github.com/grimme-lab/crest/archive/v2.11/crest-2.11.tar.gz :
  CHECKSUM(SHA256) this package     : e6d9154b6e22a88709203945fa24f1ecccb5d5a5906111c225ad5749125252f4
  CHECKSUM(SHA256) upstream package : e6d9154b6e22a88709203945fa24f1ecccb5d5a5906111c225ad5749125252f4


Requires
--------
crest (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libflexiblas.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgfortran.so.5()(64bit)
    libgfortran.so.5(GFORTRAN_10)(64bit)
    libgfortran.so.5(GFORTRAN_8)(64bit)
    libgomp.so.1()(64bit)
    libgomp.so.1(GOMP_1.0)(64bit)
    libgomp.so.1(GOMP_2.0)(64bit)
    libgomp.so.1(GOMP_4.0)(64bit)
    libgomp.so.1(OMP_1.0)(64bit)
    libm.so.6()(64bit)
    rtld(GNU_HASH)
    xtb

crest-debuginfo (rpmlib, GLIBC filtered):

crest-debugsource (rpmlib, GLIBC filtered):



Provides
--------
crest:
    crest
    crest(x86-64)

crest-debuginfo:
    crest-debuginfo
    crest-debuginfo(x86-64)
    debuginfo(build-id)

crest-debugsource:
    crest-debugsource
    crest-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1959987
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: Python, Java, fonts, Perl, Ocaml, Ruby, Haskell, PHP, SugarActivity, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Susi Lehtola 2021-05-15 18:47:12 UTC
BR: gcc added as there are indeed a few C files.

I've shortened the summary to "Conformer-Rotamer Ensemble Sampling Tool: a driver for the xtb program"

The license field applies to the generated binaries; GPLv2+ and GPLv3+ results in the GPLv3+ license.
See https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F
If this was e.g. a Python package, the licenses should be specified separately.

src/symmetry_i.c appears to originate from another project, like the other C sources, but I can file a PR upstream, see https://github.com/grimme-lab/crest/pull/55

I've also changed the %define to %global.

Spec URL: https://jussilehtola.fedorapeople.org/crest.spec
SRPM URL: https://jussilehtola.fedorapeople.org/crest-2.11-2.fc34.src.rpm

Comment 3 Ben Beasley 2021-05-17 11:55:37 UTC
> The license field applies to the generated binaries; GPLv2+ and GPLv3+ results in the GPLv3+ license.
> See https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F
> If this was e.g. a Python package, the licenses should be specified separately.

This is an interesting corner of the wiki, with quite a few ideas that didn’t make it into https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/. I’m willing to agree in this case, especially with a similar concept showing up on the fedora-legal list recently (https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/W57JRNLWVOT55D7TDF7VYFMJT5QMBEGR/).

-----

All other issues are dealt with in your last update. Thanks! Package approved.

-----

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* GNU Lesser General Public License v3.0 or
     later", "Unknown or generated", "GNU Lesser General Public License
     v3.0 or later", "GNU Lesser General Public License v2.1 or later",
     "*No copyright* GNU Lesser General Public License", "GNU General
     Public License v2.0 or later [obsolete FSF postal address (Mass
     Ave)]". 33 files have unknown license. Detailed output of licensecheck
     in /home/reviewer/1959987-crest/2/1959987-crest/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.

     Correctly justified ExcludeArch: s390x. Please file a bugzilla blocking
     F-ExcludeArch-s390x after the package is imported
     (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures).

[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.

     (based on tests passing)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.

     Correctly justified ExcludeArch.

[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: crest-2.11-2.fc35.x86_64.rpm
          crest-debuginfo-2.11-2.fc35.x86_64.rpm
          crest-debugsource-2.11-2.fc35.x86_64.rpm
          crest-2.11-2.fc35.src.rpm
crest.x86_64: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization
crest.x86_64: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation
crest.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
crest.x86_64: W: spelling-error %description -l en_US iMTD -> timid
crest.x86_64: W: spelling-error %description -l en_US rotamer -> roamer, tamer
crest.x86_64: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic
crest.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
crest.x86_64: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation
crest.x86_64: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation
crest.x86_64: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization
crest.x86_64: W: no-manual-page-for-binary crest
crest.src: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization
crest.src: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation
crest.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
crest.src: W: spelling-error %description -l en_US iMTD -> timid
crest.src: W: spelling-error %description -l en_US rotamer -> roamer, tamer
crest.src: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic
crest.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
crest.src: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation
crest.src: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation
crest.src: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization
4 packages and 0 specfiles checked; 0 errors, 21 warnings.




Rpmlint (debuginfo)
-------------------
Checking: crest-debuginfo-2.11-2.fc35.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
crest.x86_64: W: spelling-error %description -l en_US analysation -> transnational, sensational, nasalization
crest.x86_64: W: spelling-error %description -l en_US conformational -> informational, confrontational, confirmation
crest.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
crest.x86_64: W: spelling-error %description -l en_US iMTD -> timid
crest.x86_64: W: spelling-error %description -l en_US rotamer -> roamer, tamer
crest.x86_64: W: spelling-error %description -l en_US metadynamic -> meta dynamic, meta-dynamic, aerodynamic
crest.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
crest.x86_64: W: spelling-error %description -l en_US protonation -> profanation, protestation, propitiation
crest.x86_64: W: spelling-error %description -l en_US deprotonation -> depredation, depreciation, deprecation
crest.x86_64: W: spelling-error %description -l en_US tautomerization -> cauterization, computerization, containerization
crest.x86_64: W: no-manual-page-for-binary crest
3 packages and 0 specfiles checked; 0 errors, 11 warnings.



Source checksums
----------------
https://github.com/grimme-lab/crest/archive/v2.11/crest-2.11.tar.gz :
  CHECKSUM(SHA256) this package     : e6d9154b6e22a88709203945fa24f1ecccb5d5a5906111c225ad5749125252f4
  CHECKSUM(SHA256) upstream package : e6d9154b6e22a88709203945fa24f1ecccb5d5a5906111c225ad5749125252f4


Requires
--------
crest (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libflexiblas.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgfortran.so.5()(64bit)
    libgfortran.so.5(GFORTRAN_10)(64bit)
    libgfortran.so.5(GFORTRAN_8)(64bit)
    libgomp.so.1()(64bit)
    libgomp.so.1(GOMP_1.0)(64bit)
    libgomp.so.1(GOMP_2.0)(64bit)
    libgomp.so.1(GOMP_4.0)(64bit)
    libgomp.so.1(OMP_1.0)(64bit)
    libm.so.6()(64bit)
    rtld(GNU_HASH)
    xtb

crest-debuginfo (rpmlib, GLIBC filtered):

crest-debugsource (rpmlib, GLIBC filtered):



Provides
--------
crest:
    crest
    crest(x86-64)

crest-debuginfo:
    crest-debuginfo
    crest-debuginfo(x86-64)
    debuginfo(build-id)

crest-debugsource:
    crest-debugsource
    crest-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1959987
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Ocaml, Python, Ruby, SugarActivity, Perl, Haskell, R, fonts, Java, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Gwyn Ciesla 2021-05-17 15:00:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/crest

Comment 5 Susi Lehtola 2021-05-17 21:04:47 UTC
Thanks for the review!

Comment 6 Fedora Update System 2021-05-17 22:00:15 UTC
FEDORA-2021-40b90dface has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-40b90dface

Comment 7 Fedora Update System 2021-05-17 22:00:16 UTC
FEDORA-2021-47ec434d57 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-47ec434d57

Comment 8 Fedora Update System 2021-05-18 01:35:33 UTC
FEDORA-2021-47ec434d57 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-47ec434d57 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-47ec434d57

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-05-18 01:58:53 UTC
FEDORA-2021-40b90dface has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-40b90dface \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-40b90dface

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-05-26 00:59:09 UTC
FEDORA-2021-40b90dface has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2021-05-26 01:09:40 UTC
FEDORA-2021-47ec434d57 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.