Bug 1960329 - %llu in qemu provided tapset
Summary: %llu in qemu provided tapset
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: qemu
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fedora Virtualization Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1912972 1963186 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-13 17:02 UTC by Ben Woodard
Modified: 2021-05-24 01:01 UTC (History)
10 users (show)

Fixed In Version: qemu-5.2.0-7.fc34
Clone Of:
Environment:
Last Closed: 2021-05-24 01:01:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ben Woodard 2021-05-13 17:02:02 UTC
Description of problem:
 /usr/share/systemtap/tapset/qemu-system-<arch>-log.stp has %llu in it causing systemtap to fail.

stap --dyninst varwatch.stp 'process("/usr/lib64/libpython3.8.so.1.0").statement("PyEval_EvalCodeEx@*:*")' '$$parms' -c '/usr/bin/python3 pyexample.py 35'
parse error: invalid or missing conversion specifier
        saw: operator ',' at /usr/share/systemtap/tapset/qemu-system-aarch64-log.stp:15034:101
     source:     printf("%d@%d vhost_vdpa_set_log_base dev: %p base: 0x%x size: %llu refcnt: %d fd: %d log: %p\n", pid(), gettimeofday_ns(), dev, base, size, refcnt, fd, log)
                                                                                                                 ^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/qemu-system-aarch64-log.stp" has errors, and will be skipped
1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/qemu-system-i386-log.stp" has errors, and will be skipped
1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/qemu-system-x86_64-log.stp" has errors, and will be skipped
parse error: expected statement
        saw: varwatch.stp EOF

1 parse error.
Pass 1: parse failed.  [man error::pass1]
Number of similar error messages suppressed: 2.
Rerun with -v to see them.



Version-Release number of selected component (if applicable):
qemu-5.2.0-5.fc34.1.src.rpm

How reproducible:
always

Steps to Reproduce:
1. run systemtap with basically any tapset

Actual results:
error pasted above

Expected results:
Works.



Additional info:
editing the file so that the %llu is replaced with %lu fixes the problem

Comment 1 Philippe Mathieu-Daudé 2021-05-13 17:08:36 UTC
Fixed by commit 09612de7e9a ("tracetool: also strip %l and %ll from systemtap format strings").
https://gitlab.com/qemu-project/qemu/-/commit/09612de7e9a

Comment 2 Cole Robinson 2021-05-19 20:27:41 UTC
*** Bug 1912972 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Update System 2021-05-19 23:26:01 UTC
FEDORA-2021-303ad002d2 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-303ad002d2

Comment 4 Fedora Update System 2021-05-21 01:35:37 UTC
FEDORA-2021-303ad002d2 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-303ad002d2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-303ad002d2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Cole Robinson 2021-05-23 17:48:40 UTC
*** Bug 1963186 has been marked as a duplicate of this bug. ***

Comment 6 Fedora Update System 2021-05-24 01:01:34 UTC
FEDORA-2021-303ad002d2 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.