Spec URL: https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit.spec SRPM URL: https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit-1.2.2-1.fc34.src.rpm Description: Kit for developing MAUI Apps. MauiKit is a set of utilities and "templated" controls based on Kirigami and QCC2 that follow the ongoing work on the Maui HIG. It let you quickly create a Maui application and access utilities and widgets shared amoing the other Maui apps. Fedora Account System Username: thunderbirdtr
- Use %exclude here to avoid including files twice + simplify includes %files %license LICENSE %{_kf5_qmldir}/QtQuick/Controls.2/maui-style/ %{_kf5_qmldir}/org/mauikit/ %exclude %{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h %exclude %{_kf5_qmldir}/org/mauikit/controls/libs/appview.h %exclude %{_kf5_qmldir}/org/mauikit/controls/libs/tabview.h %files devel %doc README.md %{_kf5_libdir}/libMauiKit.so %{_includedir}/MauiKit/ %{_libdir}/cmake/MauiKit/ %{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h %{_kf5_qmldir}/org/mauikit/controls/libs/appview.h %{_kf5_qmldir}/org/mauikit/controls/libs/tabview.h - Fix this typo in the description: maui-mauikit.x86_64: W: spelling-error %description -l en_US amoing -> among, amounting - Remove this GIT file: maui-mauikit.x86_64: E: version-control-internal-file /usr/lib64/qt5/qml/QtQuick/Controls.2/maui-style/.gitignore Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: maui-mauikit : /usr/lib64/qt5/qml/org/mauikit/controls/csd/libappletdecoration/config- decoration.h maui-mauikit : /usr/lib64/qt5/qml/org/mauikit/controls/libs/appview.h maui-mauikit : /usr/lib64/qt5/qml/org/mauikit/controls/libs/tabview.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 3", "GNU Library General Public License v2 or later", "GNU Lesser General Public License, Version 3 GNU General Public License v2.0 or later", "GNU General Public License v3.0 or later", "GNU General Public License, Version 3", "GNU General Public License v2.0 or later", "GNU General Public License, Version 2". 189 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/maui-mauikit/review-maui- mauikit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/cmake/MauiKit, /usr/include/MauiKit, /usr/include/MauiKit/Core [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: maui-mauikit-1.2.2-1.fc35.x86_64.rpm maui-mauikit-devel-1.2.2-1.fc35.x86_64.rpm maui-mauikit-debuginfo-1.2.2-1.fc35.x86_64.rpm maui-mauikit-debugsource-1.2.2-1.fc35.x86_64.rpm maui-mauikit-1.2.2-1.fc35.src.rpm maui-mauikit.x86_64: W: spelling-error %description -l en_US templated -> templates, template, template d maui-mauikit.x86_64: W: spelling-error %description -l en_US amoing -> among, amounting maui-mauikit.x86_64: W: no-documentation maui-mauikit.x86_64: E: version-control-internal-file /usr/lib64/qt5/qml/QtQuick/Controls.2/maui-style/.gitignore maui-mauikit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/qml/org/mauikit/controls/csd/libappletdecoration/config-decoration.h maui-mauikit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/qml/org/mauikit/controls/libs/appview.h maui-mauikit.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/qml/org/mauikit/controls/libs/tabview.h maui-mauikit-devel.x86_64: E: invalid-soname /usr/lib64/libMauiKit.so libMauiKit.so maui-mauikit.src: W: spelling-error %description -l en_US templated -> templates, template, template d maui-mauikit.src: W: spelling-error %description -l en_US amoing -> among, amounting 5 packages and 0 specfiles checked; 2 errors, 8 warnings.
According the this change : https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/RWUGI5HAPH6FTM46QUC534ZE4HLMMOSG/ I decided to not use excludes but I fixed with a different way. %files %license LICENSE %{_kf5_qmldir}/QtQuick/Controls.2/maui-style/ %{_kf5_qmldir}/org/mauikit/controls/*.qml %{_kf5_qmldir}/org/mauikit/controls/labs/*.qml %{_kf5_qmldir}/org/mauikit/controls/index.qdoc %{_kf5_qmldir}/org/mauikit/controls/labs/index.qdoc %{_kf5_qmldir}/org/mauikit/controls/plugin/*.qml %{_kf5_qmldir}/org/mauikit/controls/private/*.qml %{_kf5_qmldir}/org/mauikit/controls/private/shapes/*.qml %files devel %doc README.md %{_kf5_libdir}/libMauiKit.so %{_includedir}/MauiKit/Core/*.h %{_kf5_qmldir}/org/mauikit/controls/libs/*.h %{_kf5_libdir}/qt5/qml/org/mauikit/controls/qmldir %{_kf5_libdir}/qt5/qml/org/mauikit/controls/libMauiKit.so %{_kf5_libdir}/qt5/qml/org/mauikit/controls/csd/libappletdecoration/prefix.sh %{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h %{_libdir}/cmake/MauiKit/MauiKitConfig.cmake %{_libdir}/cmake/MauiKit/MauiKitConfigVersion.cmake %{_libdir}/cmake/MauiKit/MauiKitTargets-noconfig.cmake %{_libdir}/cmake/MauiKit/MauiKitTargets.cmake
side note : I pushed all changes into pagure
By doing this you do not own the directories where the files are located: %dir %{_kf5_qmldir}/org/mauikit/ %dir %{_kf5_qmldir}/org/mauikit/controls/ %dir %{_kf5_qmldir}/org/mauikit/controls/labs/ %dir %{_kf5_qmldir}/org/mauikit/controls/plugin/ %dir %{_kf5_qmldir}/org/mauikit/controls/private/ %dir %{_includedir}/MauiKit/ %dir %{_libdir}/cmake/MauiKit/
When I made changes and add others as well like this; %files %license LICENSE %dir %{_kf5_qmldir}/org/mauikit/ %dir %{_kf5_qmldir}/org/mauikit/controls/ %dir %{_kf5_qmldir}/org/mauikit/controls/labs/ %dir %{_kf5_qmldir}/org/mauikit/controls/plugin/ %dir %{_kf5_qmldir}/org/mauikit/controls/private/ %dir %{_kf5_qmldir}/org/mauikit/controls/private/shapes/ %dir %{_kf5_qmldir}/QtQuick/Controls.2/ %{_kf5_qmldir}/QtQuick/Controls.2/maui-style/ %{_kf5_qmldir}/org/mauikit/controls/*.qml %{_kf5_qmldir}/org/mauikit/controls/labs/*.qml %{_kf5_qmldir}/org/mauikit/controls/index.qdoc %{_kf5_qmldir}/org/mauikit/controls/labs/index.qdoc %{_kf5_qmldir}/org/mauikit/controls/plugin/*.qml %{_kf5_qmldir}/org/mauikit/controls/private/*.qml %{_kf5_qmldir}/org/mauikit/controls/private/shapes/*.qml %files devel %doc README.md %dir %{_includedir}/MauiKit/ %dir %{_libdir}/cmake/MauiKit/ %dir %{_includedir}/MauiKit/Core/ %dir %{_kf5_qmldir}/org/mauikit/controls/ %dir %{_kf5_qmldir}/org/mauikit/controls/csd %dir %{_kf5_libdir}/qt5/qml/org/mauikit/controls/csd/libappletdecoration/ %dir %{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/ %dir %{_kf5_qmldir}/org/mauikit/controls/libs/ %{_kf5_libdir}/libMauiKit.so %{_includedir}/MauiKit/Core/*.h %{_kf5_qmldir}/org/mauikit/controls/libs/*.h %{_kf5_libdir}/qt5/qml/org/mauikit/controls/qmldir %{_kf5_libdir}/qt5/qml/org/mauikit/controls/libMauiKit.so %{_kf5_libdir}/qt5/qml/org/mauikit/controls/csd/libappletdecoration/prefix.sh %{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h %{_libdir}/cmake/MauiKit/MauiKitConfig.cmake %{_libdir}/cmake/MauiKit/MauiKitConfigVersion.cmake %{_libdir}/cmake/MauiKit/MauiKitTargets-noconfig.cmake %{_libdir}/cmake/MauiKit/MauiKitTargets.cmake This is the review result; [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/qt5/qml/org/mauikit/controls/csd, /usr/lib64/qt5/qml/org/mauikit/controls/csd/libappletdecoration, /usr/lib64/qt5/qml/org/mauikit/controls/private/shapes, /usr/lib64/qt5/qml/org/mauikit/controls/libs, /usr/include/MauiKit/Core, /usr/lib64/qt5/qml/QtQuick/Controls.2 Any idea for that ? Thank you.
I don't know why it isn't working but I'd recommend using %exclude as I initially recommended. (In reply to Onuralp SEZER from comment #2) > According the this change : > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ > message/RWUGI5HAPH6FTM46QUC534ZE4HLMMOSG/ > > I decided to not use excludes but I fixed with a different way. > This change does not apply here, this change prevents using exclude to not include a file in any of the subpackage instead of deleting it at %install. Here we are using it the correct way to dispatch the files between subpackage.
It is done(I used %exlude way) : https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit.spec
(In reply to Onuralp SEZER from comment #7) > It is done(I used %exlude way) : > https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit.spec %exclude** way
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/maui-mauikit
Package is available in repositories, closing.