Bug 1961173 - recreate existing static pod manifests instead of updating
Summary: recreate existing static pod manifests instead of updating
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: kube-apiserver
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.8.0
Assignee: Michal Fojtik
QA Contact: Ke Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-17 12:26 UTC by Michal Fojtik
Modified: 2021-07-27 23:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 23:08:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-kube-apiserver-operator pull 1132 0 None open Bug 1961173: bump(*): library-go update 2021-05-18 13:14:31 UTC
Github openshift cluster-kube-controller-manager-operator pull 524 0 None open Bug 1961173: bump(*): vendor update 2021-05-17 12:29:07 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:08:57 UTC

Description Michal Fojtik 2021-05-17 12:26:38 UTC
Description of problem:

As noticed by SNO team, the static pod installer overwrites the existing static pod manifest files instead of recreating them. This might confuse kubelet or tooling that watch for changes in the folder where we write those files and in some (rare) cases the "update" event might be missed by tools like inotify.


Version-Release number of selected component (if applicable):

4.8/master

How reproducible:

Almost impossible to reproduce this, it is a corner case.
This probably doesn't require a QE, the CI test runs were enough to mitigate any regression risks.


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

This BZ is needed to merge the library-go with fix bump into static pod operators.

Comment 2 Ke Wang 2021-05-27 03:43:14 UTC
Per bug commment 0, try to reproduce, it is a corner case, QE can do less, just checked the bug related PR have been landed in latest 4.8 nightly payload.

$ oc adm release info --commits registry.ci.openshift.org/ocp/release:4.8.0-0.nightly-2021-05-26-172234 | grep kube-apiserver-operator
  cluster-kube-apiserver-operator    https://github.com/openshift/cluster-kube-apiserver-operator   ce4170b4a040fc03603f62d686a6e9ea0cadde34

$ git log --pretty="%h %an %cd - %s" ce4170b4 | grep '#1132 '
45a3c93b OpenShift Merge Robot Tue May 18 21:25:01 2021 -0400 - Merge pull request #1132 from mfojtik/bump-static-pod
  
$ oc adm release info --commits registry.ci.openshift.org/ocp/release:4.8.0-0.nightly-2021-05-26-172234 | grep kube-controller-manager-operator
  cluster-kube-controller-manager-operator https://github.com/openshift/cluster-kube-controller-manager-operator  b00edfda6e300fd4c611c610450afeaafd0c9c44 
  
$ git log --pretty="%h %an %cd - %s" b00edfda | grep '#524 '
64ac616f OpenShift Merge Robot Mon May 17 08:31:21 2021 -0400 - Merge pull request #524 from mfojtik/bump-static-pod

Comment 5 errata-xmlrpc 2021-07-27 23:08:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.