Bug 1961356 - Update single quotes to double quotes in string
Summary: Update single quotes to double quotes in string
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.8.0
Assignee: Steve Goodwin
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-17 18:43 UTC by ralpert
Modified: 2021-07-27 23:09 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 23:08:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
double quotes in string (92.95 KB, image/png)
2021-05-26 06:46 UTC, Yadan Pei
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8963 0 None open Bug 1961356: Switch to double quotes in translation 2021-05-18 16:01:50 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:09:02 UTC

Description ralpert 2021-05-17 18:43:51 UTC
Description of problem:
"Secret referenced in the {{triggerProperty}} webhook trigger does not contain 'WebHookSecretKey' key. Webhook trigger won’t work due to the invalid secret reference" in frontend/public/locales/ja/public.json should have double quotes ("") around "WebHookSecretKey." You can use them if you escape them with a backslash.

Version-Release number of selected component (if applicable):
4.8

How reproducible:
Always

Steps to Reproduce:
1. Look at frontend/public/locales/ja/public.json

Actual results:
Single quotes

Expected results:
Double quotes 

Additional info:

Comment 2 Yadan Pei 2021-05-26 06:45:48 UTC
1. Create a secret 'simplesecret' for reference, when creating the secret don't add 'WebHookSecretKey' key.
2. Create a BuildConfig, after BC is successfully created, hen edit its YAML and add GitLab webhook sections as following 

    - type: GitLab
      gitlab:
        secretReference:
          name: "simplesecret"
3. Visit BuildConfig details page, click 'Copy URL with secret' button, an error modal will be shown, the content is pesudo translated
[Ṣḛḛͼṛḛḛţ ṛḛḛϝḛḛṛḛḛṇͼḛḛḍ ḭḭṇ ţḥḛḛ ḡḭḭţḽααḅ ẁḛḛḅḥṓṓṓṓḳ ţṛḭḭḡḡḛḛṛ ḍṓṓḛḛṡ ṇṓṓţ ͼṓṓṇţααḭḭṇ "ŴḛḛḅḤṓṓṓṓḳṢḛḛͼṛḛḛţḰḛḛẏẏ" ḳḛḛẏẏ. Ŵḛḛḅḥṓṓṓṓḳ ţṛḭḭḡḡḛḛṛ ẁṓṓṇ’ţ ẁṓṓṛḳ ḍṵṵḛḛ ţṓṓ ţḥḛḛ ḭḭṇṽααḽḭḭḍ ṡḛḛͼṛḛḛţ ṛḛḛϝḛḛṛḛḛṇͼḛḛ]


Verified on 4.8.0-0.nightly-2021-05-25-180327, the issue reported in this bug has been resolved

Comment 3 Yadan Pei 2021-05-26 06:46:28 UTC
In the error message we can see double quotes are used

Comment 4 Yadan Pei 2021-05-26 06:46:48 UTC
Created attachment 1787096 [details]
double quotes in string

Comment 7 errata-xmlrpc 2021-07-27 23:08:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.