Bug 1961379 (CVE-2021-22904) - CVE-2021-22904 rails: Possible DoS Vulnerability in Action Controller Token Authentication
Summary: CVE-2021-22904 rails: Possible DoS Vulnerability in Action Controller Token A...
Keywords:
Status: CLOSED ERRATA
Alias: CVE-2021-22904
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1961380 1961657 1961658
Blocks: 1961381 1997390
TreeView+ depends on / blocked
 
Reported: 2021-05-17 19:17 UTC by Pedro Sampaio
Modified: 2021-12-14 18:47 UTC (History)
36 users (show)

Fixed In Version: actionpack-6.0.3.7, actionpack-6.1.3.2, actionpack-5.2.6, actionpack-5.2.4.6
Doc Type: If docs needed, set a value
Doc Text:
A flaw was found in RubyGem Actionpack which is framework for handling and responding to web requests in Rails. A possible DoS vulnerability was found in the Token Authentication logic in Action Controller.
Clone Of:
Environment:
Last Closed: 2021-11-13 15:49:57 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2021:4702 0 None None None 2021-11-16 14:08:10 UTC

Description Pedro Sampaio 2021-05-17 19:17:25 UTC
There is a possible DoS vulnerability in the Token Authentication logic in
Action Controller.  This vulnerability has been assigned the CVE identifier
CVE-2021-22904.

Versions Affected:  >= 4.0.0
Not affected:       < 4.0.0
Fixed Versions:     6.1.3.2, 6.0.3.7, 5.2.4.6, 5.2.6

Impact
------
Impacted code uses `authenticate_or_request_with_http_token` or
`authenticate_with_http_token` for request authentication.  Impacted code
will
look something like this:

```
class PostsController < ApplicationController
  before_action :authenticate

  private

  def authenticate
    authenticate_or_request_with_http_token do |token, options|
      # ...
    end
  end
end
```

All users running an affected release should either upgrade or use one of
the
workarounds immediately.

Releases
--------
The fixed releases are available at the normal locations.

Workarounds
-----------
The following monkey patch placed in an initializer can be used to work
around
the issue:

```ruby
module ActionController::HttpAuthentication::Token
  AUTHN_PAIR_DELIMITERS = /(?:,|;|\t)/
end
```

Patches
-------
To aid users who aren't able to upgrade immediately we have provided
patches for
the two supported release series. They are in git-am format and consist of a
single changeset.

* 5-2-http-authentication-dos.patch - Patch for 5.2 series
* 6-0-http-authentication-dos.patch - Patch for 6.0 series
* 6-1-http-authentication-dos.patch - Patch for 6.1 series

Please note that only the 6.1.Z, 6.0.Z, and 5.2.Z series are supported at
present. Users of earlier unsupported releases are advised to upgrade as
soon
as possible as we cannot guarantee the continued availability of security
fixes for unsupported releases.

Credits
-------
Thank you to https://hackerone.com/wonda_tea_coffee for reporting this
issue!

-- 
Aaron Patterson
http://tenderlovemaking.com/

Comment 1 Pedro Sampaio 2021-05-17 19:18:23 UTC
Created rubygem-rails tracking bugs for this issue:

Affects: fedora-all [bug 1961380]

Comment 2 Yadnyawalk Tale 2021-05-18 12:18:58 UTC
// Satellite analysis

+---------------+--------------------------------------+----------+
| rhn_satellite | package name and versions            | status   |
+---------------+--------------------------------------+----------+
| 6.7           | tfm-ror52-rubygem-actionpack-5.2.1-1 | affected |
| 6.8           | tfm-rubygem-actionpack-6.0.3.1-1     | affected |
| 6.9           | tfm-rubygem-actionpack-6.0.3.4-1     | affected |
+---------------+--------------------------------------+----------+

We are not vulnerable in code as we are using `authenticate_or_request_with_http_token` or `authenticate_with_http_token` in Satellite (foreman/katello).

Comment 7 errata-xmlrpc 2021-11-16 14:08:08 UTC
This issue has been addressed in the following products:

  Red Hat Satellite 6.10 for RHEL 7

Via RHSA-2021:4702 https://access.redhat.com/errata/RHSA-2021:4702


Note You need to log in before you can comment on or make changes to this bug.