Bug 1961588 - Review Request: rust-directories-next - a rust library for retrieving and storing configuration, cache and other data directories
Summary: Review Request: rust-directories-next - a rust library for retrieving and sto...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-18 10:13 UTC by Trystram
Modified: 2021-06-05 01:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-05 01:04:02 UTC
Type: Bug
Embargoed:
o.lemasle: fedora-review+


Attachments (Terms of Use)

Description Trystram 2021-05-18 10:13:17 UTC
spec file : https://gitlab.com/jbtrystram/rust-directories-next/-/raw/main/rust-directories-next.spec
SRPM file : https://gitlab.com/jbtrystram/rust-directories-next/-/raw/main/rust-directories-next-2.0.0-1.fc35.src.rpm

Description: library providing platform-specific standard locations of directories for config, cache and other data.

Fedora Account System Username: jbtrystram
Koji build : https://koji.fedoraproject.org/koji/taskinfo?taskID=68195610
Hello, this library is needed as a dependency for another app that i would like to get into fedora.

The aim is to get "navi" into fedora : https://github.com/denisidoro/navi

Comment 1 Olivier Lemasle 2021-05-20 14:36:11 UTC
Please modify the summary to remove rpmlint errors (should not exceed 79 characters, should start with an uppercase, and should not end with a dot)

Rpmlint
-------
Checking: rust-directories-next-devel-2.0.0-1.fc35.noarch.rpm
          rust-directories-next+default-devel-2.0.0-1.fc35.noarch.rpm
          rust-directories-next-2.0.0-1.fc35.src.rpm
rust-directories-next-devel.noarch: W: summary-not-capitalized C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next-devel.noarch: W: summary-ended-with-dot C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next-devel.noarch: E: summary-too-long C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next-devel.noarch: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS
rust-directories-next-devel.noarch: W: invalid-url URL: https://crates.io/crates/directories-next HTTP Error 404: Not Found
rust-directories-next-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/directories-next-2.0.0/.cargo-checksum.json
rust-directories-next+default-devel.noarch: W: summary-not-capitalized C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next+default-devel.noarch: W: summary-ended-with-dot C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next+default-devel.noarch: E: summary-too-long C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next+default-devel.noarch: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS
rust-directories-next+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/directories-next HTTP Error 404: Not Found
rust-directories-next+default-devel.noarch: W: no-documentation
rust-directories-next.src: W: summary-not-capitalized C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next.src: W: summary-ended-with-dot C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next.src: E: summary-too-long C library providing platform-specific standard locations of directories for config, cache and other data.
rust-directories-next.src: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS
rust-directories-next.src: W: invalid-url URL: https://crates.io/crates/directories-next HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 3 errors, 14 warnings.

Comment 2 Trystram 2021-05-25 14:34:26 UTC
I updated the summary to comply with the rules of rpmlint. Thanks for giving me the character count limit i did not know it. 

spec file : https://gitlab.com/jbtrystram/rust-directories-next/-/raw/main/rust-directories-next.spec
SRPM file : https://gitlab.com/jbtrystram/rust-directories-next/-/raw/main/rust-directories-next-2.0.0-1.fc35.src.rpm

koji build : https://koji.fedoraproject.org/koji/taskinfo?taskID=68700201

Comment 3 Olivier Lemasle 2021-05-25 15:59:58 UTC
Thanks!

 - Licenses ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines
 - No rpmlint error

Package approved.

Comment 4 Gwyn Ciesla 2021-05-26 14:02:12 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-directories-next

Comment 5 Fedora Update System 2021-05-27 08:36:09 UTC
FEDORA-2021-290371673c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-290371673c

Comment 6 Fedora Update System 2021-05-28 02:04:46 UTC
FEDORA-2021-290371673c has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-290371673c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-290371673c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-06-05 01:04:02 UTC
FEDORA-2021-290371673c has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.