Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1961598

Summary:	race in Termination.java
Product:	[oVirt] ovirt-engine-dwh	Reporter:	Dmitry Voronetskiy <vda1999>
Component:	General	Assignee:	Artur Socha <asocha>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Guilherme Santos <gdeolive>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.3.6	CC:	alitman, bugs, eshenitz, mperina, sradco
Target Milestone:	ovirt-4.4.7	Keywords:	ZStream
Target Release:	4.4.7.1	Flags:	pm-rhel: ovirt-4.4+
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	ovirt-engine-dwh-4.4.7.1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-14 13:08:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dmitry Voronetskiy 2021-05-18 11:09:11 UTC

Description of problem:

There is a potential race in Termination.getInstance that may lead to several instances being created. In that case only one instance would catch signals, while the others would always return false from shouldterminate()


Actual results:

https://gerrit.ovirt.org/c/ovirt-dwh/+/114804

Comment 1 RHEL Program Management 2021-05-18 18:53:35 UTC

The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 2 Aviv Litman 2021-05-27 07:26:51 UTC

Hi Dmitry,
Can you please provide steps to reproduce? so will be able to test it.

Thank you,
Aviv

Comment 3 Dmitry Voronetskiy 2021-05-27 07:42:10 UTC

(In reply to Aviv Litman from comment #2)
> Hi Dmitry,
> Can you please provide steps to reproduce? so will be able to test it.
> 
> Thank you,
> Aviv

It seems like in current oVirt code, Termination is only used in one thread, so   the problem can't be reproduced.

It is possible to write a programme which uses Termination in several threads and shows this bug, but I can't send it in the next days because I don't have access to my laptop.

Comment 5 Martin Perina 2021-05-27 13:11:16 UTC

Let's verify this only by running automation tests.

Comment 7 Aviv Litman 2021-06-01 12:39:21 UTC

Fix version: 4.4.7.1

Comment 8 Lukas Svaty 2021-07-14 13:08:43 UTC

This bug has low overall severity and passed an automated regression 
suite, and is not going to be further verified by QE. If you believe 
special care is required, feel free to re-open to ON_QA status.